[dpdk-test-report] |WARNING| pw70566 [PATCH v5 08/11] eal/windows: replace sys/queue.h with a complete one from FreeBSD

automatic DPDK test reports
 help / color / mirror / Atom feed

* [dpdk-test-report] |WARNING| pw70566 [PATCH v5 08/11] eal/windows: replace sys/queue.h with a complete one from FreeBSD
       [not found] <20200525003720.6410-9-dmitry.kozliuk@gmail.com>
@ 2020-05-25  0:39 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-05-25  0:39 UTC (permalink / raw)
  To: test-report; +Cc: Dmitry Kozlyuk

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/70566

_coding style issues_


WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#235: FILE: lib/librte_eal/windows/include/sys/queue.h:103:
+#define	TRACEBUF	struct qm_trace trace;

ERROR:SPACING: space prohibited before that ',' (ctx:WxE)
#236: FILE: lib/librte_eal/windows/include/sys/queue.h:104:
+#define	TRACEBUF_INITIALIZER	{ __LINE__, 0, __FILE__, NULL } ,
        	                    	                                ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#236: FILE: lib/librte_eal/windows/include/sys/queue.h:104:
+#define	TRACEBUF_INITIALIZER	{ __LINE__, 0, __FILE__, NULL } ,

ERROR:SPACING: space required after that ';' (ctx:VxV)
#261: FILE: lib/librte_eal/windows/include/sys/queue.h:129:
+#define	TRASHIT(x)		do {(x) = (void *)-1;} while (0)
        	          		                    ^

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#261: FILE: lib/librte_eal/windows/include/sys/queue.h:129:
+#define	TRASHIT(x)		do {(x) = (void *)-1;} while (0)

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#317: FILE: lib/librte_eal/windows/include/sys/queue.h:186:
+	QUEUE_TYPEOF(type) *curelm = SLIST_FIRST(head1);		\
 	                   ^

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#319: FILE: lib/librte_eal/windows/include/sys/queue.h:188:
+		if ((SLIST_FIRST(head1) = SLIST_FIRST(head2)) != NULL)	\

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#358: FILE: lib/librte_eal/windows/include/sys/queue.h:227:
+#define	SLIST_INIT(head) do {						\
+	SLIST_FIRST((head)) = NULL;					\
+} while (0)

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#380: FILE: lib/librte_eal/windows/include/sys/queue.h:249:
+		QUEUE_TYPEOF(type) *curelm = SLIST_FIRST(head);		\
 		                   ^

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#388: FILE: lib/librte_eal/windows/include/sys/queue.h:257:
+#define SLIST_REMOVE_AFTER(elm, field) do {				\
+	SLIST_NEXT(elm, field) =					\
+	    SLIST_NEXT(SLIST_NEXT(elm, field), field);			\
+} while (0)

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#393: FILE: lib/librte_eal/windows/include/sys/queue.h:262:
+#define	SLIST_REMOVE_HEAD(head, field) do {				\
+	SLIST_FIRST((head)) = SLIST_NEXT(SLIST_FIRST((head)), field);	\
+} while (0)

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#404: FILE: lib/librte_eal/windows/include/sys/queue.h:273:
+	QUEUE_TYPEOF(type) *swap_first = SLIST_FIRST(head1);		\
 	                   ^

ERROR:SPACING: space required before the open parenthesis '('
#453: FILE: lib/librte_eal/windows/include/sys/queue.h:322:
+	for((var) = STAILQ_FIRST((head));				\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#478: FILE: lib/librte_eal/windows/include/sys/queue.h:347:
+	if ((STAILQ_NEXT((elm), field) = STAILQ_NEXT((tqelm), field)) == NULL)\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#484: FILE: lib/librte_eal/windows/include/sys/queue.h:353:
+	if ((STAILQ_NEXT((elm), field) = STAILQ_FIRST((head))) == NULL)	\

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#508: FILE: lib/librte_eal/windows/include/sys/queue.h:377:
+		QUEUE_TYPEOF(type) *curelm = STAILQ_FIRST(head);	\
 		                   ^

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#517: FILE: lib/librte_eal/windows/include/sys/queue.h:386:
+	if ((STAILQ_NEXT(elm, field) =					\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#523: FILE: lib/librte_eal/windows/include/sys/queue.h:392:
+	if ((STAILQ_FIRST((head)) =					\

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#529: FILE: lib/librte_eal/windows/include/sys/queue.h:398:
+	QUEUE_TYPEOF(type) *swap_first = STAILQ_FIRST(head1);		\
 	                   ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#530: FILE: lib/librte_eal/windows/include/sys/queue.h:399:
+	QUEUE_TYPEOF(type) **swap_last = (head1)->stqh_last;		\
 	                   ^

ERROR:CODE_INDENT: code indent should use tabs where possible
#598: FILE: lib/librte_eal/windows/include/sys/queue.h:467:
+^I     ^Ipanic("Bad link elm %p next->prev != elm", (elm));^I\$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#598: FILE: lib/librte_eal/windows/include/sys/queue.h:467:
+^I     ^Ipanic("Bad link elm %p next->prev != elm", (elm));^I\$

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#617: FILE: lib/librte_eal/windows/include/sys/queue.h:486:
+	QUEUE_TYPEOF(type) *curelm = LIST_FIRST(head1);			      \
 	                   ^

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#619: FILE: lib/librte_eal/windows/include/sys/queue.h:488:
+		if ((LIST_FIRST(head1) = LIST_FIRST(head2)) != NULL) {	      \

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#657: FILE: lib/librte_eal/windows/include/sys/queue.h:526:
+#define	LIST_INIT(head) do {						\
+	LIST_FIRST((head)) = NULL;					\
+} while (0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#663: FILE: lib/librte_eal/windows/include/sys/queue.h:532:
+	if ((LIST_NEXT((elm), field) = LIST_NEXT((listelm), field)) != NULL)\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#680: FILE: lib/librte_eal/windows/include/sys/queue.h:549:
+	if ((LIST_NEXT((elm), field) = LIST_FIRST((head))) != NULL)	\

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#699: FILE: lib/librte_eal/windows/include/sys/queue.h:568:
+^I^ILIST_NEXT((elm), field)->field.le_prev = ^I^I\$

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#707: FILE: lib/librte_eal/windows/include/sys/queue.h:576:
+	QUEUE_TYPEOF(type) *swap_tmp = LIST_FIRST(head1);		\
 	                   ^

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#710: FILE: lib/librte_eal/windows/include/sys/queue.h:579:
+	if ((swap_tmp = LIST_FIRST((head1))) != NULL)			\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#712: FILE: lib/librte_eal/windows/include/sys/queue.h:581:
+	if ((swap_tmp = LIST_FIRST((head2))) != NULL)			\

ERROR:CODE_INDENT: code indent should use tabs where possible
#744: FILE: lib/librte_eal/windows/include/sys/queue.h:643:
+^I    ^Ipanic("Bad tailq NEXT(%p->tqh_last) != NULL", (head)); ^I\$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#744: FILE: lib/librte_eal/windows/include/sys/queue.h:643:
+^I    ^Ipanic("Bad tailq NEXT(%p->tqh_last) != NULL", (head)); ^I\$

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#785: FILE: lib/librte_eal/windows/include/sys/queue.h:738:
+	if ((TAILQ_NEXT((elm), field) = TAILQ_NEXT((listelm), field)) != NULL)\

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#786: FILE: lib/librte_eal/windows/include/sys/queue.h:739:
+^I^ITAILQ_NEXT((elm), field)->field.tqe_prev = ^I^I\$

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#796: FILE: lib/librte_eal/windows/include/sys/queue.h:763:
+	if ((TAILQ_NEXT((elm), field) = TAILQ_FIRST((head))) != NULL)	\

WARNING:LONG_LINE: line over 90 characters
#806: FILE: lib/librte_eal/windows/include/sys/queue.h:795:
+    (TAILQ_EMPTY(head) ? NULL : __containerof((head)->tqh_last, QUEUE_TYPEOF(type), field.tqe_next))

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#806: FILE: lib/librte_eal/windows/include/sys/queue.h:795:
+    (TAILQ_EMPTY(head) ? NULL : __containerof((head)->tqh_last, QUEUE_TYPEOF(type), field.tqe_next))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#814: FILE: lib/librte_eal/windows/include/sys/queue.h:803:
+    ((elm)->field.tqe_prev == &(head)->tqh_first ? NULL :^I^I\$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#815: FILE: lib/librte_eal/windows/include/sys/queue.h:804:
+     __containerof((elm)->field.tqe_prev, QUEUE_TYPEOF(type), field.tqe_next))$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#824: FILE: lib/librte_eal/windows/include/sys/queue.h:812:
+^I^ITAILQ_NEXT((elm), field)->field.tqe_prev = ^I^I\$

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#834: FILE: lib/librte_eal/windows/include/sys/queue.h:825:
+	QUEUE_TYPEOF(type) *swap_first = (head1)->tqh_first;		\
 	                   ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#835: FILE: lib/librte_eal/windows/include/sys/queue.h:826:
+	QUEUE_TYPEOF(type) **swap_last = (head1)->tqh_last;		\
 	                   ^

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#842: FILE: lib/librte_eal/windows/include/sys/queue.h:831:
+	if ((swap_first = (head1)->tqh_first) != NULL)			\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#848: FILE: lib/librte_eal/windows/include/sys/queue.h:835:
+	if ((swap_first = (head2)->tqh_first) != NULL)			\

total: 30 errors, 15 warnings, 753 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-25  0:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200525003720.6410-9-dmitry.kozliuk@gmail.com>
2020-05-25  0:39 ` [dpdk-test-report] |WARNING| pw70566 [PATCH v5 08/11] eal/windows: replace sys/queue.h with a complete one from FreeBSD checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).