[dpdk-test-report] |WARNING| pw70621 [PATCH 16/37] net/dpaa: add VSP support in FMLIB

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw70621 [PATCH 16/37] net/dpaa: add VSP support in FMLIB
Date: Wed, 27 May 2020 15:30:22 +0200 (CEST)	[thread overview]
Message-ID: <20200527133022.0BF741DAD0@dpdk.org> (raw)
In-Reply-To: <20200527132326.1382-17-hemant.agrawal@nxp.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/70621

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <FM_PORT_VSPAlloc>
#111: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:22:
+uint32_t FM_PORT_VSPAlloc(t_Handle h_FmPort,

CHECK:CAMELCASE: Avoid CamelCase: <t_Handle>
#111: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:22:
+uint32_t FM_PORT_VSPAlloc(t_Handle h_FmPort,

CHECK:CAMELCASE: Avoid CamelCase: <h_FmPort>
#111: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:22:
+uint32_t FM_PORT_VSPAlloc(t_Handle h_FmPort,

CHECK:CAMELCASE: Avoid CamelCase: <t_FmPortVSPAllocParams>
#112: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:23:
+		t_FmPortVSPAllocParams *p_Params)

CHECK:CAMELCASE: Avoid CamelCase: <p_Params>
#112: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:23:
+		t_FmPortVSPAllocParams *p_Params)

CHECK:CAMELCASE: Avoid CamelCase: <t_Device>
#114: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:25:
+	t_Device *p_Dev = (t_Device *)h_FmPort;

CHECK:CAMELCASE: Avoid CamelCase: <p_Dev>
#114: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:25:
+	t_Device *p_Dev = (t_Device *)h_FmPort;

CHECK:CAMELCASE: Avoid CamelCase: <FM_VSP_Config>
#129: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:40:
+t_Handle FM_VSP_Config(t_FmVspParams *p_FmVspParams)

CHECK:CAMELCASE: Avoid CamelCase: <t_FmVspParams>
#129: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:40:
+t_Handle FM_VSP_Config(t_FmVspParams *p_FmVspParams)

CHECK:CAMELCASE: Avoid CamelCase: <p_FmVspParams>
#129: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:40:
+t_Handle FM_VSP_Config(t_FmVspParams *p_FmVspParams)

CHECK:CAMELCASE: Avoid CamelCase: <p_VspDev>
#132: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:43:
+	t_Device *p_VspDev = NULL;

CHECK:CAMELCASE: Avoid CamelCase: <h_Fm>
#135: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:46:
+	p_Dev = p_FmVspParams->h_Fm;

CHECK:CAMELCASE: Avoid CamelCase: <h_UserPriv>
#155: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:66:
+	p_VspDev->h_UserPriv = (t_Handle)p_Dev;

CHECK:CAMELCASE: Avoid CamelCase: <FM_VSP_Init>
#164: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:75:
+uint32_t FM_VSP_Init(t_Handle h_FmVsp)

CHECK:CAMELCASE: Avoid CamelCase: <h_FmVsp>
#164: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:75:
+uint32_t FM_VSP_Init(t_Handle h_FmVsp)

CHECK:CAMELCASE: Avoid CamelCase: <FM_VSP_Free>
#185: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:96:
+uint32_t FM_VSP_Free(t_Handle h_FmVsp)

CHECK:CAMELCASE: Avoid CamelCase: <FM_VSP_ConfigBufferPrefixContent>
#209: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:120:
+uint32_t FM_VSP_ConfigBufferPrefixContent(t_Handle h_FmVsp,

CHECK:CAMELCASE: Avoid CamelCase: <t_FmBufferPrefixContent>
#210: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:121:
+		t_FmBufferPrefixContent *p_FmBufferPrefixContent)

CHECK:CAMELCASE: Avoid CamelCase: <p_FmBufferPrefixContent>
#210: FILE: drivers/net/dpaa/fmlib/fm_vsp.c:121:
+		t_FmBufferPrefixContent *p_FmBufferPrefixContent)

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#247: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:9:
+/**
+ @File          fm_vsp_ext.h

CHECK:CAMELCASE: Avoid CamelCase: <t_FmExtPools>
#260: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:22:
+	t_FmExtPools	extBufPools;/**< Which external buffer pools are used

CHECK:CAMELCASE: Avoid CamelCase: <extBufPools>
#260: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:22:
+	t_FmExtPools	extBufPools;/**< Which external buffer pools are used

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#261: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:23:
+	t_FmExtPools	extBufPools;/**< Which external buffer pools are used
+			(up to FM_PORT_MAX_NUM_OF_EXT_POOLS), and their sizes.

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#262: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:24:
+			parameter associated with Rx / OP port */

CHECK:CAMELCASE: Avoid CamelCase: <liodnOffset>
#263: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:25:
+	uint16_t	liodnOffset;	/**< VSP's LIODN offset */

CHECK:CAMELCASE: Avoid CamelCase: <e_FmPortType>
#265: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:27:
+		e_FmPortType	portType; /**< Port type */

CHECK:CAMELCASE: Avoid CamelCase: <portType>
#265: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:27:
+		e_FmPortType	portType; /**< Port type */

CHECK:CAMELCASE: Avoid CamelCase: <portId>
#266: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:28:
+		uint8_t	portId;           /**< Port Id - relative to type */

CHECK:CAMELCASE: Avoid CamelCase: <portParams>
#267: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:29:
+	} portParams;

CHECK:CAMELCASE: Avoid CamelCase: <relativeProfileId>
#268: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:30:
+	uint8_t	relativeProfileId;  /**< VSP Id - relative to VSP's range

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#269: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:31:
+	uint8_t	relativeProfileId;  /**< VSP Id - relative to VSP's range
+				defined in relevant FM object */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#269: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:31:
+				defined in relevant FM object */

CHECK:CAMELCASE: Avoid CamelCase: <numOfProfiles>
#278: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:40:
+	uint8_t     numOfProfiles;

CHECK:CAMELCASE: Avoid CamelCase: <dfltRelativeId>
#280: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:42:
+	uint8_t     dfltRelativeId;

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#282: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:44:
+	/**< The default Virtual-Storage-Profile-id dedicated to Rx/OP port
+	The same default Virtual-Storage-Profile-id will be for coupled Tx port

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#283: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:45:
+	if relevant function called for Rx port */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#295: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:57:
+		/**< Number of bytes to be left at the beginning
+		of the external buffer; Note that the private-area will

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#296: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:58:
+		start from the base of the buffer address. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#299: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:61:
+			/**< TRUE to pass the parse result to/from the FM;
+			User may use FM_PORT_GetBufferPrsResult() in order to

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#300: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:62:
+			get the parser-result from a buffer. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#303: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:65:
+			/**< TRUE to pass the timeStamp to/from the FM
+			User may use FM_PORT_GetBufferTimeStamp() in order to

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#304: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:66:
+			get the parser-result from a buffer. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#307: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:69:
+			/**< TRUE to pass the KG hash result to/from the FM
+			User may use FM_PORT_GetBufferHashResult() in order to

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#308: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:70:
+			get the parser-result from a buffer. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#311: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:73:
+			/**< Add all other Internal-Context information:
+			AD, hash-result, key, etc. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#311: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:73:
+			AD, hash-result, key, etc. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#313: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:75:
+	uint16_t data_align; /**< 0 to use driver's default alignment [64],
+			other value for selecting a data alignment

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#315: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:77:
+			if write optimization is used, must be >= 16. */

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#330: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:92:
+uint32_t FM_PORT_VSPAlloc(

WARNING:LONG_LINE: line over 90 characters
#373: FILE: drivers/net/dpaa/fmlib/fm_vsp_ext.h:135:
+	_IOW(FM_IOC_TYPE_BASE, FM_IOC_NUM(12), ioc_compat_fm_buffer_prefix_content_params_t)

total: 0 errors, 20 warnings, 30 checks, 297 lines checked

          parent reply	other threads:[~2020-05-27 13:30 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20200527132326.1382-17-hemant.agrawal@nxp.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200527133022.0BF741DAD0@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).