From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: [dpdk-test-report] |WARNING| pw70648 [PATCH v2 3/5] bpf: add support for packet data load instructions
Date: Wed, 27 May 2020 16:18:01 +0200 (CEST) [thread overview]
Message-ID: <20200527141801.8F4771DAB7@dpdk.org> (raw)
In-Reply-To: <20200527141653.15576-4-konstantin.ananyev@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/70648
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#151: FILE: lib/librte_bpf/bpf_exec.c:81:
+#define BPF_LD_ABS(bpf, reg, ins, type, op) do { \
+ const type *p = bpf_ld_mbuf(bpf, reg, ins, (ins)->imm, sizeof(type)); \
+ if (p == NULL) \
+ return 0; \
+ reg[EBPF_REG_0] = op(p[0]); \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#158: FILE: lib/librte_bpf/bpf_exec.c:88:
+#define BPF_LD_IND(bpf, reg, ins, type, op) do { \
+ uint32_t ofs = reg[ins->src_reg] + (ins)->imm; \
+ const type *p = bpf_ld_mbuf(bpf, reg, ins, ofs, sizeof(type)); \
+ if (p == NULL) \
+ return 0; \
+ reg[EBPF_REG_0] = op(p[0]); \
+} while (0)
total: 0 errors, 2 warnings, 223 lines checked
parent reply other threads:[~2020-05-27 14:18 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200527141653.15576-4-konstantin.ananyev@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527141801.8F4771DAB7@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).