From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7BF57A04EF
	for <public@inbox.dpdk.org>; Tue,  2 Jun 2020 11:40:17 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 732971BF75;
	Tue,  2 Jun 2020 11:40:17 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id EE5A51BF98; Tue,  2 Jun 2020 11:40:15 +0200 (CEST)
In-Reply-To: <a604fc5f82757272eeb7141ca252b50f9bea359c.1591088325.git.shirik@mellanox.com>
References: <a604fc5f82757272eeb7141ca252b50f9bea359c.1591088325.git.shirik@mellanox.com>
To: test-report@dpdk.org
Cc: Shiri Kuzin <shirik@mellanox.com>
Message-Id: <20200602094015.EE5A51BF98@dpdk.org>
Date: Tue,  2 Jun 2020 11:40:15 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw70733 [RFC 2/3] net/mlx5: add
	default miss action to flow engine
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/70733

_coding style issues_


CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#177: FILE: drivers/net/mlx5/mlx5_flow.c:1259:
+{
+

WARNING:TYPO_SPELLING: 'Deafult' may be misspelled - perhaps 'Default'?
#194: FILE: drivers/net/mlx5/mlx5_flow.c:5015:
+ * Deafult miss flow

ERROR:TRAILING_WHITESPACE: trailing whitespace
#230: FILE: drivers/net/mlx5/mlx5_flow.c:5051:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#233: FILE: drivers/net/mlx5/mlx5_flow.c:5054:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#326: FILE: drivers/net/mlx5/mlx5_flow_dv.c:2699:
+^I$

ERROR:SPACING: space required before the open brace '{'
#328: FILE: drivers/net/mlx5/mlx5_flow_dv.c:2701:
+	if (!cnt){

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16)
#331: FILE: drivers/net/mlx5/mlx5_flow_dv.c:2704:
+		if (sh->default_miss_action)
+		return rte_flow_error_set(error, ENOMEM,

ERROR:TRAILING_WHITESPACE: trailing whitespace
#351: FILE: drivers/net/mlx5/mlx5_flow_dv.c:5257:
+^I^I^Iret = $

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 24)
#367: FILE: drivers/net/mlx5/mlx5_flow_dv.c:8229:
+			if (flow_dv_default_miss_resource_register
[...]
+			return -rte_errno;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#371: FILE: drivers/net/mlx5/mlx5_flow_dv.c:8233:
+^I^I^Idev_flow->handle->fate_action = $

ERROR:SPACING: space required before the open brace '{'
#411: FILE: drivers/net/mlx5/mlx5_flow_dv.c:8811:
+	if (rte_atomic32_dec_and_test(&sh->default_miss_refcnt)){

total: 7 errors, 3 warnings, 1 checks, 271 lines checked