* [dpdk-test-report] |WARNING| pw71044 [PATCH v2 37/52] net/ice/base: fix for memory leak
[not found] <20200609120001.35110-38-qi.z.zhang@intel.com>
@ 2020-06-10 7:58 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-06-10 7:58 UTC (permalink / raw)
To: test-report; +Cc: Qi Zhang
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/71044
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#103: FILE: drivers/net/ice/base/ice_controlq.c:286:
+#define ICE_FREE_CQ_BUFS(hw, qi, ring) \
+do { \
+ /* free descriptors */ \
+ if ((qi)->ring.r.ring##_bi) { \
+ int i; \
+ \
+ for (i = 0; i < (qi)->num_##ring##_entries; i++) \
+ if ((qi)->ring.r.ring##_bi[i].pa) \
+ ice_free_dma_mem((hw), \
+ &(qi)->ring.r.ring##_bi[i]); \
+ } \
+ /* free the buffer info list */ \
+ if ((qi)->ring.cmd_buf) \
+ ice_free(hw, (qi)->ring.cmd_buf); \
+ /* free DMA head */ \
+ ice_free(hw, (qi)->ring.dma_head); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'qi' - possible side-effects?
#103: FILE: drivers/net/ice/base/ice_controlq.c:286:
+#define ICE_FREE_CQ_BUFS(hw, qi, ring) \
+do { \
+ /* free descriptors */ \
+ if ((qi)->ring.r.ring##_bi) { \
+ int i; \
+ \
+ for (i = 0; i < (qi)->num_##ring##_entries; i++) \
+ if ((qi)->ring.r.ring##_bi[i].pa) \
+ ice_free_dma_mem((hw), \
+ &(qi)->ring.r.ring##_bi[i]); \
+ } \
+ /* free the buffer info list */ \
+ if ((qi)->ring.cmd_buf) \
+ ice_free(hw, (qi)->ring.cmd_buf); \
+ /* free DMA head */ \
+ ice_free(hw, (qi)->ring.dma_head); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ring' - possible side-effects?
#103: FILE: drivers/net/ice/base/ice_controlq.c:286:
+#define ICE_FREE_CQ_BUFS(hw, qi, ring) \
+do { \
+ /* free descriptors */ \
+ if ((qi)->ring.r.ring##_bi) { \
+ int i; \
+ \
+ for (i = 0; i < (qi)->num_##ring##_entries; i++) \
+ if ((qi)->ring.r.ring##_bi[i].pa) \
+ ice_free_dma_mem((hw), \
+ &(qi)->ring.r.ring##_bi[i]); \
+ } \
+ /* free the buffer info list */ \
+ if ((qi)->ring.cmd_buf) \
+ ice_free(hw, (qi)->ring.cmd_buf); \
+ /* free DMA head */ \
+ ice_free(hw, (qi)->ring.dma_head); \
+} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ring' may be better as '(ring)' to avoid precedence issues
#103: FILE: drivers/net/ice/base/ice_controlq.c:286:
+#define ICE_FREE_CQ_BUFS(hw, qi, ring) \
+do { \
+ /* free descriptors */ \
+ if ((qi)->ring.r.ring##_bi) { \
+ int i; \
+ \
+ for (i = 0; i < (qi)->num_##ring##_entries; i++) \
+ if ((qi)->ring.r.ring##_bi[i].pa) \
+ ice_free_dma_mem((hw), \
+ &(qi)->ring.r.ring##_bi[i]); \
+ } \
+ /* free the buffer info list */ \
+ if ((qi)->ring.cmd_buf) \
+ ice_free(hw, (qi)->ring.cmd_buf); \
+ /* free DMA head */ \
+ ice_free(hw, (qi)->ring.dma_head); \
+} while (0)
total: 0 errors, 0 warnings, 4 checks, 77 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-10 7:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200609120001.35110-38-qi.z.zhang@intel.com>
2020-06-10 7:58 ` [dpdk-test-report] |WARNING| pw71044 [PATCH v2 37/52] net/ice/base: fix for memory leak checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).