From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 370AFA04FD
	for <public@inbox.dpdk.org>; Wed, 10 Jun 2020 09:59:19 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2D8542BF2;
	Wed, 10 Jun 2020 09:59:19 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 082B2F94; Wed, 10 Jun 2020 09:59:14 +0200 (CEST)
In-Reply-To: <20200609141713.11614-3-patrick.keroulas@radio-canada.ca>
References: <20200609141713.11614-3-patrick.keroulas@radio-canada.ca>
To: test-report@dpdk.org
Cc: Patrick Keroulas <patrick.keroulas@radio-canada.ca>
Message-Id: <20200610075914.082B2F94@dpdk.org>
Date: Wed, 10 Jun 2020 09:59:14 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw71063 [RFC] [PATCH v1 2/3] ethdev:
	add API to convert raw timestamps to nsec
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/71063

_coding style issues_


WARNING:TYPO_SPELLING: 'usefull' may be misspelled - perhaps 'useful'?
#80: 
counter in real time unit  which is usefull in a pdump application.

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#205: FILE: lib/librte_pdump/rte_pdump.c:106:
+	unsigned i;

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#207: FILE: lib/librte_pdump/rte_pdump.c:108:
+	for (i=0; i < nb_pkts; i++) {
 	      ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#208: FILE: lib/librte_pdump/rte_pdump.c:109:
+		if (pkts[i]->ol_flags & PKT_RX_TIMESTAMP) {
+			rte_eth_convert_ts_to_ns(port_id, &pkts[i]->timestamp);
+		}

total: 1 errors, 3 warnings, 99 lines checked