From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ophir Munk <ophirmu@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw71125 [PATCH v1 4/8] net/mlx5: split mlx5 ethdev under Linux directory
Date: Wed, 10 Jun 2020 11:34:21 +0200 (CEST) [thread overview]
Message-ID: <20200610093421.AF12C2E81@dpdk.org> (raw)
In-Reply-To: <20200610093233.23902-5-ophirmu@mellanox.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/71125
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_40000baseKR4_Full>
#202: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:47:
+#ifndef HAVE_SUPPORTED_40000baseKR4_Full
CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_40000baseKR4_Full>
#203: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:48:
+#define SUPPORTED_40000baseKR4_Full (1 << 23)
CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_40000baseCR4_Full>
#205: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:50:
+#ifndef HAVE_SUPPORTED_40000baseCR4_Full
CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_40000baseCR4_Full>
#206: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:51:
+#define SUPPORTED_40000baseCR4_Full (1 << 24)
CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_40000baseSR4_Full>
#208: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:53:
+#ifndef HAVE_SUPPORTED_40000baseSR4_Full
CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_40000baseSR4_Full>
#209: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:54:
+#define SUPPORTED_40000baseSR4_Full (1 << 25)
CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_40000baseLR4_Full>
#211: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:56:
+#ifndef HAVE_SUPPORTED_40000baseLR4_Full
CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_40000baseLR4_Full>
#212: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:57:
+#define SUPPORTED_40000baseLR4_Full (1 << 26)
CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_56000baseKR4_Full>
#214: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:59:
+#ifndef HAVE_SUPPORTED_56000baseKR4_Full
CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_56000baseKR4_Full>
#215: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:60:
+#define SUPPORTED_56000baseKR4_Full (1 << 27)
CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_56000baseCR4_Full>
#217: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:62:
+#ifndef HAVE_SUPPORTED_56000baseCR4_Full
CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_56000baseCR4_Full>
#218: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:63:
+#define SUPPORTED_56000baseCR4_Full (1 << 28)
CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_56000baseSR4_Full>
#220: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:65:
+#ifndef HAVE_SUPPORTED_56000baseSR4_Full
CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_56000baseSR4_Full>
#221: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:66:
+#define SUPPORTED_56000baseSR4_Full (1 << 29)
CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_56000baseLR4_Full>
#223: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:68:
+#ifndef HAVE_SUPPORTED_56000baseLR4_Full
CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_56000baseLR4_Full>
#224: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:69:
+#define SUPPORTED_56000baseLR4_Full (1 << 30)
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_1000baseT_Full_BIT>
#246: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:91:
+#define ETHTOOL_LINK_MODE_1000baseT_Full_BIT 5
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_Autoneg_BIT>
#247: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:92:
+#define ETHTOOL_LINK_MODE_Autoneg_BIT 6
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_1000baseKX_Full_BIT>
#248: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:93:
+#define ETHTOOL_LINK_MODE_1000baseKX_Full_BIT 17
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_10000baseKX4_Full_BIT>
#249: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:94:
+#define ETHTOOL_LINK_MODE_10000baseKX4_Full_BIT 18
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_10000baseKR_Full_BIT>
#250: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:95:
+#define ETHTOOL_LINK_MODE_10000baseKR_Full_BIT 19
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_10000baseR_FEC_BIT>
#251: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:96:
+#define ETHTOOL_LINK_MODE_10000baseR_FEC_BIT 20
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_20000baseMLD2_Full_BIT>
#252: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:97:
+#define ETHTOOL_LINK_MODE_20000baseMLD2_Full_BIT 21
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_20000baseKR2_Full_BIT>
#253: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:98:
+#define ETHTOOL_LINK_MODE_20000baseKR2_Full_BIT 22
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_40000baseKR4_Full_BIT>
#254: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:99:
+#define ETHTOOL_LINK_MODE_40000baseKR4_Full_BIT 23
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_40000baseCR4_Full_BIT>
#255: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:100:
+#define ETHTOOL_LINK_MODE_40000baseCR4_Full_BIT 24
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_40000baseSR4_Full_BIT>
#256: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:101:
+#define ETHTOOL_LINK_MODE_40000baseSR4_Full_BIT 25
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_40000baseLR4_Full_BIT>
#257: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:102:
+#define ETHTOOL_LINK_MODE_40000baseLR4_Full_BIT 26
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_56000baseKR4_Full_BIT>
#258: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:103:
+#define ETHTOOL_LINK_MODE_56000baseKR4_Full_BIT 27
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT>
#259: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:104:
+#define ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT 28
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT>
#260: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:105:
+#define ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT 29
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT>
#261: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:106:
+#define ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT 30
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_25000baseCR_Full_BIT>
#264: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:109:
+#define ETHTOOL_LINK_MODE_25000baseCR_Full_BIT 31
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_25000baseKR_Full_BIT>
#265: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:110:
+#define ETHTOOL_LINK_MODE_25000baseKR_Full_BIT 32
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_25000baseSR_Full_BIT>
#266: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:111:
+#define ETHTOOL_LINK_MODE_25000baseSR_Full_BIT 33
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT>
#269: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:114:
+#define ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT 34
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT>
#270: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:115:
+#define ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT 35
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT>
#273: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:118:
+#define ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT 36
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT>
#274: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:119:
+#define ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT 37
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT>
#275: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:120:
+#define ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT 38
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT>
#276: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:121:
+#define ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT 39
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_200000baseKR4_Full_BIT>
#279: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:124:
+#define ETHTOOL_LINK_MODE_200000baseKR4_Full_BIT 62
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_200000baseSR4_Full_BIT>
#280: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:125:
+#define ETHTOOL_LINK_MODE_200000baseSR4_Full_BIT 63
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_200000baseLR4_ER4_FR4_Full_BIT>
#281: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:126:
+#define ETHTOOL_LINK_MODE_200000baseLR4_ER4_FR4_Full_BIT 0 /* 64 - 64 */
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_200000baseDR4_Full_BIT>
#282: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:127:
+#define ETHTOOL_LINK_MODE_200000baseDR4_Full_BIT 1 /* 65 - 64 */
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT>
#283: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:128:
+#define ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT 2 /* 66 - 64 */
CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Autoneg>
#648: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:493:
+ if (edata.supported & SUPPORTED_Autoneg)
CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_1000baseT_Full>
#650: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:495:
+ if (edata.supported & (SUPPORTED_1000baseT_Full |
CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_1000baseKX_Full>
#651: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:496:
+ SUPPORTED_1000baseKX_Full))
CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_10000baseKR_Full>
#653: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:498:
+ if (edata.supported & SUPPORTED_10000baseKR_Full)
CHECK:CAMELCASE: Avoid CamelCase: <SCNx64>
#1269: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1114:
+ fscanf(file, "%" SCNx64 "%c", &data.switch_id, &c) == 2 &&
total: 0 errors, 0 warnings, 51 checks, 2646 lines checked
parent reply other threads:[~2020-06-10 9:34 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200610093233.23902-5-ophirmu@mellanox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610093421.AF12C2E81@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ophirmu@mellanox.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).