automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Somnath Kotur <somnath.kotur@broadcom.com>
Subject: [dpdk-test-report] |WARNING| pw71401 [PATCH 09/50] net/bnxt: add support for Exact Match
Date: Fri, 12 Jun 2020 15:39:19 +0200 (CEST)	[thread overview]
Message-ID: <20200612133919.993101BF53@dpdk.org> (raw)
In-Reply-To: <20200612132934.16488-10-somnath.kotur@broadcom.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/71401

_coding style issues_


WARNING:TYPO_SPELLING: 'becuase' may be misspelled - perhaps 'because'?
#2312: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:16079:
+	/* Module is powered down becuase of over current fault. */

WARNING:TYPO_SPELLING: 'untill' may be misspelled - perhaps 'until'?
#2370: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:20981:
+	 * A 0xFFFF will hold the bus untill this bus is released.

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#4066: FILE: drivers/net/bnxt/tf_core/tf_core.c:414:
+	tbl_scope_cb = tbl_scope_cb_find(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#4098: FILE: drivers/net/bnxt/tf_core/tf_core.c:449:
+	tbl_scope_cb = tbl_scope_cb_find(

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#4878: FILE: drivers/net/bnxt/tf_core/tf_ext_flow_handle.h:93:
+#define TF_GET_NUM_KEY_ENTRIES_FROM_FLOW_HANDLE(flow_handle,		\
+					  num_key_entries)		\
+do {									\
+	num_key_entries =						\
+		(((flow_handle) & TF_NUM_KEY_ENTRIES_FLOW_HANDLE_MASK) >> \
+		     TF_NUM_KEY_ENTRIES_FLOW_HANDLE_SFT);		\
+} while (0)

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#4886: FILE: drivers/net/bnxt/tf_core/tf_ext_flow_handle.h:101:
+#define TF_GET_ENTRY_NUM_FROM_FLOW_HANDLE(flow_handle,		\
+					  entry_num)		\
+do {									\
+	entry_num =						\
+		(((flow_handle) & TF_ENTRY_NUM_FLOW_HANDLE_MASK) >> \
+		     TF_ENTRY_NUM_FLOW_HANDLE_SFT);		\
+} while (0)

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#5094: FILE: drivers/net/bnxt/tf_core/tf_tbl.c:731:
+	tbl_scope_cb->em_ctx_info[TF_DIR_RX].em_tables[RECORD_TABLE].num_entries
+		= parms->rx_num_flows_in_k * TF_KILOBYTE;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#5096: FILE: drivers/net/bnxt/tf_core/tf_tbl.c:733:
+	tbl_scope_cb->em_ctx_info[TF_DIR_RX].em_tables[RECORD_TABLE].entry_size
+		= parms->rx_max_action_entry_sz_in_bits / 8;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#5101: FILE: drivers/net/bnxt/tf_core/tf_tbl.c:736:
+	tbl_scope_cb->em_ctx_info[TF_DIR_RX].em_tables[EFC_TABLE].num_entries
+		= 0;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#5114: FILE: drivers/net/bnxt/tf_core/tf_tbl.c:750:
+	tbl_scope_cb->em_ctx_info[TF_DIR_TX].em_tables[RECORD_TABLE].num_entries
+		= parms->tx_num_flows_in_k * TF_KILOBYTE;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#5116: FILE: drivers/net/bnxt/tf_core/tf_tbl.c:752:
+	tbl_scope_cb->em_ctx_info[TF_DIR_TX].em_tables[RECORD_TABLE].entry_size
+		= parms->tx_max_action_entry_sz_in_bits / 8;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#5121: FILE: drivers/net/bnxt/tf_core/tf_tbl.c:755:
+	tbl_scope_cb->em_ctx_info[TF_DIR_TX].em_tables[EFC_TABLE].num_entries
+		= 0;

total: 0 errors, 4 warnings, 8 checks, 5239 lines checked

           reply	other threads:[~2020-06-12 13:39 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20200612132934.16488-10-somnath.kotur@broadcom.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200612133919.993101BF53@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=somnath.kotur@broadcom.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).