* [dpdk-test-report] |WARNING| pw71404 [PATCH 12/50] net/bnxt: support bulk table get and mirror
[not found] <20200612132934.16488-13-somnath.kotur@broadcom.com>
@ 2020-06-12 13:41 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-06-12 13:41 UTC (permalink / raw)
To: test-report; +Cc: Somnath Kotur
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/71404
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects?
#163: FILE: drivers/net/bnxt/tf_core/tf_common.h:10:
+#define TF_CHECK_PARMS_SESSION(tfp, parms) do { \
+ if ((parms) == NULL || (tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "%s: session error
", \
+ tf_dir_2_str((parms)->dir)); \
+ return -EINVAL; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'parms' - possible side-effects?
#163: FILE: drivers/net/bnxt/tf_core/tf_common.h:10:
+#define TF_CHECK_PARMS_SESSION(tfp, parms) do { \
+ if ((parms) == NULL || (tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "%s: session error
", \
+ tf_dir_2_str((parms)->dir)); \
+ return -EINVAL; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#163: FILE: drivers/net/bnxt/tf_core/tf_common.h:10:
+#define TF_CHECK_PARMS_SESSION(tfp, parms) do { \
+ if ((parms) == NULL || (tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "%s: session error
", \
+ tf_dir_2_str((parms)->dir)); \
+ return -EINVAL; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects?
#176: FILE: drivers/net/bnxt/tf_core/tf_common.h:23:
+#define TF_CHECK_PARMS_SESSION_NO_DIR(tfp, parms) do { \
+ if ((parms) == NULL || (tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "Session error
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#176: FILE: drivers/net/bnxt/tf_core/tf_common.h:23:
+#define TF_CHECK_PARMS_SESSION_NO_DIR(tfp, parms) do { \
+ if ((parms) == NULL || (tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "Session error
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#188: FILE: drivers/net/bnxt/tf_core/tf_common.h:35:
+#define TF_CHECK_PARMS(tfp, parms) do { \
+ if ((parms) == NULL || (tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects?
#195: FILE: drivers/net/bnxt/tf_core/tf_common.h:42:
+#define TF_CHECK_TFP_SESSION(tfp) do { \
+ if ((tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "Session error
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#195: FILE: drivers/net/bnxt/tf_core/tf_common.h:42:
+#define TF_CHECK_TFP_SESSION(tfp) do { \
+ if ((tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "Session error
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects?
#376: FILE: drivers/net/bnxt/tf_core/tf_msg.c:1282:
+#define NUM_SLICES(tfp, bytes) \
+ (((bytes) + TF_BYTES_PER_SLICE(tfp) - 1) / TF_BYTES_PER_SLICE(tfp))
total: 0 errors, 4 warnings, 5 checks, 461 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-12 13:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200612132934.16488-13-somnath.kotur@broadcom.com>
2020-06-12 13:41 ` [dpdk-test-report] |WARNING| pw71404 [PATCH 12/50] net/bnxt: support bulk table get and mirror checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).