From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 840EFA00BE for ; Fri, 12 Jun 2020 15:41:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 198BE1BF58; Fri, 12 Jun 2020 15:41:08 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 408511BF59; Fri, 12 Jun 2020 15:41:06 +0200 (CEST) In-Reply-To: <20200612132934.16488-13-somnath.kotur@broadcom.com> References: <20200612132934.16488-13-somnath.kotur@broadcom.com> To: test-report@dpdk.org Cc: Somnath Kotur Message-Id: <20200612134106.408511BF59@dpdk.org> Date: Fri, 12 Jun 2020 15:41:06 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw71404 [PATCH 12/50] net/bnxt: support bulk table get and mirror X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/71404 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects? #163: FILE: drivers/net/bnxt/tf_core/tf_common.h:10: +#define TF_CHECK_PARMS_SESSION(tfp, parms) do { \ + if ((parms) == NULL || (tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "%s: session error ", \ + tf_dir_2_str((parms)->dir)); \ + return -EINVAL; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'parms' - possible side-effects? #163: FILE: drivers/net/bnxt/tf_core/tf_common.h:10: +#define TF_CHECK_PARMS_SESSION(tfp, parms) do { \ + if ((parms) == NULL || (tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "%s: session error ", \ + tf_dir_2_str((parms)->dir)); \ + return -EINVAL; \ + } \ + } while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #163: FILE: drivers/net/bnxt/tf_core/tf_common.h:10: +#define TF_CHECK_PARMS_SESSION(tfp, parms) do { \ + if ((parms) == NULL || (tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "%s: session error ", \ + tf_dir_2_str((parms)->dir)); \ + return -EINVAL; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects? #176: FILE: drivers/net/bnxt/tf_core/tf_common.h:23: +#define TF_CHECK_PARMS_SESSION_NO_DIR(tfp, parms) do { \ + if ((parms) == NULL || (tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "Session error "); \ + return -EINVAL; \ + } \ + } while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #176: FILE: drivers/net/bnxt/tf_core/tf_common.h:23: +#define TF_CHECK_PARMS_SESSION_NO_DIR(tfp, parms) do { \ + if ((parms) == NULL || (tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "Session error "); \ + return -EINVAL; \ + } \ + } while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #188: FILE: drivers/net/bnxt/tf_core/tf_common.h:35: +#define TF_CHECK_PARMS(tfp, parms) do { \ + if ((parms) == NULL || (tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects? #195: FILE: drivers/net/bnxt/tf_core/tf_common.h:42: +#define TF_CHECK_TFP_SESSION(tfp) do { \ + if ((tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "Session error "); \ + return -EINVAL; \ + } \ + } while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #195: FILE: drivers/net/bnxt/tf_core/tf_common.h:42: +#define TF_CHECK_TFP_SESSION(tfp) do { \ + if ((tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "Session error "); \ + return -EINVAL; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects? #376: FILE: drivers/net/bnxt/tf_core/tf_msg.c:1282: +#define NUM_SLICES(tfp, bytes) \ + (((bytes) + TF_BYTES_PER_SLICE(tfp) - 1) / TF_BYTES_PER_SLICE(tfp)) total: 0 errors, 4 warnings, 5 checks, 461 lines checked