From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Somnath Kotur <somnath.kotur@broadcom.com>
Subject: [dpdk-test-report] |WARNING| pw71405 [PATCH 13/50] net/bnxt: update multi device design support
Date: Fri, 12 Jun 2020 15:41:09 +0200 (CEST) [thread overview]
Message-ID: <20200612134109.C02641BF7A@dpdk.org> (raw)
In-Reply-To: <20200612132934.16488-14-somnath.kotur@broadcom.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/71405
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#494: FILE: drivers/net/bnxt/tf_core/tf_common.h:55:
+#define TF_CHECK_PARMS1(parms) do { \
+ if ((parms) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#501: FILE: drivers/net/bnxt/tf_core/tf_common.h:62:
+#define TF_CHECK_PARMS2(parms1, parms2) do { \
+ if ((parms1) == NULL || (parms2) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#508: FILE: drivers/net/bnxt/tf_core/tf_common.h:69:
+#define TF_CHECK_PARMS3(parms1, parms2, parms3) do { \
+ if ((parms1) == NULL || \
+ (parms2) == NULL || \
+ (parms3) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#2983: FILE: drivers/net/bnxt/tf_core/tf_session.c:132:
+#if 0
total: 0 errors, 4 warnings, 0 checks, 3433 lines checked
parent reply other threads:[~2020-06-12 13:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200612132934.16488-14-somnath.kotur@broadcom.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612134109.C02641BF7A@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=somnath.kotur@broadcom.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).