From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Somnath Kotur <somnath.kotur@broadcom.com>
Subject: [dpdk-test-report] |WARNING| pw71407 [PATCH 15/50] net/bnxt: add HCAPI interface support
Date: Fri, 12 Jun 2020 15:42:54 +0200 (CEST) [thread overview]
Message-ID: <20200612134254.4EAAD1BFA9@dpdk.org> (raw)
In-Reply-To: <20200612132934.16488-16-somnath.kotur@broadcom.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/71407
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#273: FILE: drivers/net/bnxt/hcapi/hcapi_cfa.h:173:
+ uint32_t dummy_data;$
WARNING:TABSTOP: Statements should start on a tabstop
#282: FILE: drivers/net/bnxt/hcapi/hcapi_cfa.h:182:
+ struct hcapi_cfa_layout_tbl layouts;
WARNING:TABSTOP: Statements should start on a tabstop
#283: FILE: drivers/net/bnxt/hcapi/hcapi_cfa.h:183:
+ struct hcapi_cfa_devops *devops;
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#289: FILE: drivers/net/bnxt/hcapi/hcapi_cfa.h:189:
+int hcapi_cfa_key_compile_layout(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#293: FILE: drivers/net/bnxt/hcapi/hcapi_cfa.h:193:
+int hcapi_cfa_action_compile_layout(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#296: FILE: drivers/net/bnxt/hcapi/hcapi_cfa.h:196:
+int hcapi_cfa_action_init_obj(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#299: FILE: drivers/net/bnxt/hcapi/hcapi_cfa.h:199:
+int hcapi_cfa_action_compute_ptr(
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#478: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_defs.h:2:
+/*
+ * Copyright(c) Broadcom Limited.
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#501: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_defs.h:25:
+#define __CFA_ALIGN_MASK(x, mask) (((x) + (mask)) & ~(mask))
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#502: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_defs.h:26:
+#define CFA_ALIGN(x, a) __CFA_ALIGN_MASK(x, (a)-1)
^
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#551: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_defs.h:75:
+ HCAPI_CFA_HWOPS_ADD, /**< For operations which require more then simple
+ * writes to HW, this operation is used. The
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#559: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_defs.h:83:
+ HCAPI_CFA_HWOPS_DEL, /**< This issues operations to clear the hardware.
+ * This operation is used in conjunction
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#809: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_defs.h:333:
+ * in bytes. */
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1071: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_defs.h:595:
+int hcapi_cfa_init_key_layout_contents(
WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#1166: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_p4.c:15:
+#if 0
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#1169: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_p4.c:18:
+int hcapi_cfa_key_hw_op(struct hcapi_cfa_hwop *op,
WARNING:INLINE: plain inline is preferred over __inline
#1181: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_p4.c:30:
+static __inline uint32_t SWAP_WORDS32(uint32_t val32)
CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#1192: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_p4.c:41:
+ if (hcapi_cfa_lkup_init == true)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crc' - possible side-effects?
#1212: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_p4.c:61:
+#define ucrc32(ch, crc) (crc32tbl[((crc) ^ (ch)) & 0xff] ^ ((crc) >> 8))
WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#1378: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_p4.c:227:
+#if 0
CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#1400: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_p4.c:249:
+ if (hcapi_cfa_lkup_init == false)
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1542: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_p4.c:391:
+ case HCAPI_CFA_HWOPS_ADD: /**< For operations which require more then simple
+ * writes to HW, this operation is used. The
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1570: FILE: drivers/net/bnxt/hcapi/hcapi_cfa_p4.h:2:
+/*
+ * Copyright(c) Broadcom Limited.
WARNING:LONG_LINE: line over 90 characters
#2090: FILE: drivers/net/bnxt/tf_core/tf_em.c:387:
+ mask = tf_em_get_key_mask(tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY0_TABLE].num_entries);
total: 0 errors, 14 warnings, 10 checks, 2218 lines checked
Warning in /drivers/net/bnxt/hcapi/hcapi_cfa_p4.c:
Using compiler attribute directly
parent reply other threads:[~2020-06-12 13:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200612132934.16488-16-somnath.kotur@broadcom.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612134254.4EAAD1BFA9@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=somnath.kotur@broadcom.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).