Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/72877 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects? #170: FILE: drivers/net/bnxt/tf_core/tf_common.h:10: +#define TF_CHECK_PARMS_SESSION(tfp, parms) do { \ + if ((parms) == NULL || (tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "%s: session error ", \ + tf_dir_2_str((parms)->dir)); \ + return -EINVAL; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'parms' - possible side-effects? #170: FILE: drivers/net/bnxt/tf_core/tf_common.h:10: +#define TF_CHECK_PARMS_SESSION(tfp, parms) do { \ + if ((parms) == NULL || (tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "%s: session error ", \ + tf_dir_2_str((parms)->dir)); \ + return -EINVAL; \ + } \ + } while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #170: FILE: drivers/net/bnxt/tf_core/tf_common.h:10: +#define TF_CHECK_PARMS_SESSION(tfp, parms) do { \ + if ((parms) == NULL || (tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "%s: session error ", \ + tf_dir_2_str((parms)->dir)); \ + return -EINVAL; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects? #183: FILE: drivers/net/bnxt/tf_core/tf_common.h:23: +#define TF_CHECK_PARMS_SESSION_NO_DIR(tfp, parms) do { \ + if ((parms) == NULL || (tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "Session error "); \ + return -EINVAL; \ + } \ + } while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #183: FILE: drivers/net/bnxt/tf_core/tf_common.h:23: +#define TF_CHECK_PARMS_SESSION_NO_DIR(tfp, parms) do { \ + if ((parms) == NULL || (tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "Session error "); \ + return -EINVAL; \ + } \ + } while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #195: FILE: drivers/net/bnxt/tf_core/tf_common.h:35: +#define TF_CHECK_PARMS(tfp, parms) do { \ + if ((parms) == NULL || (tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects? #202: FILE: drivers/net/bnxt/tf_core/tf_common.h:42: +#define TF_CHECK_TFP_SESSION(tfp) do { \ + if ((tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "Session error "); \ + return -EINVAL; \ + } \ + } while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #202: FILE: drivers/net/bnxt/tf_core/tf_common.h:42: +#define TF_CHECK_TFP_SESSION(tfp) do { \ + if ((tfp) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + if ((tfp)->session == NULL || \ + (tfp)->session->core_data == NULL) { \ + TFP_DRV_LOG(ERR, "Session error "); \ + return -EINVAL; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects? #384: FILE: drivers/net/bnxt/tf_core/tf_msg.c:1282: +#define NUM_SLICES(tfp, bytes) \ + (((bytes) + TF_BYTES_PER_SLICE(tfp) - 1) / TF_BYTES_PER_SLICE(tfp)) total: 0 errors, 4 warnings, 5 checks, 461 lines checked