From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F879A00BE for ; Tue, 7 Jul 2020 23:18:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 485441DE49; Tue, 7 Jul 2020 23:18:32 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id E34511DE47; Tue, 7 Jul 2020 23:18:30 +0200 (CEST) In-Reply-To: <20200707211617.4408-4-rmody@marvell.com> References: <20200707211617.4408-4-rmody@marvell.com> To: test-report@dpdk.org Cc: Rasesh Mody Message-Id: <20200707211830.E34511DE47@dpdk.org> Date: Tue, 7 Jul 2020 23:18:30 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw73473 [PATCH v4 3/4] net/qede: add infrastructure for debug data collection X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/73473 _coding style issues_ WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'? #166: FILE: drivers/net/qede/qede_debug.c:11: +#include "base/ecore_hsi_common.h" WARNING:TYPO_SPELLING: '2ST' may be misspelled - perhaps '2nd'? #359: FILE: drivers/net/qede/qede_debug.c:204: + DBG_BUS_FRAME_MODE_2ST_2HW = 1, /* 2 Storm dwords, 2 HW dwords */ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'field' - possible side-effects? #494: FILE: drivers/net/qede/qede_debug.c:339: +#define FIELD_BIT_MASK(type, field) \ + (((1 << FIELD_BIT_SIZE(type, field)) - 1) << \ + FIELD_DWORD_SHIFT(type, field)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects? #498: FILE: drivers/net/qede/qede_debug.c:343: +#define SET_VAR_FIELD(var, type, field, val) \ + do { \ + var[FIELD_DWORD_OFFSET(type, field)] &= \ + (~FIELD_BIT_MASK(type, field)); \ + var[FIELD_DWORD_OFFSET(type, field)] |= \ + (val) << FIELD_DWORD_SHIFT(type, field); \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'field' - possible side-effects? #498: FILE: drivers/net/qede/qede_debug.c:343: +#define SET_VAR_FIELD(var, type, field, val) \ + do { \ + var[FIELD_DWORD_OFFSET(type, field)] &= \ + (~FIELD_BIT_MASK(type, field)); \ + var[FIELD_DWORD_OFFSET(type, field)] |= \ + (val) << FIELD_DWORD_SHIFT(type, field); \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'block' - possible side-effects? #518: FILE: drivers/net/qede/qede_debug.c:363: +#define NUM_DBG_LINES(block) \ + ((block)->num_of_dbg_bus_lines + NUM_EXTRA_DBG_LINES(block)) WARNING:TYPO_SPELLING: 'UNSTALL' may be misspelled - perhaps 'INSTALL'? #830: FILE: drivers/net/qede/qede_debug.c:675: + /* DBG_GRC_PARAM_UNSTALL */ WARNING:TYPO_SPELLING: 'Unstall' may be misspelled - perhaps 'Install'? #3697: FILE: drivers/net/qede/qede_debug.c:3542: + /* Unstall storms */ WARNING:TYPO_SPELLING: 'UNSTALL' may be misspelled - perhaps 'INSTALL'? #3698: FILE: drivers/net/qede/qede_debug.c:3543: + if (qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_UNSTALL)) WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'? #5612: FILE: drivers/net/qede/qede_debug.c:5457: +#define REG_FIFO_ELEMENT_MASTER_SHIFT 43 WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'? #5613: FILE: drivers/net/qede/qede_debug.c:5458: +#define REG_FIFO_ELEMENT_MASTER_MASK 0xf WARNING:TYPO_SPELLING: 'CANT' may be misspelled - perhaps 'CAN'T'? #5802: FILE: drivers/net/qede/qede_debug.c:5647: + /* DBG_STATUS_CANT_ADD_CONSTRAINT */ WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'? #5957: FILE: drivers/net/qede/qede_debug.c:5802: +/* Master type names array */ WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #5958: FILE: drivers/net/qede/qede_debug.c:5803: +static const char * const s_master_strs[] = { WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #6897: FILE: drivers/net/qede/qede_debug.c:6742: + "raw: 0x%016lx, address: 0x%07x, access: %-5s, pf: %2d, vf: %s, port: %d, privilege: %-3s, protection: %-12s, master: %-4s, error: %s ", WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #6913: FILE: drivers/net/qede/qede_debug.c:6758: + s_master_strs[GET_FIELD(elements[i].data, WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'? #6914: FILE: drivers/net/qede/qede_debug.c:6759: + REG_FIFO_ELEMENT_MASTER)], WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'? #7749: FILE: drivers/net/qede/qede_debug.c:7594: + /* Get buffer size from hsi, allocate accordingly, and perform the total: 0 errors, 14 warnings, 4 checks, 9028 lines checked