From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-test-report] |WARNING| pw74549 [PATCH 20.11 10/20] raw/ioat: create rawdev instances on idxd PCI probe
Date: Tue, 21 Jul 2020 11:56:22 +0200 (CEST) [thread overview]
Message-ID: <20200721095622.9E3FF1C0B5@dpdk.org> (raw)
In-Reply-To: <20200721095140.719297-11-bruce.richardson@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/74549
_coding style issues_
WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#141: FILE: drivers/raw/ioat/idxd_pci.c:65:
+ uint8_t nb_groups, nb_engines, nb_wqs;
WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#177: FILE: drivers/raw/ioat/idxd_pci.c:101:
+ nb_wqs = (uint8_t)(pci->regs->wqcap >> 16);
WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#182: FILE: drivers/raw/ioat/idxd_pci.c:106:
+ IOAT_PMD_DEBUG("nb_groups = %u, nb_engines = %u, nb_wqs = %u",
WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#183: FILE: drivers/raw/ioat/idxd_pci.c:107:
+ nb_groups, nb_engines, nb_wqs);
WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#190: FILE: drivers/raw/ioat/idxd_pci.c:114:
+ for (i = 0; i < nb_wqs; i++)
WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#207: FILE: drivers/raw/ioat/idxd_pci.c:131:
+ wq_size = total_wq_size / nb_wqs;
WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#210: FILE: drivers/raw/ioat/idxd_pci.c:134:
+ for (i = 0; i < nb_wqs; i++) {
WARNING:LONG_LINE_COMMENT: line over 100 characters
#217: FILE: drivers/raw/ioat/idxd_pci.c:141:
+ pci->wq_regs[i].wqcfg[2] = 0x11; /* TODO: use defines - dedicated mode, priority 1 */
WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#241: FILE: drivers/raw/ioat/idxd_pci.c:165:
+ return nb_wqs;
WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#253: FILE: drivers/raw/ioat/idxd_pci.c:176:
+ uint8_t nb_wqs;
WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#267: FILE: drivers/raw/ioat/idxd_pci.c:189:
+ nb_wqs = (uint8_t)ret;
WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#270: FILE: drivers/raw/ioat/idxd_pci.c:192:
+ for (qid = 0; qid < nb_wqs; qid++) {
ERROR:SPACING: space required before the open brace '{'
#282: FILE: drivers/raw/ioat/idxd_pci.c:204:
+ if (ret != 0){
ERROR:POINTER_LOCATION: "foo version bar" should be "foo version bar"
#518: FILE: drivers/raw/ioat/ioat_spec.h:289:
+ uint32_t version __rte_cache_aligned; /* offset 0x00 */
ERROR:POINTER_LOCATION: "foo gencap bar" should be "foo gencap bar"
#519: FILE: drivers/raw/ioat/ioat_spec.h:290:
+ uint64_t gencap __rte_aligned(0x10); /* offset 0x10 */
ERROR:POINTER_LOCATION: "foo wqcap bar" should be "foo wqcap bar"
#520: FILE: drivers/raw/ioat/ioat_spec.h:291:
+ uint64_t wqcap __rte_aligned(0x10); /* offset 0x20 */
ERROR:POINTER_LOCATION: "foo grpcap bar" should be "foo grpcap bar"
#521: FILE: drivers/raw/ioat/ioat_spec.h:292:
+ uint64_t grpcap __rte_aligned(0x10); /* offset 0x30 */
ERROR:POINTER_LOCATION: "foo engcap bar" should be "foo engcap bar"
#522: FILE: drivers/raw/ioat/ioat_spec.h:293:
+ uint64_t engcap __rte_aligned(0x08); /* offset 0x38 */
ERROR:POINTER_LOCATION: "foo opcap bar" should be "foo opcap bar"
#523: FILE: drivers/raw/ioat/ioat_spec.h:294:
+ uint64_t opcap __rte_aligned(0x10); /* offset 0x40 */
ERROR:POINTER_LOCATION: "foo gencfg bar" should be "foo gencfg bar"
#525: FILE: drivers/raw/ioat/ioat_spec.h:296:
+ uint32_t gencfg __rte_aligned(0x20); /* offset 0x80 */
ERROR:POINTER_LOCATION: "foo genctrl bar" should be "foo genctrl bar"
#526: FILE: drivers/raw/ioat/ioat_spec.h:297:
+ uint32_t genctrl __rte_aligned(0x08); /* offset 0x88 */
ERROR:POINTER_LOCATION: "foo gensts bar" should be "foo gensts bar"
#527: FILE: drivers/raw/ioat/ioat_spec.h:298:
+ uint32_t gensts __rte_aligned(0x10); /* offset 0x90 */
ERROR:POINTER_LOCATION: "foo intcause bar" should be "foo intcause bar"
#528: FILE: drivers/raw/ioat/ioat_spec.h:299:
+ uint32_t intcause __rte_aligned(0x08); /* offset 0x98 */
ERROR:POINTER_LOCATION: "foo cmd bar" should be "foo cmd bar"
#529: FILE: drivers/raw/ioat/ioat_spec.h:300:
+ uint32_t cmd __rte_aligned(0x10); /* offset 0xA0 */
ERROR:POINTER_LOCATION: "foostatus bar" should be "foo status bar"
#530: FILE: drivers/raw/ioat/ioat_spec.h:301:
+ uint32_t cmdstatus __rte_aligned(0x08); /* offset 0xA8 */
total: 13 errors, 12 warnings, 503 lines checked
parent reply other threads:[~2020-07-21 9:56 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200721095140.719297-11-bruce.richardson@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721095622.9E3FF1C0B5@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=bruce.richardson@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).