From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw75431 [PATCH v4 1/8] net/dpaa: add support for fmlib in dpdk
Date: Tue, 11 Aug 2020 14:38:03 +0200 (CEST) [thread overview]
Message-ID: <20200811123803.C18871B203@dpdk.org> (raw)
In-Reply-To: <20200811123001.30045-1-hemant.agrawal@nxp.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/75431
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <manipExtraSpace>
#503: FILE: drivers/net/dpaa/fmlib/fm_ext.h:324:
+ uint8_t manipExtraSpace;
CHECK:CAMELCASE: Avoid CamelCase: <numOfBackupPools>
#537: FILE: drivers/net/dpaa/fmlib/fm_ext.h:358:
+ uint8_t numOfBackupPools;
CHECK:CAMELCASE: Avoid CamelCase: <poolsGrpModeEnable>
#554: FILE: drivers/net/dpaa/fmlib/fm_ext.h:375:
+ bool poolsGrpModeEnable;
CHECK:CAMELCASE: Avoid CamelCase: <numOfPools>
#558: FILE: drivers/net/dpaa/fmlib/fm_ext.h:379:
+ uint8_t numOfPools;
CHECK:CAMELCASE: Avoid CamelCase: <poolsToConsider>
#562: FILE: drivers/net/dpaa/fmlib/fm_ext.h:383:
+ bool poolsToConsider[BM_MAX_NUM_OF_POOLS];
CHECK:CAMELCASE: Avoid CamelCase: <singlePoolModeEnable>
#566: FILE: drivers/net/dpaa/fmlib/fm_ext.h:387:
+ bool singlePoolModeEnable;
CHECK:CAMELCASE: Avoid CamelCase: <poolsToConsiderForSingleMode>
#570: FILE: drivers/net/dpaa/fmlib/fm_ext.h:391:
+ bool poolsToConsiderForSingleMode[BM_MAX_NUM_OF_POOLS];
CHECK:CAMELCASE: Avoid CamelCase: <pfcPrioritiesEn>
#575: FILE: drivers/net/dpaa/fmlib/fm_ext.h:396:
+ bool pfcPrioritiesEn[FM_MAX_PFC_PRIO];
CHECK:CAMELCASE: Avoid CamelCase: <relativePortId>
#617: FILE: drivers/net/dpaa/fmlib/fm_ext.h:438:
+ uint8_t relativePortId; /**< Type relative port id */
CHECK:CAMELCASE: Avoid CamelCase: <numOfPorts>
#629: FILE: drivers/net/dpaa/fmlib/fm_ext.h:450:
+ uint8_t numOfPorts;
CHECK:CAMELCASE: Avoid CamelCase: <majorRev>
#663: FILE: drivers/net/dpaa/fmlib/fm_ext.h:484:
+ uint8_t majorRev; /**< Major revision */
CHECK:CAMELCASE: Avoid CamelCase: <minorRev>
#664: FILE: drivers/net/dpaa/fmlib/fm_ext.h:485:
+ uint8_t minorRev; /**< Minor revision */
CHECK:CAMELCASE: Avoid CamelCase: <packageRev>
#671: FILE: drivers/net/dpaa/fmlib/fm_ext.h:492:
+ uint16_t packageRev; /**< Package revision */
CHECK:CAMELCASE: Avoid CamelCase: <percentCnt>
#680: FILE: drivers/net/dpaa/fmlib/fm_ext.h:501:
+ uint8_t percentCnt[2]; /**< Percentage value */
CHECK:CAMELCASE: Avoid CamelCase: <FM_SetPortsBandwidth>
#697: FILE: drivers/net/dpaa/fmlib/fm_ext.h:518:
+uint32_t FM_SetPortsBandwidth(t_handle h_fm,
CHECK:CAMELCASE: Avoid CamelCase: <FM_GetRevision>
#713: FILE: drivers/net/dpaa/fmlib/fm_ext.h:534:
+uint32_t FM_GetRevision(t_handle h_fm,
CHECK:CAMELCASE: Avoid CamelCase: <FM_GetFmanCtrlCodeRevision>
#729: FILE: drivers/net/dpaa/fmlib/fm_ext.h:550:
+uint32_t FM_GetFmanCtrlCodeRevision(t_handle h_fm,
CHECK:CAMELCASE: Avoid CamelCase: <FM_GetCounter>
#747: FILE: drivers/net/dpaa/fmlib/fm_ext.h:568:
+uint32_t FM_GetCounter(t_handle h_fm, e_fm_counters counter);
CHECK:CAMELCASE: Avoid CamelCase: <FM_ModifyCounter>
#763: FILE: drivers/net/dpaa/fmlib/fm_ext.h:584:
+uint32_t FM_ModifyCounter(t_handle h_fm,
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#783: FILE: drivers/net/dpaa/fmlib/fm_ext.h:604:
+ * (i.e. guestId != NCSW_MASTER_ID).
CHECK:CAMELCASE: Avoid CamelCase: <FM_CtrlMonStart>
#785: FILE: drivers/net/dpaa/fmlib/fm_ext.h:606:
+uint32_t FM_CtrlMonStart(t_handle h_fm);
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#804: FILE: drivers/net/dpaa/fmlib/fm_ext.h:625:
+ * (i.e. guestId != NCSW_MASTER_ID).
CHECK:CAMELCASE: Avoid CamelCase: <FM_CtrlMonStop>
#806: FILE: drivers/net/dpaa/fmlib/fm_ext.h:627:
+uint32_t FM_CtrlMonStop(t_handle h_fm);
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#828: FILE: drivers/net/dpaa/fmlib/fm_ext.h:649:
+ * (i.e. guestId != NCSW_MASTER_ID).
CHECK:CAMELCASE: Avoid CamelCase: <FM_CtrlMonGetCounters>
#830: FILE: drivers/net/dpaa/fmlib/fm_ext.h:651:
+uint32_t FM_CtrlMonGetCounters(t_handle h_fm,
CHECK:CAMELCASE: Avoid CamelCase: <fmCtrlIndex>
#831: FILE: drivers/net/dpaa/fmlib/fm_ext.h:652:
+ uint8_t fmCtrlIndex, t_fm_ctrl_mon *p_mon);
CHECK:CAMELCASE: Avoid CamelCase: <FM_ForceIntr>
#846: FILE: drivers/net/dpaa/fmlib/fm_ext.h:667:
+uint32_t FM_ForceIntr(t_handle h_fm, e_fm_exceptions exception);
WARNING:TYPO_SPELLING: 'responsibilty' may be misspelled - perhaps 'responsibility'?
#1117: FILE: drivers/net/dpaa/fmlib/fm_ext.h:938:
+ * Note that it is user's responsibilty to call this routine only
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#1265: FILE: drivers/net/dpaa/fmlib/fm_lib.c:22:
+#define DEV_TO_ID(p) \
+ do { \
+ t_device *p_dev = (t_device *)p; \
+ p = UINT_TO_PTR(p_dev->id); \
+ } while (0)
WARNING:TYPO_SPELLING: 'Clasification' may be misspelled - perhaps 'Classification'?
#1700: FILE: drivers/net/dpaa/fmlib/fm_lib.c:457:
+ DPAA_PMD_WARN("Coarse Clasification not set !");
WARNING:TYPO_SPELLING: 'responsibilty' may be misspelled - perhaps 'responsibility'?
#2264: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:454:
+ * @Cautions Note that it is user's responsibilty to call this routine only
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#2907: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:1097:
+typedef enum ioc_fm_pcd_manip_dont_frag_action {
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#2923: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:1113:
+} ioc_fm_pcd_manip_dont_frag_action;
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#3272: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:1462:
+ * managed by master partition) May not be TRUE if
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#4134: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:2324:
+ ioc_fm_pcd_manip_dont_frag_action dont_frag_action;
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#4134: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:2324:
+ ioc_fm_pcd_manip_dont_frag_action dont_frag_action;
WARNING:TYPO_SPELLING: 'Dont' may be misspelled - perhaps 'Don't'?
#4135: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:2325:
+ /**< Dont Fragment Action - If an IP packet is larger than MTU
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#4632: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:2822:
+ bool dont_frag_overwrite;
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#4753: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:2943:
+ bool dont_parse_after_manip;
WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#6008: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4198:
+ * single partition environment, or it is the Master partition in
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6163: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4353:
+ * guestId != NCSW_MASTER_ID)
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6214: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4404:
+ * (i.e. guestId != NCSW_MASTER_ID)
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6232: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4422:
+ * (i.e. guestId != NCSW_MASTER_ID)
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6352: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4542:
+ * (i.e. guestId != NCSW_MASTER_ID)
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6370: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4560:
+ * (i.e. guestId != NCSW_MASTER_ID)
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6390: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4580:
+ * (i.e. guestId != NCSW_MASTER_ID)
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6409: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4599:
+ * guestId != NCSW_MASTER_ID)
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6427: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4617:
+ * (i.e. guestId != NCSW_MASTER_ID)
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6447: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4637:
+ * (i.e. guestId != NCSW_MASTER_ID)
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6465: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4655:
+ * (i.e. guestId != NCSW_MASTER_ID)
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6482: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4672:
+ * (i.e. guestId != NCSW_MASTER_ID)
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6497: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4687:
+ * NOTE: this routine may be called only for FM in master mode
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6498: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4688:
+ * (i.e. 'guestId'=NCSW_MASTER_ID) or in a case that the
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6513: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4703:
+ * NOTE: this routine may be called only for FM in master mode
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6514: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4704:
+ * (i.e. 'guestId'=NCSW_MASTER_ID) or in a case that the
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6529: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4719:
+ * NOTE: this routine may be called only for FM in master mode
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6530: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4720:
+ * (i.e. 'guestId'=NCSW_MASTER_ID) or in a case that the
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6545: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4735:
+ * NOTE: this routine may be called only for FM in master mode
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6546: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4736:
+ * (i.e. 'guestId'=NCSW_MASTER_ID) or in a case that the
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6561: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4751:
+ * NOTE: this routine may be called only for FM in master mode
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6562: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4752:
+ * (i.e. 'guestId'=NCSW_MASTER_ID) or in a case that the
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6577: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4767:
+ * NOTE: this routine may be called only for FM in master mode
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6578: FILE: drivers/net/dpaa/fmlib/fm_pcd_ext.h:4768:
+ * (i.e. 'guestId'=NCSW_MASTER_ID).
WARNING:TYPO_SPELLING: 'structre' may be misspelled - perhaps 'structure'?
#8946: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:828:
+ * structre
WARNING:TYPO_SPELLING: 'structre' may be misspelled - perhaps 'structure'?
#8969: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:851:
+ * structre
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#9218: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:1100:
+#define RETURN_ERROR(_level, _err, _vmsg) { return ERROR_CODE(_err); }
WARNING:TYPO_SPELLING: 'preforms' may be misspelled - perhaps 'performs'?
#9759: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:1641:
+ /**< QMI preforms a dequeue action for a single frame
WARNING:TYPO_SPELLING: 'preforms' may be misspelled - perhaps 'performs'?
#9763: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:1645:
+ /**< QMI preforms a dequeue action for 3 frames
WARNING:TYPO_SPELLING: 'preforms' may be misspelled - perhaps 'performs'?
#9767: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:1649:
+ /**< QMI preforms a dequeue action for 3 frames when
WARNING:TYPO_SPELLING: 'cheksum' may be misspelled - perhaps 'checksum'?
#10088: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:1970:
+ * @Function fm_port_config_cheksum_last_bytes_ignore
WARNING:TYPO_SPELLING: 'cheksum' may be misspelled - perhaps 'checksum'?
#10092: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:1974:
+ * default configuration [DEFAULT_PORT_cheksum_last_bytes_ignore]
WARNING:TYPO_SPELLING: 'cheksum' may be misspelled - perhaps 'checksum'?
#10097: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:1979:
+ * @Param[in] cheksum_last_bytes_ignore New value
WARNING:TYPO_SPELLING: 'cheksum' may be misspelled - perhaps 'checksum'?
#10104: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:1986:
+uint32_t fm_port_config_cheksum_last_bytes_ignore(t_handle h_fm_port,
WARNING:TYPO_SPELLING: 'cheksum' may be misspelled - perhaps 'checksum'?
#10105: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:1987:
+ uint8_t cheksum_last_bytes_ignore);
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#10419: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:2301:
+ * @Function fm_port_config_dont_release_tx_buf_to_bm
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#10439: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:2321:
+uint32_t fm_port_config_dont_release_tx_buf_to_bm(t_handle h_fm_port);
WARNING:TYPO_SPELLING: 'otherwize' may be misspelled - perhaps 'otherwise'?
#11520: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:3402:
+ * @Return TRUE if port is stalled, FALSE otherwize
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#11598: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:3480:
+ * (i.e. guestId != NCSW_MASTER_ID)
WARNING:TYPO_SPELLING: 'therefor' may be misspelled - perhaps 'therefore'?
#11798: FILE: drivers/net/dpaa/fmlib/fm_port_ext.h:3680:
+ * using the PCD functionalities, therefor port must be first
WARNING:TYPO_SPELLING: 'BEGGINING' may be misspelled - perhaps 'BEGINNING'?
#12307: FILE: drivers/net/dpaa/fmlib/net_ext.h:215:
+#define IOC_NET_HF_SCTP_CHUNK_DATA_BEGGINING \
WARNING:TYPO_SPELLING: 'THA' may be misspelled - perhaps 'THAN'?
#12393: FILE: drivers/net/dpaa/fmlib/net_ext.h:301:
+#define IOC_NET_HF_ARP_THA (IOC_NET_HF_ARP_HTYPE << 7)
total: 0 errors, 56 warnings, 25 checks, 12377 lines checked
parent reply other threads:[~2020-08-11 12:38 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200811123001.30045-1-hemant.agrawal@nxp.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811123803.C18871B203@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).