From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF5BBA04AF for ; Thu, 20 Aug 2020 12:44:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB6B11BEC3; Thu, 20 Aug 2020 12:44:49 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 779D9AAD5; Thu, 20 Aug 2020 12:44:48 +0200 (CEST) In-Reply-To: <20200820030231.1382984-1-jiawenwu@trustnetic.com> References: <20200820030231.1382984-1-jiawenwu@trustnetic.com> To: test-report@dpdk.org Cc: Jiawen Wu Message-Id: <20200820104448.779D9AAD5@dpdk.org> Date: Thu, 20 Aug 2020 12:44:48 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw75737 [PATCH] net: add a new network PMD named txgbe X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/75737 _coding style issues_ WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #58: This is a new network PMD named txgbe provides poll mode driver support for Wangxun 10Gb Ethernet NICs. WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #1272: FILE: drivers/net/txgbe/base/txgbe_dcb.h:35: + * If 8 traffic classes can be configured, the value is 0x80. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #1291: FILE: drivers/net/txgbe/base/txgbe_dcb.h:54: + * in 64B granularity.*/ WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1339: FILE: drivers/net/txgbe/base/txgbe_dcb.h:102: +s32 txgbe_dcb_check_config_cee(struct txgbe_dcb_config *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1342: FILE: drivers/net/txgbe/base/txgbe_dcb.h:105: +s32 txgbe_dcb_calculate_tc_credits(u8 *, u16 *, u16 *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1342: FILE: drivers/net/txgbe/base/txgbe_dcb.h:105: +s32 txgbe_dcb_calculate_tc_credits(u8 *, u16 *, u16 *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1342: FILE: drivers/net/txgbe/base/txgbe_dcb.h:105: +s32 txgbe_dcb_calculate_tc_credits(u8 *, u16 *, u16 *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #1342: FILE: drivers/net/txgbe/base/txgbe_dcb.h:105: +s32 txgbe_dcb_calculate_tc_credits(u8 *, u16 *, u16 *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1343: FILE: drivers/net/txgbe/base/txgbe_dcb.h:106: +s32 txgbe_dcb_calculate_tc_credits_cee(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1343: FILE: drivers/net/txgbe/base/txgbe_dcb.h:106: +s32 txgbe_dcb_calculate_tc_credits_cee(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #1343: FILE: drivers/net/txgbe/base/txgbe_dcb.h:106: +s32 txgbe_dcb_calculate_tc_credits_cee(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #1343: FILE: drivers/net/txgbe/base/txgbe_dcb.h:106: +s32 txgbe_dcb_calculate_tc_credits_cee(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1347: FILE: drivers/net/txgbe/base/txgbe_dcb.h:110: +s32 txgbe_dcb_config_pfc(struct txgbe_hw *, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #1347: FILE: drivers/net/txgbe/base/txgbe_dcb.h:110: +s32 txgbe_dcb_config_pfc(struct txgbe_hw *, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1347: FILE: drivers/net/txgbe/base/txgbe_dcb.h:110: +s32 txgbe_dcb_config_pfc(struct txgbe_hw *, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1348: FILE: drivers/net/txgbe/base/txgbe_dcb.h:111: +s32 txgbe_dcb_config_pfc_cee(struct txgbe_hw *, struct txgbe_dcb_config *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1348: FILE: drivers/net/txgbe/base/txgbe_dcb.h:111: +s32 txgbe_dcb_config_pfc_cee(struct txgbe_hw *, struct txgbe_dcb_config *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1351: FILE: drivers/net/txgbe/base/txgbe_dcb.h:114: +s32 txgbe_dcb_config_tc_stats(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1352: FILE: drivers/net/txgbe/base/txgbe_dcb.h:115: +s32 txgbe_dcb_get_tc_stats(struct txgbe_hw *, struct txgbe_hw_stats *, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw_stats *' should also have an identifier name #1352: FILE: drivers/net/txgbe/base/txgbe_dcb.h:115: +s32 txgbe_dcb_get_tc_stats(struct txgbe_hw *, struct txgbe_hw_stats *, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #1352: FILE: drivers/net/txgbe/base/txgbe_dcb.h:115: +s32 txgbe_dcb_get_tc_stats(struct txgbe_hw *, struct txgbe_hw_stats *, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1353: FILE: drivers/net/txgbe/base/txgbe_dcb.h:116: +s32 txgbe_dcb_get_pfc_stats(struct txgbe_hw *, struct txgbe_hw_stats *, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw_stats *' should also have an identifier name #1353: FILE: drivers/net/txgbe/base/txgbe_dcb.h:116: +s32 txgbe_dcb_get_pfc_stats(struct txgbe_hw *, struct txgbe_hw_stats *, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #1353: FILE: drivers/net/txgbe/base/txgbe_dcb.h:116: +s32 txgbe_dcb_get_pfc_stats(struct txgbe_hw *, struct txgbe_hw_stats *, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1356: FILE: drivers/net/txgbe/base/txgbe_dcb.h:119: +s32 txgbe_dcb_config_tx_desc_arbiter_cee(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1356: FILE: drivers/net/txgbe/base/txgbe_dcb.h:119: +s32 txgbe_dcb_config_tx_desc_arbiter_cee(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1358: FILE: drivers/net/txgbe/base/txgbe_dcb.h:121: +s32 txgbe_dcb_config_tx_data_arbiter_cee(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1358: FILE: drivers/net/txgbe/base/txgbe_dcb.h:121: +s32 txgbe_dcb_config_tx_data_arbiter_cee(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1360: FILE: drivers/net/txgbe/base/txgbe_dcb.h:123: +s32 txgbe_dcb_config_rx_arbiter_cee(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1360: FILE: drivers/net/txgbe/base/txgbe_dcb.h:123: +s32 txgbe_dcb_config_rx_arbiter_cee(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1364: FILE: drivers/net/txgbe/base/txgbe_dcb.h:127: +void txgbe_dcb_unpack_pfc_cee(struct txgbe_dcb_config *, u8 *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1364: FILE: drivers/net/txgbe/base/txgbe_dcb.h:127: +void txgbe_dcb_unpack_pfc_cee(struct txgbe_dcb_config *, u8 *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1364: FILE: drivers/net/txgbe/base/txgbe_dcb.h:127: +void txgbe_dcb_unpack_pfc_cee(struct txgbe_dcb_config *, u8 *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1365: FILE: drivers/net/txgbe/base/txgbe_dcb.h:128: +void txgbe_dcb_unpack_refill_cee(struct txgbe_dcb_config *, int, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #1365: FILE: drivers/net/txgbe/base/txgbe_dcb.h:128: +void txgbe_dcb_unpack_refill_cee(struct txgbe_dcb_config *, int, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1365: FILE: drivers/net/txgbe/base/txgbe_dcb.h:128: +void txgbe_dcb_unpack_refill_cee(struct txgbe_dcb_config *, int, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1366: FILE: drivers/net/txgbe/base/txgbe_dcb.h:129: +void txgbe_dcb_unpack_max_cee(struct txgbe_dcb_config *, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1366: FILE: drivers/net/txgbe/base/txgbe_dcb.h:129: +void txgbe_dcb_unpack_max_cee(struct txgbe_dcb_config *, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1367: FILE: drivers/net/txgbe/base/txgbe_dcb.h:130: +void txgbe_dcb_unpack_bwgid_cee(struct txgbe_dcb_config *, int, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #1367: FILE: drivers/net/txgbe/base/txgbe_dcb.h:130: +void txgbe_dcb_unpack_bwgid_cee(struct txgbe_dcb_config *, int, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1367: FILE: drivers/net/txgbe/base/txgbe_dcb.h:130: +void txgbe_dcb_unpack_bwgid_cee(struct txgbe_dcb_config *, int, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1368: FILE: drivers/net/txgbe/base/txgbe_dcb.h:131: +void txgbe_dcb_unpack_tsa_cee(struct txgbe_dcb_config *, int, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #1368: FILE: drivers/net/txgbe/base/txgbe_dcb.h:131: +void txgbe_dcb_unpack_tsa_cee(struct txgbe_dcb_config *, int, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1368: FILE: drivers/net/txgbe/base/txgbe_dcb.h:131: +void txgbe_dcb_unpack_tsa_cee(struct txgbe_dcb_config *, int, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1369: FILE: drivers/net/txgbe/base/txgbe_dcb.h:132: +void txgbe_dcb_unpack_map_cee(struct txgbe_dcb_config *, int, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #1369: FILE: drivers/net/txgbe/base/txgbe_dcb.h:132: +void txgbe_dcb_unpack_map_cee(struct txgbe_dcb_config *, int, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1369: FILE: drivers/net/txgbe/base/txgbe_dcb.h:132: +void txgbe_dcb_unpack_map_cee(struct txgbe_dcb_config *, int, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1370: FILE: drivers/net/txgbe/base/txgbe_dcb.h:133: +u8 txgbe_dcb_get_tc_from_up(struct txgbe_dcb_config *, int, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #1370: FILE: drivers/net/txgbe/base/txgbe_dcb.h:133: +u8 txgbe_dcb_get_tc_from_up(struct txgbe_dcb_config *, int, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #1370: FILE: drivers/net/txgbe/base/txgbe_dcb.h:133: +u8 txgbe_dcb_get_tc_from_up(struct txgbe_dcb_config *, int, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1373: FILE: drivers/net/txgbe/base/txgbe_dcb.h:136: +s32 txgbe_dcb_hw_config(struct txgbe_hw *, u16 *, u16 *, u8 *, u8 *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1373: FILE: drivers/net/txgbe/base/txgbe_dcb.h:136: +s32 txgbe_dcb_hw_config(struct txgbe_hw *, u16 *, u16 *, u8 *, u8 *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1373: FILE: drivers/net/txgbe/base/txgbe_dcb.h:136: +s32 txgbe_dcb_hw_config(struct txgbe_hw *, u16 *, u16 *, u8 *, u8 *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1373: FILE: drivers/net/txgbe/base/txgbe_dcb.h:136: +s32 txgbe_dcb_hw_config(struct txgbe_hw *, u16 *, u16 *, u8 *, u8 *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1373: FILE: drivers/net/txgbe/base/txgbe_dcb.h:136: +s32 txgbe_dcb_hw_config(struct txgbe_hw *, u16 *, u16 *, u8 *, u8 *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1373: FILE: drivers/net/txgbe/base/txgbe_dcb.h:136: +s32 txgbe_dcb_hw_config(struct txgbe_hw *, u16 *, u16 *, u8 *, u8 *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1374: FILE: drivers/net/txgbe/base/txgbe_dcb.h:137: +s32 txgbe_dcb_hw_config_cee(struct txgbe_hw *, struct txgbe_dcb_config *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1374: FILE: drivers/net/txgbe/base/txgbe_dcb.h:137: +s32 txgbe_dcb_hw_config_cee(struct txgbe_hw *, struct txgbe_dcb_config *); WARNING:BRACES: braces {} are not necessary for single statement blocks #1543: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.c:159: + for (i = 0; i < 128; i++) { + wr32(hw, TXGBE_QARBTXCRED(i), 0); + } CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'map[j] == i' #1667: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.c:283: + if ((map[j] == i) && (pfc_en & (1 << j))) { CHECK:BOOL_COMPARISON: Using comparison to false is error prone #1731: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.c:347: + if (!((tc_count == 8 && vt_mode == false) || tc_count == 4)) WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1829: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:9: +s32 txgbe_dcb_config_pfc_raptor(struct txgbe_hw *, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #1829: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:9: +s32 txgbe_dcb_config_pfc_raptor(struct txgbe_hw *, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1829: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:9: +s32 txgbe_dcb_config_pfc_raptor(struct txgbe_hw *, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1832: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:12: +s32 txgbe_dcb_config_tc_stats_raptor(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1832: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:12: +s32 txgbe_dcb_config_tc_stats_raptor(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1834: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:14: +s32 txgbe_dcb_get_tc_stats_raptor(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw_stats *' should also have an identifier name #1834: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:14: +s32 txgbe_dcb_get_tc_stats_raptor(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #1834: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:14: +s32 txgbe_dcb_get_tc_stats_raptor(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1836: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:16: +s32 txgbe_dcb_get_pfc_stats_raptor(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw_stats *' should also have an identifier name #1836: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:16: +s32 txgbe_dcb_get_pfc_stats_raptor(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #1836: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:16: +s32 txgbe_dcb_get_pfc_stats_raptor(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1840: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:20: +s32 txgbe_dcb_config_tx_desc_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1840: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:20: +s32 txgbe_dcb_config_tx_desc_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1840: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:20: +s32 txgbe_dcb_config_tx_desc_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1840: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:20: +s32 txgbe_dcb_config_tx_desc_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1840: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:20: +s32 txgbe_dcb_config_tx_desc_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1842: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:22: +s32 txgbe_dcb_config_tx_data_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1842: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:22: +s32 txgbe_dcb_config_tx_data_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1842: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:22: +s32 txgbe_dcb_config_tx_data_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1842: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:22: +s32 txgbe_dcb_config_tx_data_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1842: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:22: +s32 txgbe_dcb_config_tx_data_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1842: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:22: +s32 txgbe_dcb_config_tx_data_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1844: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:24: +s32 txgbe_dcb_config_rx_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, u8 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1844: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:24: +s32 txgbe_dcb_config_rx_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, u8 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1844: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:24: +s32 txgbe_dcb_config_rx_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, u8 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1844: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:24: +s32 txgbe_dcb_config_rx_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, u8 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1844: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:24: +s32 txgbe_dcb_config_rx_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, u8 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1844: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:24: +s32 txgbe_dcb_config_rx_arbiter_raptor(struct txgbe_hw *, u16 *, u16 *, u8 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1848: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:28: +s32 txgbe_dcb_config_raptor(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name #1848: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:28: +s32 txgbe_dcb_config_raptor(struct txgbe_hw *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #1851: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:31: +s32 txgbe_dcb_hw_config_raptor(struct txgbe_hw *, int, u16 *, u16 *, u8 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #1851: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:31: +s32 txgbe_dcb_hw_config_raptor(struct txgbe_hw *, int, u16 *, u16 *, u8 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1851: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:31: +s32 txgbe_dcb_hw_config_raptor(struct txgbe_hw *, int, u16 *, u16 *, u8 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #1851: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:31: +s32 txgbe_dcb_hw_config_raptor(struct txgbe_hw *, int, u16 *, u16 *, u8 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1851: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:31: +s32 txgbe_dcb_hw_config_raptor(struct txgbe_hw *, int, u16 *, u16 *, u8 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1851: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:31: +s32 txgbe_dcb_hw_config_raptor(struct txgbe_hw *, int, u16 *, u16 *, u8 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1851: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.h:31: +s32 txgbe_dcb_hw_config_raptor(struct txgbe_hw *, int, u16 *, u16 *, u8 *, ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1915: FILE: drivers/net/txgbe/base/txgbe_dummy.h:10: +#define TUP(x) x##_unused __attribute__((unused)) WARNING:RETURN_VOID: void function return statements are not generally useful #1940: FILE: drivers/net/txgbe/base/txgbe_dummy.h:35: + return; +} WARNING:LONG_LINE: line over 100 characters #1950: FILE: drivers/net/txgbe/base/txgbe_dummy.h:45: +static inline s32 txgbe_rom_readw_buffer_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, void *TUP3) WARNING:LONG_LINE: line over 100 characters #1970: FILE: drivers/net/txgbe/base/txgbe_dummy.h:65: +static inline s32 txgbe_rom_writew_buffer_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, void *TUP3) WARNING:LONG_LINE: line over 100 characters #1982: FILE: drivers/net/txgbe/base/txgbe_dummy.h:77: +static inline s32 txgbe_rom_write_buffer_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, void *TUP3) WARNING:RETURN_VOID: void function return statements are not generally useful #2023: FILE: drivers/net/txgbe/base/txgbe_dummy.h:118: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2091: FILE: drivers/net/txgbe/base/txgbe_dummy.h:186: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2095: FILE: drivers/net/txgbe/base/txgbe_dummy.h:190: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2103: FILE: drivers/net/txgbe/base/txgbe_dummy.h:198: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2119: FILE: drivers/net/txgbe/base/txgbe_dummy.h:214: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2123: FILE: drivers/net/txgbe/base/txgbe_dummy.h:218: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2127: FILE: drivers/net/txgbe/base/txgbe_dummy.h:222: + return; +} WARNING:LONG_LINE: line over 100 characters #2136: FILE: drivers/net/txgbe/base/txgbe_dummy.h:231: +static inline s32 txgbe_mac_check_link_dummy(struct txgbe_hw *TUP0, u32 *TUP1, bool *TUP3, bool TUP4) WARNING:LONG_LINE: line over 100 characters #2140: FILE: drivers/net/txgbe/base/txgbe_dummy.h:235: +static inline s32 txgbe_mac_get_link_capabilities_dummy(struct txgbe_hw *TUP0, u32 *TUP1, bool *TUP2) WARNING:RETURN_VOID: void function return statements are not generally useful #2147: FILE: drivers/net/txgbe/base/txgbe_dummy.h:242: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2151: FILE: drivers/net/txgbe/base/txgbe_dummy.h:246: + return; +} WARNING:LONG_LINE: line over 100 characters #2172: FILE: drivers/net/txgbe/base/txgbe_dummy.h:267: +static inline s32 txgbe_mac_set_rar_dummy(struct txgbe_hw *TUP0, u32 TUP1, u8 *TUP2, u32 TUP3, u32 TUP4) WARNING:LONG_LINE: line over 100 characters #2204: FILE: drivers/net/txgbe/base/txgbe_dummy.h:299: +static inline s32 txgbe_mac_update_uc_addr_list_dummy(struct txgbe_hw *TUP0, u8 *TUP1, u32 TUP2, txgbe_mc_addr_itr TUP3) WARNING:LONG_LINE: line over 100 characters #2208: FILE: drivers/net/txgbe/base/txgbe_dummy.h:303: +static inline s32 txgbe_mac_update_mc_addr_list_dummy(struct txgbe_hw *TUP0, u8 *TUP1, u32 TUP2, txgbe_mc_addr_itr TUP3, bool TUP4) WARNING:LONG_LINE: line over 100 characters #2224: FILE: drivers/net/txgbe/base/txgbe_dummy.h:319: +static inline s32 txgbe_mac_set_vfta_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, bool TUP3, bool TUP4) WARNING:LONG_LINE: line over 100 characters #2228: FILE: drivers/net/txgbe/base/txgbe_dummy.h:323: +static inline s32 txgbe_mac_set_vlvf_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, bool TUP3, u32 *TUP4, u32 TUP5, bool TUP6) WARNING:RETURN_VOID: void function return statements are not generally useful #2239: FILE: drivers/net/txgbe/base/txgbe_dummy.h:334: + return; +} WARNING:LONG_LINE: line over 100 characters #2240: FILE: drivers/net/txgbe/base/txgbe_dummy.h:335: +static inline void txgbe_mac_set_vlan_anti_spoofing_dummy(struct txgbe_hw *TUP0, bool TUP1, int TUP2) WARNING:RETURN_VOID: void function return statements are not generally useful #2243: FILE: drivers/net/txgbe/base/txgbe_dummy.h:338: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2263: FILE: drivers/net/txgbe/base/txgbe_dummy.h:358: + return; +} WARNING:LONG_LINE: line over 100 characters #2264: FILE: drivers/net/txgbe/base/txgbe_dummy.h:359: +static inline s32 txgbe_mac_set_fw_drv_ver_dummy(struct txgbe_hw *TUP0, u8 TUP1, u8 TUP2, u8 TUP3, u8 TUP4, u16 TUP5, const char *TUP6) WARNING:RETURN_VOID: void function return statements are not generally useful #2279: FILE: drivers/net/txgbe/base/txgbe_dummy.h:374: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2283: FILE: drivers/net/txgbe/base/txgbe_dummy.h:378: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2287: FILE: drivers/net/txgbe/base/txgbe_dummy.h:382: + return; +} WARNING:LONG_LINE: line over 100 characters #2288: FILE: drivers/net/txgbe/base/txgbe_dummy.h:383: +static inline void txgbe_mac_set_source_address_pruning_dummy(struct txgbe_hw *TUP0, bool TUP1, unsigned int TUP2) WARNING:RETURN_VOID: void function return statements are not generally useful #2291: FILE: drivers/net/txgbe/base/txgbe_dummy.h:386: + return; +} WARNING:LONG_LINE: line over 100 characters #2292: FILE: drivers/net/txgbe/base/txgbe_dummy.h:387: +static inline void txgbe_mac_set_ethertype_anti_spoofing_dummy(struct txgbe_hw *TUP0, bool TUP1, int TUP2) WARNING:RETURN_VOID: void function return statements are not generally useful #2295: FILE: drivers/net/txgbe/base/txgbe_dummy.h:390: + return; +} WARNING:LONG_LINE: line over 100 characters #2312: FILE: drivers/net/txgbe/base/txgbe_dummy.h:407: +static inline s32 txgbe_mac_read_iosf_sb_reg_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, u32 *TUP3) WARNING:LONG_LINE: line over 100 characters #2316: FILE: drivers/net/txgbe/base/txgbe_dummy.h:411: +static inline s32 txgbe_mac_write_iosf_sb_reg_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, u32 TUP3) WARNING:RETURN_VOID: void function return statements are not generally useful #2323: FILE: drivers/net/txgbe/base/txgbe_dummy.h:418: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2327: FILE: drivers/net/txgbe/base/txgbe_dummy.h:422: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2331: FILE: drivers/net/txgbe/base/txgbe_dummy.h:426: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2335: FILE: drivers/net/txgbe/base/txgbe_dummy.h:430: + return; +} WARNING:RETURN_VOID: void function return statements are not generally useful #2421: FILE: drivers/net/txgbe/base/txgbe_dummy.h:516: + return; +} WARNING:LONG_LINE: line over 100 characters #2438: FILE: drivers/net/txgbe/base/txgbe_dummy.h:533: +static inline s32 txgbe_phy_read_i2c_byte_unlocked_dummy(struct txgbe_hw *TUP0, u8 TUP1, u8 TUP2, u8 *TUP3) WARNING:LONG_LINE: line over 100 characters #2442: FILE: drivers/net/txgbe/base/txgbe_dummy.h:537: +static inline s32 txgbe_phy_write_i2c_byte_unlocked_dummy(struct txgbe_hw *TUP0, u8 TUP1, u8 TUP2, u8 TUP3) WARNING:LONG_LINE: line over 100 characters #2452: FILE: drivers/net/txgbe/base/txgbe_dummy.h:547: +static inline s32 txgbe_link_read_link_unlocked_dummy(struct txgbe_hw *TUP0, u8 TUP1, u16 TUP2, u16 *TUP3) WARNING:LONG_LINE: line over 100 characters #2460: FILE: drivers/net/txgbe/base/txgbe_dummy.h:555: +static inline s32 txgbe_link_write_link_unlocked_dummy(struct txgbe_hw *TUP0, u8 TUP1, u16 TUP2, u16 TUP3) WARNING:RETURN_VOID: void function return statements are not generally useful #2469: FILE: drivers/net/txgbe/base/txgbe_dummy.h:564: + return; +} WARNING:BRACES: braces {} are not necessary for single statement blocks #2678: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:28: + if (eeprom->type != txgbe_eeprom_unknown) { + return 0; + } WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2684: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:34: + * tested value */ WARNING:BRACES: braces {} are not necessary for single statement blocks #3140: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:490: + for (j = 0; j < seg; j++) { + checksum += buffer[j]; + } WARNING:AVOID_EXTERNS: externs should be avoided in .c files #3605: FILE: drivers/net/txgbe/base/txgbe_hw.c:22: +STATIC s32 txgbe_setup_copper_link_raptor(struct txgbe_hw *hw, WARNING:AVOID_EXTERNS: externs should be avoided in .c files #3609: FILE: drivers/net/txgbe/base/txgbe_hw.c:26: +STATIC s32 txgbe_mta_vector(struct txgbe_hw *hw, u8 *mc_addr); WARNING:AVOID_EXTERNS: externs should be avoided in .c files #3610: FILE: drivers/net/txgbe/base/txgbe_hw.c:27: +STATIC s32 txgbe_get_san_mac_addr_offset(struct txgbe_hw *hw, WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment #3708: FILE: drivers/net/txgbe/base/txgbe_hw.c:125: + /* fall through - only backplane uses autoc */ WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return #3785: FILE: drivers/net/txgbe/base/txgbe_hw.c:202: + goto out; + break; CHECK:CAMELCASE: Avoid CamelCase: #3989: FILE: drivers/net/txgbe/base/txgbe_hw.c:406: + rd64(hw, TXGBE_MACRX1024toMAXL); CHECK:CAMELCASE: Avoid CamelCase: #3995: FILE: drivers/net/txgbe/base/txgbe_hw.c:412: + rd64(hw, TXGBE_MACTX1024toMAXL); WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test #4428: FILE: drivers/net/txgbe/base/txgbe_hw.c:845: + if (TXGBE_PWR_LANID_SWAP == TXGBE_PWR_LANID(reg)) WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_add_uc_addr', this function's name, in a string #4758: FILE: drivers/net/txgbe/base/txgbe_hw.c:1175: + DEBUGOUT("txgbe_add_uc_addr Complete "); CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4796: FILE: drivers/net/txgbe/base/txgbe_hw.c:1213: + DEBUGOUT("Clearing RAR[1-%d] ", uc_addr_in_use+1); ^ WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_update_uc_addr_list', this function's name, in a string #4828: FILE: drivers/net/txgbe/base/txgbe_hw.c:1245: + DEBUGOUT("txgbe_update_uc_addr_list Complete "); WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_update_mc_addr_list', this function's name, in a string #4960: FILE: drivers/net/txgbe/base/txgbe_hw.c:1377: + DEBUGOUT("txgbe_update_mc_addr_list Complete "); WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #5369: FILE: drivers/net/txgbe/base/txgbe_hw.c:1786: + return 0; + } else { WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #5431: FILE: drivers/net/txgbe/base/txgbe_hw.c:1848: + break; + else CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line #5668: FILE: drivers/net/txgbe/base/txgbe_hw.c:2085: + if (((TXGBE_ETHADDRH_VLD & rar_high) == 0) + && first_empty_rar == NO_EMPTY_RAR_FOUND) { CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #6075: FILE: drivers/net/txgbe/base/txgbe_hw.c:2492: +{ + WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #6148: FILE: drivers/net/txgbe/base/txgbe_hw.c:2565: + break; + } else { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'alt_san_mac_blk_offset == 0' #6205: FILE: drivers/net/txgbe/base/txgbe_hw.c:2622: + if ((alt_san_mac_blk_offset == 0) || + (alt_san_mac_blk_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'alt_san_mac_blk_offset == 0xFFFF' #6205: FILE: drivers/net/txgbe/base/txgbe_hw.c:2622: + if ((alt_san_mac_blk_offset == 0) || + (alt_san_mac_blk_offset == 0xFFFF)) WARNING:BRACES: braces {} are not necessary for single statement blocks #6218: FILE: drivers/net/txgbe/base/txgbe_hw.c:2635: + if (hw->rom.read16(hw, offset, wwnn_prefix)) { + DEBUGOUT("eeprom read at offset %d failed", offset); + } CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset == 0' #6265: FILE: drivers/net/txgbe/base/txgbe_hw.c:2682: + if ((offset == 0) || (offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset == 0xFFFF' #6265: FILE: drivers/net/txgbe/base/txgbe_hw.c:2682: + if ((offset == 0) || (offset == 0xFFFF)) WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment #6377: FILE: drivers/net/txgbe/base/txgbe_hw.c:2794: + /* fall through - configure remaining packet buffers */ WARNING:BRACES: braces {} are not necessary for single statement blocks #6435: FILE: drivers/net/txgbe/base/txgbe_hw.c:2852: + for (i = 0; i < poll; i++) { + usec_delay(100); + } WARNING:BRACES: braces {} are not necessary for single statement blocks #6462: FILE: drivers/net/txgbe/base/txgbe_hw.c:2879: + if (hw->bus.lan_id != 0) { + return TXGBE_NOT_IMPLEMENTED; + } CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset == 0x0' #6532: FILE: drivers/net/txgbe/base/txgbe_hw.c:2949: + if ((offset == 0x0) || (offset == NVM_INVALID_PTR)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset == NVM_INVALID_PTR' #6532: FILE: drivers/net/txgbe/base/txgbe_hw.c:2949: + if ((offset == 0x0) || (offset == NVM_INVALID_PTR)) WARNING:RETURN_VOID: void function return statements are not generally useful #6641: FILE: drivers/net/txgbe/base/txgbe_hw.c:3058: + return; +} WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_set_mac_type', this function's name, in a string #6940: FILE: drivers/net/txgbe/base/txgbe_hw.c:3357: + DEBUGFUNC("txgbe_set_mac_type "); WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_set_mac_type', this function's name, in a string #6977: FILE: drivers/net/txgbe/base/txgbe_hw.c:3394: + DEBUGOUT("txgbe_set_mac_type found mac: %d media: %d, returns: %d ", CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == txgbe_media_type_fiber' #6992: FILE: drivers/net/txgbe/base/txgbe_hw.c:3409: + if ((hw->phy.media_type == txgbe_media_type_fiber) && + !txgbe_mng_enabled(hw)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'link_speed == TXGBE_LINK_SPEED_1GB_FULL' #7729: FILE: drivers/net/txgbe/base/txgbe_hw.c:4146: + if (link_up && (link_speed == TXGBE_LINK_SPEED_1GB_FULL)) CHECK:CAMELCASE: Avoid CamelCase: #7751: FILE: drivers/net/txgbe/base/txgbe_hw.c:4168: + u64 pma_pmd_10gs = autoc & TXGBE_AUTOC_10Gs_PMA_PMD_MASK; WARNING:BRACES: braces {} are not necessary for single statement blocks #7769: FILE: drivers/net/txgbe/base/txgbe_hw.c:4186: + if (speed == TXGBE_LINK_SPEED_UNKNOWN) { + return TXGBE_ERR_LINK_SETUP; + } CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.smart_speed_active == false' #7792: FILE: drivers/net/txgbe/base/txgbe_hw.c:4209: + if ((orig_autoc & TXGBE_AUTOC_KR_SUPP) && + (hw->phy.smart_speed_active == false)) CHECK:BOOL_COMPARISON: Using comparison to false is error prone #7793: FILE: drivers/net/txgbe/base/txgbe_hw.c:4210: + (hw->phy.smart_speed_active == false)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed == TXGBE_LINK_SPEED_10GB_FULL' #7802: FILE: drivers/net/txgbe/base/txgbe_hw.c:4219: + if ((speed == TXGBE_LINK_SPEED_10GB_FULL) && + (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI' #7802: FILE: drivers/net/txgbe/base/txgbe_hw.c:4219: + if ((speed == TXGBE_LINK_SPEED_10GB_FULL) && + (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI)) { CHECK:CAMELCASE: Avoid CamelCase: #7803: FILE: drivers/net/txgbe/base/txgbe_hw.c:4220: + (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI)) { CHECK:CAMELCASE: Avoid CamelCase: #7805: FILE: drivers/net/txgbe/base/txgbe_hw.c:4222: + autoc |= TXGBE_AUTOC_LMS_10Gs; CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed == TXGBE_LINK_SPEED_1GB_FULL' #7810: FILE: drivers/net/txgbe/base/txgbe_hw.c:4227: + if ((speed == TXGBE_LINK_SPEED_1GB_FULL) && + (pma_pmd_1g == TXGBE_AUTOC_1G_SFI)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pma_pmd_1g == TXGBE_AUTOC_1G_SFI' #7810: FILE: drivers/net/txgbe/base/txgbe_hw.c:4227: + if ((speed == TXGBE_LINK_SPEED_1GB_FULL) && + (pma_pmd_1g == TXGBE_AUTOC_1G_SFI)) { WARNING:BRACES: braces {} are not necessary for single statement blocks #7820: FILE: drivers/net/txgbe/base/txgbe_hw.c:4237: + if (autoc == current_autoc) { + return status; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #7898: FILE: drivers/net/txgbe/base/txgbe_hw.c:4315: + if (i == 10) { + err = TXGBE_ERR_FLASH_LOADING_FAILED; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #7915: FILE: drivers/net/txgbe/base/txgbe_hw.c:4332: + if ((value & 0x3) != SR_PCS_CTRL2_TYPE_SEL_X) { + hw->link_status = TXGBE_LINK_STATUS_NONE; + } WARNING:TYPO_SPELLING: 'transmiter' may be misspelled - perhaps 'transmitter'? #7961: FILE: drivers/net/txgbe/base/txgbe_hw.c:4378: + /* enable mac transmiter */ WARNING:BRACES: braces {} are not necessary for single statement blocks #7964: FILE: drivers/net/txgbe/base/txgbe_hw.c:4381: + for (i = 0; i < 4; i++) { + wr32m(hw, TXGBE_IVAR(i), 0x80808080, 0); + } CHECK:BOOL_COMPARISON: Using comparison to false is error prone #8006: FILE: drivers/net/txgbe/base/txgbe_hw.c:4423: + if (hw->phy.reset_disable == false) CHECK:BOOL_COMPARISON: Using comparison to false is error prone #8056: FILE: drivers/net/txgbe/base/txgbe_hw.c:4473: + if (hw->mac.orig_link_settings_stored == false) { WARNING:RETURN_VOID: void function return statements are not generally useful #8479: FILE: drivers/net/txgbe/base/txgbe_hw.c:4896: + return; +} CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #8504: FILE: drivers/net/txgbe/base/txgbe_hw.c:4921: +{ + WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #8635: FILE: drivers/net/txgbe/base/txgbe_hw.c:5052: + * layout */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #8672: FILE: drivers/net/txgbe/base/txgbe_hw.c:5089: + * (big-endian) */ WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment #8794: FILE: drivers/net/txgbe/base/txgbe_hw.c:5211: + /* fall through */ CHECK:BRACES: Unbalanced braces around else statement #8890: FILE: drivers/net/txgbe/base/txgbe_hw.c:5307: + } else CHECK:CAMELCASE: Avoid CamelCase: #8903: FILE: drivers/net/txgbe/base/txgbe_hw.c:5320: + if (pma_pmd_10gs == TXGBE_AUTOC_10Gs_KR) { WARNING:BRACES: braces {} are not necessary for any arm of this statement #8903: FILE: drivers/net/txgbe/base/txgbe_hw.c:5320: + if (pma_pmd_10gs == TXGBE_AUTOC_10Gs_KR) { [...] + } else if (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI) [...] WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #8926: FILE: drivers/net/txgbe/base/txgbe_hw.c:5343: + * Call identify_sfp because the pluggable module may have changed */ CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #8939: FILE: drivers/net/txgbe/base/txgbe_hw.c:5356: +{ + CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'status != 0' #8979: FILE: drivers/net/txgbe/base/txgbe_hw.c:5396: + if ((status != 0) || + (fw_offset == 0) || (fw_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_offset == 0' #8979: FILE: drivers/net/txgbe/base/txgbe_hw.c:5396: + if ((status != 0) || + (fw_offset == 0) || (fw_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_offset == 0xFFFF' #8979: FILE: drivers/net/txgbe/base/txgbe_hw.c:5396: + if ((status != 0) || + (fw_offset == 0) || (fw_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'status != 0' #8988: FILE: drivers/net/txgbe/base/txgbe_hw.c:5405: + if ((status != 0) || + (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_lesm_param_offset == 0' #8988: FILE: drivers/net/txgbe/base/txgbe_hw.c:5405: + if ((status != 0) || + (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_lesm_param_offset == 0xFFFF' #8988: FILE: drivers/net/txgbe/base/txgbe_hw.c:5405: + if ((status != 0) || + (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'status == 0' #8997: FILE: drivers/net/txgbe/base/txgbe_hw.c:5414: + if ((status == 0) && + (fw_lesm_state & TXGBE_FW_LESM_STATE_ENABLED)) WARNING:BRACES: braces {} are not necessary for single statement blocks #9022: FILE: drivers/net/txgbe/base/txgbe_hw.c:5439: + if (autoc & TXGBE_AUTOC_LINK_DIA_MASK) { + autoc &= ~TXGBE_AUTOC_LINK_DIA_MASK; + } WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #9137: FILE: drivers/net/txgbe/base/txgbe_hw.h:95: +s32 txgbe_shutdown_fw_phy(struct txgbe_hw *); CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9140: FILE: drivers/net/txgbe/base/txgbe_hw.h:98: +extern s32 txgbe_reset_pipeline_raptor(struct txgbe_hw *hw); CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #9141: FILE: drivers/net/txgbe/base/txgbe_hw.h:99: +extern void txgbe_stop_mac_link_on_d3_raptor(struct txgbe_hw *hw); CHECK:BRACES: braces {} should be used on all arms of this statement #9274: FILE: drivers/net/txgbe/base/txgbe_mbx.c:51: + if (size > mbx->size) { [...] + } else if (mbx->write) [...] WARNING:TYPO_SPELLING: 'acknowledgement' may be misspelled - perhaps 'acknowledgment'? #9375: FILE: drivers/net/txgbe/base/txgbe_mbx.c:152: + * txgbe_poll_for_ack - Wait for message acknowledgement WARNING:TYPO_SPELLING: 'acknowledgement' may be misspelled - perhaps 'acknowledgment'? #9379: FILE: drivers/net/txgbe/base/txgbe_mbx.c:156: + * returns SUCCESS if it successfully received a message acknowledgement WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #9683: FILE: drivers/net/txgbe/base/txgbe_mbx.c:460: + * value to begin communications */ CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #9849: FILE: drivers/net/txgbe/base/txgbe_mbx.c:626: + +} WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #9932: FILE: drivers/net/txgbe/base/txgbe_mbx.h:18: + * this are the ACK */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #9934: FILE: drivers/net/txgbe/base/txgbe_mbx.h:20: + * this are the NACK */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #9936: FILE: drivers/net/txgbe/base/txgbe_mbx.h:22: + * clear to send requests */ WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10016: FILE: drivers/net/txgbe/base/txgbe_mbx.h:102: +s32 txgbe_read_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #10016: FILE: drivers/net/txgbe/base/txgbe_mbx.h:102: +s32 txgbe_read_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10016: FILE: drivers/net/txgbe/base/txgbe_mbx.h:102: +s32 txgbe_read_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10016: FILE: drivers/net/txgbe/base/txgbe_mbx.h:102: +s32 txgbe_read_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10017: FILE: drivers/net/txgbe/base/txgbe_mbx.h:103: +s32 txgbe_write_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #10017: FILE: drivers/net/txgbe/base/txgbe_mbx.h:103: +s32 txgbe_write_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10017: FILE: drivers/net/txgbe/base/txgbe_mbx.h:103: +s32 txgbe_write_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10017: FILE: drivers/net/txgbe/base/txgbe_mbx.h:103: +s32 txgbe_write_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10018: FILE: drivers/net/txgbe/base/txgbe_mbx.h:104: +s32 txgbe_read_posted_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #10018: FILE: drivers/net/txgbe/base/txgbe_mbx.h:104: +s32 txgbe_read_posted_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10018: FILE: drivers/net/txgbe/base/txgbe_mbx.h:104: +s32 txgbe_read_posted_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10018: FILE: drivers/net/txgbe/base/txgbe_mbx.h:104: +s32 txgbe_read_posted_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10019: FILE: drivers/net/txgbe/base/txgbe_mbx.h:105: +s32 txgbe_write_posted_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #10019: FILE: drivers/net/txgbe/base/txgbe_mbx.h:105: +s32 txgbe_write_posted_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10019: FILE: drivers/net/txgbe/base/txgbe_mbx.h:105: +s32 txgbe_write_posted_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10019: FILE: drivers/net/txgbe/base/txgbe_mbx.h:105: +s32 txgbe_write_posted_mbx(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10020: FILE: drivers/net/txgbe/base/txgbe_mbx.h:106: +s32 txgbe_check_for_msg(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10020: FILE: drivers/net/txgbe/base/txgbe_mbx.h:106: +s32 txgbe_check_for_msg(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10021: FILE: drivers/net/txgbe/base/txgbe_mbx.h:107: +s32 txgbe_check_for_ack(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10021: FILE: drivers/net/txgbe/base/txgbe_mbx.h:107: +s32 txgbe_check_for_ack(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10022: FILE: drivers/net/txgbe/base/txgbe_mbx.h:108: +s32 txgbe_check_for_rst(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10022: FILE: drivers/net/txgbe/base/txgbe_mbx.h:108: +s32 txgbe_check_for_rst(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10023: FILE: drivers/net/txgbe/base/txgbe_mbx.h:109: +void txgbe_init_mbx_params_vf(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10024: FILE: drivers/net/txgbe/base/txgbe_mbx.h:110: +void txgbe_init_mbx_params_pf(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10026: FILE: drivers/net/txgbe/base/txgbe_mbx.h:112: +s32 txgbe_read_mbx_pf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #10026: FILE: drivers/net/txgbe/base/txgbe_mbx.h:112: +s32 txgbe_read_mbx_pf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10026: FILE: drivers/net/txgbe/base/txgbe_mbx.h:112: +s32 txgbe_read_mbx_pf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10026: FILE: drivers/net/txgbe/base/txgbe_mbx.h:112: +s32 txgbe_read_mbx_pf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10027: FILE: drivers/net/txgbe/base/txgbe_mbx.h:113: +s32 txgbe_write_mbx_pf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #10027: FILE: drivers/net/txgbe/base/txgbe_mbx.h:113: +s32 txgbe_write_mbx_pf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10027: FILE: drivers/net/txgbe/base/txgbe_mbx.h:113: +s32 txgbe_write_mbx_pf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10027: FILE: drivers/net/txgbe/base/txgbe_mbx.h:113: +s32 txgbe_write_mbx_pf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10028: FILE: drivers/net/txgbe/base/txgbe_mbx.h:114: +s32 txgbe_check_for_msg_pf(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10028: FILE: drivers/net/txgbe/base/txgbe_mbx.h:114: +s32 txgbe_check_for_msg_pf(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10029: FILE: drivers/net/txgbe/base/txgbe_mbx.h:115: +s32 txgbe_check_for_ack_pf(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10029: FILE: drivers/net/txgbe/base/txgbe_mbx.h:115: +s32 txgbe_check_for_ack_pf(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10030: FILE: drivers/net/txgbe/base/txgbe_mbx.h:116: +s32 txgbe_check_for_rst_pf(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10030: FILE: drivers/net/txgbe/base/txgbe_mbx.h:116: +s32 txgbe_check_for_rst_pf(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10032: FILE: drivers/net/txgbe/base/txgbe_mbx.h:118: +s32 txgbe_read_mbx_vf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #10032: FILE: drivers/net/txgbe/base/txgbe_mbx.h:118: +s32 txgbe_read_mbx_vf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10032: FILE: drivers/net/txgbe/base/txgbe_mbx.h:118: +s32 txgbe_read_mbx_vf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10032: FILE: drivers/net/txgbe/base/txgbe_mbx.h:118: +s32 txgbe_read_mbx_vf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10033: FILE: drivers/net/txgbe/base/txgbe_mbx.h:119: +s32 txgbe_write_mbx_vf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #10033: FILE: drivers/net/txgbe/base/txgbe_mbx.h:119: +s32 txgbe_write_mbx_vf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10033: FILE: drivers/net/txgbe/base/txgbe_mbx.h:119: +s32 txgbe_write_mbx_vf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10033: FILE: drivers/net/txgbe/base/txgbe_mbx.h:119: +s32 txgbe_write_mbx_vf(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10034: FILE: drivers/net/txgbe/base/txgbe_mbx.h:120: +s32 txgbe_check_for_msg_vf(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10034: FILE: drivers/net/txgbe/base/txgbe_mbx.h:120: +s32 txgbe_check_for_msg_vf(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10035: FILE: drivers/net/txgbe/base/txgbe_mbx.h:121: +s32 txgbe_check_for_ack_vf(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10035: FILE: drivers/net/txgbe/base/txgbe_mbx.h:121: +s32 txgbe_check_for_ack_vf(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #10036: FILE: drivers/net/txgbe/base/txgbe_mbx.h:122: +s32 txgbe_check_for_rst_vf(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #10036: FILE: drivers/net/txgbe/base/txgbe_mbx.h:122: +s32 txgbe_check_for_rst_vf(struct txgbe_hw *, u16); CHECK:SPACING: No space is necessary after a cast #10069: FILE: drivers/net/txgbe/base/txgbe_mng.c:25: + return (u8) (0 - sum); WARNING:BRACES: braces {} are not necessary for single statement blocks #10184: FILE: drivers/net/txgbe/base/txgbe_mng.c:140: + for (bi = 0; bi < dword_len; bi++) { + buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi); + } WARNING:BRACES: braces {} are not necessary for single statement blocks #10194: FILE: drivers/net/txgbe/base/txgbe_mng.c:150: + for (; bi < dword_len + 2; bi++) { + buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi); + } WARNING:BRACES: braces {} are not necessary for single statement blocks #10216: FILE: drivers/net/txgbe/base/txgbe_mng.c:172: + for (; bi <= dword_len; bi++) { + buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi); + } WARNING:BRACES: braces {} are not necessary for single statement blocks #10264: FILE: drivers/net/txgbe/base/txgbe_mng.c:220: + for (i <<= 2; i < len; i++) { + ((u8 *)buf)[i] = ((u8 *)&value)[j++]; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #10302: FILE: drivers/net/txgbe/base/txgbe_mng.c:258: + for (i <<= 2; i < len; i++) { + ((u8 *)&value)[j++] = ((u8 *)buf)[i]; + } WARNING:LONG_LINE: line over 100 characters #10621: FILE: drivers/net/txgbe/base/txgbe_mng.h:171: +s32 txgbe_hic_set_drv_ver(struct txgbe_hw *hw, u8 maj, u8 min, u8 build, u8 ver, u16 len, const char *str); WARNING:MEMORY_BARRIER: memory barrier without comment #10782: FILE: drivers/net/txgbe/base/txgbe_osdep.h:151: +#define mb() rte_mb() WARNING:MEMORY_BARRIER: memory barrier without comment #10783: FILE: drivers/net/txgbe/base/txgbe_osdep.h:152: +#define wmb() rte_wmb() WARNING:MEMORY_BARRIER: memory barrier without comment #10784: FILE: drivers/net/txgbe/base/txgbe_osdep.h:153: +#define rmb() rte_rmb() CHECK:CAMELCASE: Avoid CamelCase:
#10804: FILE: drivers/net/txgbe/base/txgbe_osdep.h:173: +#define TXGBE_IS_MULTICAST(Address) \ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'Address' - possible side-effects? #10808: FILE: drivers/net/txgbe/base/txgbe_osdep.h:177: +#define TXGBE_IS_BROADCAST(Address) \ + ((((u8 *)(Address))[0] == ((u8)0xff)) && \ + (((u8 *)(Address))[1] == ((u8)0xff))) WARNING:AVOID_EXTERNS: externs should be avoided in .c files #10832: FILE: drivers/net/txgbe/base/txgbe_phy.c:11: +STATIC void txgbe_i2c_stop(struct txgbe_hw *hw); WARNING:BRACES: braces {} are not necessary for single statement blocks #10888: FILE: drivers/net/txgbe/base/txgbe_phy.c:67: + if (hw->phy.nw_mng_if_sel & TXGBE_ETHPHYIF_MDIO_ACT) { + hw->phy.addr = TXGBE_ETHPHYIF_MDIO_BASE(hw->phy.nw_mng_if_sel); + } WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test #11107: FILE: drivers/net/txgbe/base/txgbe_phy.c:286: + if (TXGBE_ERR_OVERTEMP == hw->phy.check_overtemp(hw)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'connector == TXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE' #12115: FILE: drivers/net/txgbe/base/txgbe_phy.c:1294: + if ((connector == + TXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE) && + (cable_length > 0) && + ((device_tech >> 4) == + TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cable_length > 0' #12115: FILE: drivers/net/txgbe/base/txgbe_phy.c:1294: + if ((connector == + TXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE) && + (cable_length > 0) && + ((device_tech >> 4) == + TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL)) WARNING:TYPO_SPELLING: 'TRANSMITER' may be misspelled - perhaps 'TRANSMITTER'? #12119: FILE: drivers/net/txgbe/base/txgbe_phy.c:1298: + TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL)) CHECK:BOOL_COMPARISON: Using comparison to true is error prone #12190: FILE: drivers/net/txgbe/base/txgbe_phy.c:1369: + if (hw->allow_unsupported_sfp == true) { CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #12191: FILE: drivers/net/txgbe/base/txgbe_phy.c:1370: + DEBUGOUT( WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #12279: FILE: drivers/net/txgbe/base/txgbe_phy.c:1458: + return TXGBE_ERR_SFP_NOT_SUPPORTED; + } else { CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #12509: FILE: drivers/net/txgbe/base/txgbe_phy.c:1688: + +} WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #12618: FILE: drivers/net/txgbe/base/txgbe_phy.c:1797: + msleep(10); WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #12631: FILE: drivers/net/txgbe/base/txgbe_phy.c:1810: + msleep(1); WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #12633: FILE: drivers/net/txgbe/base/txgbe_phy.c:1812: + * for corresponding LAN port */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #12660: FILE: drivers/net/txgbe/base/txgbe_phy.c:1839: + * Control1 Register Bit[15](VR_RST) */ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17) #12675: FILE: drivers/net/txgbe/base/txgbe_phy.c:1854: + } else { + wr32_epcs(hw, VR_AN_KR_MODE_CL, 0x1); WARNING:BRACES: braces {} are not necessary for single statement blocks #12690: FILE: drivers/net/txgbe/base/txgbe_phy.c:1869: + if (hw->link_status == TXGBE_LINK_STATUS_KX4) { + goto out; + } WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #12700: FILE: drivers/net/txgbe/base/txgbe_phy.c:1879: + msleep(10); WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #12719: FILE: drivers/net/txgbe/base/txgbe_phy.c:1898: + msleep(1); WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #12722: FILE: drivers/net/txgbe/base/txgbe_phy.c:1901: + * for corresponding LAN port */ WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12764: FILE: drivers/net/txgbe/base/txgbe_phy.c:1943: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY MPLLA WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12770: FILE: drivers/net/txgbe/base/txgbe_phy.c:1949: + /* Set VR XS, PMA or MII Synopsys Enterprise Gen5 12G PHY MPLLA WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12776: FILE: drivers/net/txgbe/base/txgbe_phy.c:1955: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12782: FILE: drivers/net/txgbe/base/txgbe_phy.c:1961: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12788: FILE: drivers/net/txgbe/base/txgbe_phy.c:1967: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12793: FILE: drivers/net/txgbe/base/txgbe_phy.c:1972: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12798: FILE: drivers/net/txgbe/base/txgbe_phy.c:1977: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12803: FILE: drivers/net/txgbe/base/txgbe_phy.c:1982: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12808: FILE: drivers/net/txgbe/base/txgbe_phy.c:1987: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY AFE-DFE WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #12808: FILE: drivers/net/txgbe/base/txgbe_phy.c:1987: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY AFE-DFE WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #12809: FILE: drivers/net/txgbe/base/txgbe_phy.c:1988: + * Enable Register Bit[7:0] = 8'd0 //AFE_EN_0/3_1, DFE_EN_0/3_1 WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #12811: FILE: drivers/net/txgbe/base/txgbe_phy.c:1990: + wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, 0x0); WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12813: FILE: drivers/net/txgbe/base/txgbe_phy.c:1992: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12818: FILE: drivers/net/txgbe/base/txgbe_phy.c:1997: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Tx Rate WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12824: FILE: drivers/net/txgbe/base/txgbe_phy.c:2003: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx Rate WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12830: FILE: drivers/net/txgbe/base/txgbe_phy.c:2009: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Tx General WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12835: FILE: drivers/net/txgbe/base/txgbe_phy.c:2014: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx General WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12840: FILE: drivers/net/txgbe/base/txgbe_phy.c:2019: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY MPLLA Control WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #12852: FILE: drivers/net/txgbe/base/txgbe_phy.c:2031: + * Register Bit[15](VR_RST) */ WARNING:BRACES: braces {} are not necessary for single statement blocks #12886: FILE: drivers/net/txgbe/base/txgbe_phy.c:2065: + if (hw->link_status == TXGBE_LINK_STATUS_KX) { + goto out; + } WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #12896: FILE: drivers/net/txgbe/base/txgbe_phy.c:2075: + msleep(10); WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #12915: FILE: drivers/net/txgbe/base/txgbe_phy.c:2094: + msleep(1); WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #12918: FILE: drivers/net/txgbe/base/txgbe_phy.c:2097: + * for corresponding LAN port */ WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12974: FILE: drivers/net/txgbe/base/txgbe_phy.c:2153: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY MPLLA Control WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12980: FILE: drivers/net/txgbe/base/txgbe_phy.c:2159: + /* Set VR XS, PMA or MII Synopsys Enterprise Gen5 12G PHY MPLLA Control WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12986: FILE: drivers/net/txgbe/base/txgbe_phy.c:2165: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #12996: FILE: drivers/net/txgbe/base/txgbe_phy.c:2175: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #13004: FILE: drivers/net/txgbe/base/txgbe_phy.c:2183: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY AFE-DFE WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13004: FILE: drivers/net/txgbe/base/txgbe_phy.c:2183: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY AFE-DFE WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13005: FILE: drivers/net/txgbe/base/txgbe_phy.c:2184: + * Enable Register Bit[4], Bit[0] = 1'b0 //AFE_EN_0, DFE_EN_0 WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13007: FILE: drivers/net/txgbe/base/txgbe_phy.c:2186: + wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #13009: FILE: drivers/net/txgbe/base/txgbe_phy.c:2188: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #13014: FILE: drivers/net/txgbe/base/txgbe_phy.c:2193: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Tx Rate WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #13020: FILE: drivers/net/txgbe/base/txgbe_phy.c:2199: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx Rate WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #13026: FILE: drivers/net/txgbe/base/txgbe_phy.c:2205: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Tx General WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #13031: FILE: drivers/net/txgbe/base/txgbe_phy.c:2210: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx General WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'? #13036: FILE: drivers/net/txgbe/base/txgbe_phy.c:2215: + /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY MPLLA Control WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #13090: FILE: drivers/net/txgbe/base/txgbe_phy.c:2269: + msleep(10); WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #13106: FILE: drivers/net/txgbe/base/txgbe_phy.c:2285: + msleep(1); WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #13108: FILE: drivers/net/txgbe/base/txgbe_phy.c:2287: + * for corresponding LAN port */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #13203: FILE: drivers/net/txgbe/base/txgbe_phy.c:2382: + * Bit[7:0](DFE_TAP1_0) = 8'd20 */ WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13205: FILE: drivers/net/txgbe/base/txgbe_phy.c:2384: + value = rd32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE); WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13207: FILE: drivers/net/txgbe/base/txgbe_phy.c:2386: + wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, value); WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #13210: FILE: drivers/net/txgbe/base/txgbe_phy.c:2389: + * Bit[7:0](DFE_TAP1_0) = 8'd20 */ WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13212: FILE: drivers/net/txgbe/base/txgbe_phy.c:2391: + /* 9. Set VR_MII_Gen5_12G_AFE_DFE_EN_CTRL Register WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13213: FILE: drivers/net/txgbe/base/txgbe_phy.c:2392: + * Bit[4](DFE_EN_0) = 1'b0, Bit[0](AFE_EN_0) = 1'b0 */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #13213: FILE: drivers/net/txgbe/base/txgbe_phy.c:2392: + * Bit[4](DFE_EN_0) = 1'b0, Bit[0](AFE_EN_0) = 1'b0 */ WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13214: FILE: drivers/net/txgbe/base/txgbe_phy.c:2393: + value = rd32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE); WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13216: FILE: drivers/net/txgbe/base/txgbe_phy.c:2395: + wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, value); WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #13237: FILE: drivers/net/txgbe/base/txgbe_phy.c:2416: + * Bit[12:8](RX_VREF_CTRL) = 5'hF */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #13240: FILE: drivers/net/txgbe/base/txgbe_phy.c:2419: + * Bit[13:8](TX_EQ_MAIN) = 6'd30, Bit[5:0](TX_EQ_PRE) = 6'd4 */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #13245: FILE: drivers/net/txgbe/base/txgbe_phy.c:2424: + * (TX_EQ_OVR_RIDE) = 1'b1, Bit[5:0](TX_EQ_POST) = 6'd36 */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #13266: FILE: drivers/net/txgbe/base/txgbe_phy.c:2445: + * Bit[7:0](DFE_TAP1_0) = 8'd00 */ WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13268: FILE: drivers/net/txgbe/base/txgbe_phy.c:2447: + /* 9. Set VR_MII_Gen5_12G_AFE_DFE_EN_CTRL Register WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13269: FILE: drivers/net/txgbe/base/txgbe_phy.c:2448: + * Bit[4](DFE_EN_0) = 1'b0, Bit[0](AFE_EN_0) = 1'b0 */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #13269: FILE: drivers/net/txgbe/base/txgbe_phy.c:2448: + * Bit[4](DFE_EN_0) = 1'b0, Bit[0](AFE_EN_0) = 1'b0 */ WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13277: FILE: drivers/net/txgbe/base/txgbe_phy.c:2456: + wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, 0x0); WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #13287: FILE: drivers/net/txgbe/base/txgbe_phy.c:2466: + * Register Bit[15](VR_RST) */ WARNING:BRACES: braces {} are not necessary for single statement blocks #13336: FILE: drivers/net/txgbe/base/txgbe_phy.c:2515: + if (hw->device_id != TXGBE_DEV_ID_RAPTOR_SGMII) { + return autoc; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #13368: FILE: drivers/net/txgbe/base/txgbe_phy.c:2547: + if (sr_an_adv_reg2 & SR_AN_MMD_ADV_REG2_BP_TYPE_KR) { + autoc |= TXGBE_AUTOC_10G_KR; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #13371: FILE: drivers/net/txgbe/base/txgbe_phy.c:2550: + if (sr_an_adv_reg2 & SR_AN_MMD_ADV_REG2_BP_TYPE_KX4) { + autoc |= TXGBE_AUTOC_10G_KX4; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #13374: FILE: drivers/net/txgbe/base/txgbe_phy.c:2553: + if (sr_an_adv_reg2 & SR_AN_MMD_ADV_REG2_BP_TYPE_KX) { + autoc |= TXGBE_AUTOC_1G_KX; + } WARNING:BRACES: braces {} are not necessary for any arm of this statement #13431: FILE: drivers/net/txgbe/base/txgbe_phy.c:2610: + if (speed == TXGBE_LINK_SPEED_10GB_FULL) { [...] + } else if (speed == TXGBE_LINK_SPEED_1GB_FULL) { [...] WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13513: FILE: drivers/net/txgbe/base/txgbe_phy.h:67: +#define TXGBE_PHY_AFE_DFE_ENABLE 0x01805D WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13549: FILE: drivers/net/txgbe/base/txgbe_phy.h:103: +#define TXGBE_PHY_AFE_DFE_ENABLE_DFE_EN0 0x10 WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13550: FILE: drivers/net/txgbe/base/txgbe_phy.h:104: +#define TXGBE_PHY_AFE_DFE_ENABLE_AFE_EN0 0x1 WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13550: FILE: drivers/net/txgbe/base/txgbe_phy.h:104: +#define TXGBE_PHY_AFE_DFE_ENABLE_AFE_EN0 0x1 WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'? #13551: FILE: drivers/net/txgbe/base/txgbe_phy.h:105: +#define TXGBE_PHY_AFE_DFE_ENABLE_MASK 0xFF WARNING:TYPO_SPELLING: 'TRANSMITER' may be misspelled - perhaps 'TRANSMITTER'? #13652: FILE: drivers/net/txgbe/base/txgbe_phy.h:206: +#define TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL 0x0 WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #13828: FILE: drivers/net/txgbe/base/txgbe_phy.h:382: +s32 txgbe_read_i2c_combined_int(struct txgbe_hw *, u8 addr, u16 reg, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #13830: FILE: drivers/net/txgbe/base/txgbe_phy.h:384: +s32 txgbe_write_i2c_combined_int(struct txgbe_hw *, u8 addr, u16 reg, CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects? #13876: FILE: drivers/net/txgbe/base/txgbe_regs.h:35: +#define ROUND_UP(x, y) (((x) + (y) - 1) / (y) * (y)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects? #13877: FILE: drivers/net/txgbe/base/txgbe_regs.h:36: +#define ROUND_DOWN(x, y) ((x) / (y) * (y)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #13878: FILE: drivers/net/txgbe/base/txgbe_regs.h:37: +#define ROUND_OVER(x, maxbits, unitbits) \ + ((x) >= 1 << (maxbits) ? 0 : (x) >> (unitbits)) CHECK:CAMELCASE: Avoid CamelCase: #13925: FILE: drivers/net/txgbe/base/txgbe_regs.h:84: +#define TXGBE_AUTOC_10Gs_XFI LS64(1, 48, 0x3) CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #13997: FILE: drivers/net/txgbe/base/txgbe_regs.h:156: +#define TXGBE_RST_LAN(i) MS(((i)+1), 0x1) ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #13999: FILE: drivers/net/txgbe/base/txgbe_regs.h:158: +#define TXGBE_RST_ETH(i) MS(((i)+29), 0x1) ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #14050: FILE: drivers/net/txgbe/base/txgbe_regs.h:209: +#define TXGBE_FLASH_LANRSTD(i) MS(((i)+9), 0x1) ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #14147: FILE: drivers/net/txgbe/base/txgbe_regs.h:306: +#define TXGBE_LEDCTL_OD(s) MS(((s)+16), 0x1) ^ WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'? #14668: FILE: drivers/net/txgbe/base/txgbe_regs.h:827: +#define TXGBE_FCRSSTBL_QUE(v) LS(v, 0, 0x7F) CHECK:CAMELCASE: Avoid CamelCase: #14926: FILE: drivers/net/txgbe/base/txgbe_regs.h:1085: +#define TXGBE_MACRX1024toMAXH 0x00196C CHECK:CAMELCASE: Avoid CamelCase: #14938: FILE: drivers/net/txgbe/base/txgbe_regs.h:1097: +#define TXGBE_MACTX1024toMAXH 0x001860 CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects? #15098: FILE: drivers/net/txgbe/base/txgbe_regs.h:1257: +#define TXGBE_VFPBWRAP_WRAP(r, tc) ((0x7 << 4 * (tc) & (r)) >> 4 * (tc)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects? #15099: FILE: drivers/net/txgbe/base/txgbe_regs.h:1258: +#define TXGBE_VFPBWRAP_EMPT(r, tc) ((0x8 << 4 * (tc) & (r)) >> 4 * (tc)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects? #15299: FILE: drivers/net/txgbe/base/txgbe_regs.h:1458: +#define TXGBE_PBRXSTAT_WRAP(tc, r) ((7u << 4 * (tc) & (r)) >> 4 * (tc)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects? #15300: FILE: drivers/net/txgbe/base/txgbe_regs.h:1459: +#define TXGBE_PBRXSTAT_EMPT(tc, r) ((8u << 4 * (tc) & (r)) >> 4 * (tc)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects? #15313: FILE: drivers/net/txgbe/base/txgbe_regs.h:1472: +#define TXGBE_PBTXSTAT_EMPT(tc, r) ((1 << (tc) & (r)) >> (tc)) WARNING:TYPO_SPELLING: 'sting' may be misspelled - perhaps 'string'? #15537: FILE: drivers/net/txgbe/base/txgbe_regs.h:1696: +#define NVM_VER_SIZE 32 /* version sting size */ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects? #15565: FILE: drivers/net/txgbe/base/txgbe_regs.h:1724: +#define TXGBE_UPDCNT32(reg, last, cur) \ +do { \ + uint32_t latest = rd32(hw, reg); \ + if (hw->offset_loaded | hw->rx_loaded) \ + last = 0; \ + cur += (latest - last) & UINT_MAX; \ + last = latest; \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues #15565: FILE: drivers/net/txgbe/base/txgbe_regs.h:1724: +#define TXGBE_UPDCNT32(reg, last, cur) \ +do { \ + uint32_t latest = rd32(hw, reg); \ + if (hw->offset_loaded | hw->rx_loaded) \ + last = 0; \ + cur += (latest - last) & UINT_MAX; \ + last = latest; \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'regl' - possible side-effects? #15574: FILE: drivers/net/txgbe/base/txgbe_regs.h:1733: +#define TXGBE_UPDCNT36(regl, last, cur) \ +do { \ + uint64_t new_lsb = rd32(hw, regl); \ + uint64_t new_msb = rd32(hw, regl + 4); \ + uint64_t latest = ((new_msb << 32) | new_lsb); \ + if (hw->offset_loaded | hw->rx_loaded) \ + last = 0; \ + cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \ + last = latest; \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects? #15574: FILE: drivers/net/txgbe/base/txgbe_regs.h:1733: +#define TXGBE_UPDCNT36(regl, last, cur) \ +do { \ + uint64_t new_lsb = rd32(hw, regl); \ + uint64_t new_msb = rd32(hw, regl + 4); \ + uint64_t latest = ((new_msb << 32) | new_lsb); \ + if (hw->offset_loaded | hw->rx_loaded) \ + last = 0; \ + cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \ + last = latest; \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues #15574: FILE: drivers/net/txgbe/base/txgbe_regs.h:1733: +#define TXGBE_UPDCNT36(regl, last, cur) \ +do { \ + uint64_t new_lsb = rd32(hw, regl); \ + uint64_t new_msb = rd32(hw, regl + 4); \ + uint64_t latest = ((new_msb << 32) | new_lsb); \ + if (hw->offset_loaded | hw->rx_loaded) \ + last = 0; \ + cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \ + last = latest; \ +} while (0) WARNING:RETURN_VOID: void function return statements are not generally useful #15642: FILE: drivers/net/txgbe/base/txgbe_regs.h:1801: + return; +} WARNING:BRACES: braces {} are not necessary for single statement blocks #15707: FILE: drivers/net/txgbe/base/txgbe_regs.h:1866: + if (value == expect) { + break; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #15714: FILE: drivers/net/txgbe/base/txgbe_regs.h:1873: + if (actual) { + *actual = all; + } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #15729: FILE: drivers/net/txgbe/base/txgbe_regs.h:1888: +#define rd32at(hw, reg, idx) \ + rd32a(hw, txgbe_map_reg(hw, reg), idx) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #15731: FILE: drivers/net/txgbe/base/txgbe_regs.h:1890: +#define wr32at(hw, reg, idx, val) \ + wr32a(hw, txgbe_map_reg(hw, reg), idx, val) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #15734: FILE: drivers/net/txgbe/base/txgbe_regs.h:1893: +#define rd32w(hw, reg, mask, slice) do { \ + rd32((hw), reg); \ + po32m((hw), reg, mask, mask, NULL, 5, slice); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects? #15734: FILE: drivers/net/txgbe/base/txgbe_regs.h:1893: +#define rd32w(hw, reg, mask, slice) do { \ + rd32((hw), reg); \ + po32m((hw), reg, mask, mask, NULL, 5, slice); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects? #15734: FILE: drivers/net/txgbe/base/txgbe_regs.h:1893: +#define rd32w(hw, reg, mask, slice) do { \ + rd32((hw), reg); \ + po32m((hw), reg, mask, mask, NULL, 5, slice); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #15739: FILE: drivers/net/txgbe/base/txgbe_regs.h:1898: +#define wr32w(hw, reg, val, mask, slice) do { \ + wr32((hw), reg, val); \ + po32m((hw), reg, mask, mask, NULL, 5, slice); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects? #15739: FILE: drivers/net/txgbe/base/txgbe_regs.h:1898: +#define wr32w(hw, reg, val, mask, slice) do { \ + wr32((hw), reg, val); \ + po32m((hw), reg, mask, mask, NULL, 5, slice); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects? #15739: FILE: drivers/net/txgbe/base/txgbe_regs.h:1898: +#define wr32w(hw, reg, val, mask, slice) do { \ + wr32((hw), reg, val); \ + po32m((hw), reg, mask, mask, NULL, 5, slice); \ +} while (0) WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'? #15871: FILE: drivers/net/txgbe/base/txgbe_status.h:85: +#define TXGBE_ERR_MASTER_REQUESTS_PENDING -(TERR_BASE + 12) WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'? #15956: FILE: drivers/net/txgbe/base/txgbe_type.h:42: +#define TXGBE_PCI_MASTER_DISABLE_TIMEOUT 800 WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16280: FILE: drivers/net/txgbe/base/txgbe_type.h:366: + s32 (*get_bus_info)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16281: FILE: drivers/net/txgbe/base/txgbe_type.h:367: + void (*set_lan_id)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16455: FILE: drivers/net/txgbe/base/txgbe_type.h:541: + s32 (*read_link)(struct txgbe_hw *, u8 addr, u16 reg, u16 *val); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16456: FILE: drivers/net/txgbe/base/txgbe_type.h:542: + s32 (*read_link_unlocked)(struct txgbe_hw *, u8 addr, u16 reg, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16458: FILE: drivers/net/txgbe/base/txgbe_type.h:544: + s32 (*write_link)(struct txgbe_hw *, u8 addr, u16 reg, u16 val); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16459: FILE: drivers/net/txgbe/base/txgbe_type.h:545: + s32 (*write_link_unlocked)(struct txgbe_hw *, u8 addr, u16 reg, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16466: FILE: drivers/net/txgbe/base/txgbe_type.h:552: + s32 (*init_params)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16467: FILE: drivers/net/txgbe/base/txgbe_type.h:553: + s32 (*read16)(struct txgbe_hw *, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16467: FILE: drivers/net/txgbe/base/txgbe_type.h:553: + s32 (*read16)(struct txgbe_hw *, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #16467: FILE: drivers/net/txgbe/base/txgbe_type.h:553: + s32 (*read16)(struct txgbe_hw *, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16468: FILE: drivers/net/txgbe/base/txgbe_type.h:554: + s32 (*readw_sw)(struct txgbe_hw *, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16468: FILE: drivers/net/txgbe/base/txgbe_type.h:554: + s32 (*readw_sw)(struct txgbe_hw *, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #16468: FILE: drivers/net/txgbe/base/txgbe_type.h:554: + s32 (*readw_sw)(struct txgbe_hw *, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16469: FILE: drivers/net/txgbe/base/txgbe_type.h:555: + s32 (*readw_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16469: FILE: drivers/net/txgbe/base/txgbe_type.h:555: + s32 (*readw_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16469: FILE: drivers/net/txgbe/base/txgbe_type.h:555: + s32 (*readw_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name #16469: FILE: drivers/net/txgbe/base/txgbe_type.h:555: + s32 (*readw_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16470: FILE: drivers/net/txgbe/base/txgbe_type.h:556: + s32 (*read32)(struct txgbe_hw *, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16470: FILE: drivers/net/txgbe/base/txgbe_type.h:556: + s32 (*read32)(struct txgbe_hw *, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16470: FILE: drivers/net/txgbe/base/txgbe_type.h:556: + s32 (*read32)(struct txgbe_hw *, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16471: FILE: drivers/net/txgbe/base/txgbe_type.h:557: + s32 (*read_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16471: FILE: drivers/net/txgbe/base/txgbe_type.h:557: + s32 (*read_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16471: FILE: drivers/net/txgbe/base/txgbe_type.h:557: + s32 (*read_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name #16471: FILE: drivers/net/txgbe/base/txgbe_type.h:557: + s32 (*read_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16472: FILE: drivers/net/txgbe/base/txgbe_type.h:558: + s32 (*write16)(struct txgbe_hw *, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16472: FILE: drivers/net/txgbe/base/txgbe_type.h:558: + s32 (*write16)(struct txgbe_hw *, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16472: FILE: drivers/net/txgbe/base/txgbe_type.h:558: + s32 (*write16)(struct txgbe_hw *, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16473: FILE: drivers/net/txgbe/base/txgbe_type.h:559: + s32 (*writew_sw)(struct txgbe_hw *, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16473: FILE: drivers/net/txgbe/base/txgbe_type.h:559: + s32 (*writew_sw)(struct txgbe_hw *, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16473: FILE: drivers/net/txgbe/base/txgbe_type.h:559: + s32 (*writew_sw)(struct txgbe_hw *, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16474: FILE: drivers/net/txgbe/base/txgbe_type.h:560: + s32 (*writew_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16474: FILE: drivers/net/txgbe/base/txgbe_type.h:560: + s32 (*writew_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16474: FILE: drivers/net/txgbe/base/txgbe_type.h:560: + s32 (*writew_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name #16474: FILE: drivers/net/txgbe/base/txgbe_type.h:560: + s32 (*writew_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16475: FILE: drivers/net/txgbe/base/txgbe_type.h:561: + s32 (*write32)(struct txgbe_hw *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16475: FILE: drivers/net/txgbe/base/txgbe_type.h:561: + s32 (*write32)(struct txgbe_hw *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16475: FILE: drivers/net/txgbe/base/txgbe_type.h:561: + s32 (*write32)(struct txgbe_hw *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16476: FILE: drivers/net/txgbe/base/txgbe_type.h:562: + s32 (*write_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16476: FILE: drivers/net/txgbe/base/txgbe_type.h:562: + s32 (*write_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16476: FILE: drivers/net/txgbe/base/txgbe_type.h:562: + s32 (*write_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name #16476: FILE: drivers/net/txgbe/base/txgbe_type.h:562: + s32 (*write_buffer)(struct txgbe_hw *, u32, u32, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16477: FILE: drivers/net/txgbe/base/txgbe_type.h:563: + s32 (*validate_checksum)(struct txgbe_hw *, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #16477: FILE: drivers/net/txgbe/base/txgbe_type.h:563: + s32 (*validate_checksum)(struct txgbe_hw *, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16478: FILE: drivers/net/txgbe/base/txgbe_type.h:564: + s32 (*update_checksum)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16479: FILE: drivers/net/txgbe/base/txgbe_type.h:565: + s32 (*calc_checksum)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16493: FILE: drivers/net/txgbe/base/txgbe_type.h:579: + s32 (*init_params)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16494: FILE: drivers/net/txgbe/base/txgbe_type.h:580: + s32 (*read_buffer)(struct txgbe_hw *, u32, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16494: FILE: drivers/net/txgbe/base/txgbe_type.h:580: + s32 (*read_buffer)(struct txgbe_hw *, u32, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16494: FILE: drivers/net/txgbe/base/txgbe_type.h:580: + s32 (*read_buffer)(struct txgbe_hw *, u32, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16494: FILE: drivers/net/txgbe/base/txgbe_type.h:580: + s32 (*read_buffer)(struct txgbe_hw *, u32, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16495: FILE: drivers/net/txgbe/base/txgbe_type.h:581: + s32 (*write_buffer)(struct txgbe_hw *, u32, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16495: FILE: drivers/net/txgbe/base/txgbe_type.h:581: + s32 (*write_buffer)(struct txgbe_hw *, u32, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16495: FILE: drivers/net/txgbe/base/txgbe_type.h:581: + s32 (*write_buffer)(struct txgbe_hw *, u32, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16495: FILE: drivers/net/txgbe/base/txgbe_type.h:581: + s32 (*write_buffer)(struct txgbe_hw *, u32, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16503: FILE: drivers/net/txgbe/base/txgbe_type.h:589: + s32 (*init_hw)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16504: FILE: drivers/net/txgbe/base/txgbe_type.h:590: + s32 (*reset_hw)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16505: FILE: drivers/net/txgbe/base/txgbe_type.h:591: + s32 (*start_hw)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16506: FILE: drivers/net/txgbe/base/txgbe_type.h:592: + s32 (*stop_hw)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16507: FILE: drivers/net/txgbe/base/txgbe_type.h:593: + s32 (*clear_hw_cntrs)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16508: FILE: drivers/net/txgbe/base/txgbe_type.h:594: + void (*enable_relaxed_ordering)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16509: FILE: drivers/net/txgbe/base/txgbe_type.h:595: + u64 (*get_supported_physical_layer)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16510: FILE: drivers/net/txgbe/base/txgbe_type.h:596: + s32 (*get_mac_addr)(struct txgbe_hw *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #16510: FILE: drivers/net/txgbe/base/txgbe_type.h:596: + s32 (*get_mac_addr)(struct txgbe_hw *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16511: FILE: drivers/net/txgbe/base/txgbe_type.h:597: + s32 (*get_san_mac_addr)(struct txgbe_hw *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #16511: FILE: drivers/net/txgbe/base/txgbe_type.h:597: + s32 (*get_san_mac_addr)(struct txgbe_hw *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16512: FILE: drivers/net/txgbe/base/txgbe_type.h:598: + s32 (*set_san_mac_addr)(struct txgbe_hw *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #16512: FILE: drivers/net/txgbe/base/txgbe_type.h:598: + s32 (*set_san_mac_addr)(struct txgbe_hw *, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16513: FILE: drivers/net/txgbe/base/txgbe_type.h:599: + s32 (*get_device_caps)(struct txgbe_hw *, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #16513: FILE: drivers/net/txgbe/base/txgbe_type.h:599: + s32 (*get_device_caps)(struct txgbe_hw *, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16514: FILE: drivers/net/txgbe/base/txgbe_type.h:600: + s32 (*get_wwn_prefix)(struct txgbe_hw *, u16 *, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #16514: FILE: drivers/net/txgbe/base/txgbe_type.h:600: + s32 (*get_wwn_prefix)(struct txgbe_hw *, u16 *, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #16514: FILE: drivers/net/txgbe/base/txgbe_type.h:600: + s32 (*get_wwn_prefix)(struct txgbe_hw *, u16 *, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16515: FILE: drivers/net/txgbe/base/txgbe_type.h:601: + s32 (*get_fcoe_boot_status)(struct txgbe_hw *, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #16515: FILE: drivers/net/txgbe/base/txgbe_type.h:601: + s32 (*get_fcoe_boot_status)(struct txgbe_hw *, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw*' should also have an identifier name #16516: FILE: drivers/net/txgbe/base/txgbe_type.h:602: + s32 (*read_analog_reg8)(struct txgbe_hw*, u32, u8*); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16516: FILE: drivers/net/txgbe/base/txgbe_type.h:602: + s32 (*read_analog_reg8)(struct txgbe_hw*, u32, u8*); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8*' should also have an identifier name #16516: FILE: drivers/net/txgbe/base/txgbe_type.h:602: + s32 (*read_analog_reg8)(struct txgbe_hw*, u32, u8*); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw*' should also have an identifier name #16517: FILE: drivers/net/txgbe/base/txgbe_type.h:603: + s32 (*write_analog_reg8)(struct txgbe_hw*, u32, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16517: FILE: drivers/net/txgbe/base/txgbe_type.h:603: + s32 (*write_analog_reg8)(struct txgbe_hw*, u32, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16517: FILE: drivers/net/txgbe/base/txgbe_type.h:603: + s32 (*write_analog_reg8)(struct txgbe_hw*, u32, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16518: FILE: drivers/net/txgbe/base/txgbe_type.h:604: + s32 (*setup_sfp)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16519: FILE: drivers/net/txgbe/base/txgbe_type.h:605: + s32 (*enable_rx_dma)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16519: FILE: drivers/net/txgbe/base/txgbe_type.h:605: + s32 (*enable_rx_dma)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16520: FILE: drivers/net/txgbe/base/txgbe_type.h:606: + s32 (*disable_sec_rx_path)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16521: FILE: drivers/net/txgbe/base/txgbe_type.h:607: + s32 (*enable_sec_rx_path)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16522: FILE: drivers/net/txgbe/base/txgbe_type.h:608: + s32 (*disable_sec_tx_path)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16523: FILE: drivers/net/txgbe/base/txgbe_type.h:609: + s32 (*enable_sec_tx_path)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16524: FILE: drivers/net/txgbe/base/txgbe_type.h:610: + s32 (*acquire_swfw_sync)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16524: FILE: drivers/net/txgbe/base/txgbe_type.h:610: + s32 (*acquire_swfw_sync)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16525: FILE: drivers/net/txgbe/base/txgbe_type.h:611: + void (*release_swfw_sync)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16525: FILE: drivers/net/txgbe/base/txgbe_type.h:611: + void (*release_swfw_sync)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16526: FILE: drivers/net/txgbe/base/txgbe_type.h:612: + void (*init_swfw_sync)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16527: FILE: drivers/net/txgbe/base/txgbe_type.h:613: + u64 (*autoc_read)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16528: FILE: drivers/net/txgbe/base/txgbe_type.h:614: + void (*autoc_write)(struct txgbe_hw *, u64); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u64' should also have an identifier name #16528: FILE: drivers/net/txgbe/base/txgbe_type.h:614: + void (*autoc_write)(struct txgbe_hw *, u64); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16529: FILE: drivers/net/txgbe/base/txgbe_type.h:615: + s32 (*prot_autoc_read)(struct txgbe_hw *, bool *, u64 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool *' should also have an identifier name #16529: FILE: drivers/net/txgbe/base/txgbe_type.h:615: + s32 (*prot_autoc_read)(struct txgbe_hw *, bool *, u64 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u64 *' should also have an identifier name #16529: FILE: drivers/net/txgbe/base/txgbe_type.h:615: + s32 (*prot_autoc_read)(struct txgbe_hw *, bool *, u64 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16530: FILE: drivers/net/txgbe/base/txgbe_type.h:616: + s32 (*prot_autoc_write)(struct txgbe_hw *, bool, u64); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16530: FILE: drivers/net/txgbe/base/txgbe_type.h:616: + s32 (*prot_autoc_write)(struct txgbe_hw *, bool, u64); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u64' should also have an identifier name #16530: FILE: drivers/net/txgbe/base/txgbe_type.h:616: + s32 (*prot_autoc_write)(struct txgbe_hw *, bool, u64); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16534: FILE: drivers/net/txgbe/base/txgbe_type.h:620: + void (*disable_tx_laser)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16535: FILE: drivers/net/txgbe/base/txgbe_type.h:621: + void (*enable_tx_laser)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16536: FILE: drivers/net/txgbe/base/txgbe_type.h:622: + void (*flap_tx_laser)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16537: FILE: drivers/net/txgbe/base/txgbe_type.h:623: + s32 (*setup_link)(struct txgbe_hw *, u32, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16537: FILE: drivers/net/txgbe/base/txgbe_type.h:623: + s32 (*setup_link)(struct txgbe_hw *, u32, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16537: FILE: drivers/net/txgbe/base/txgbe_type.h:623: + s32 (*setup_link)(struct txgbe_hw *, u32, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16538: FILE: drivers/net/txgbe/base/txgbe_type.h:624: + s32 (*setup_mac_link)(struct txgbe_hw *, u32, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16538: FILE: drivers/net/txgbe/base/txgbe_type.h:624: + s32 (*setup_mac_link)(struct txgbe_hw *, u32, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16538: FILE: drivers/net/txgbe/base/txgbe_type.h:624: + s32 (*setup_mac_link)(struct txgbe_hw *, u32, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16539: FILE: drivers/net/txgbe/base/txgbe_type.h:625: + s32 (*check_link)(struct txgbe_hw *, u32 *, bool *, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16539: FILE: drivers/net/txgbe/base/txgbe_type.h:625: + s32 (*check_link)(struct txgbe_hw *, u32 *, bool *, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool *' should also have an identifier name #16539: FILE: drivers/net/txgbe/base/txgbe_type.h:625: + s32 (*check_link)(struct txgbe_hw *, u32 *, bool *, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16539: FILE: drivers/net/txgbe/base/txgbe_type.h:625: + s32 (*check_link)(struct txgbe_hw *, u32 *, bool *, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16540: FILE: drivers/net/txgbe/base/txgbe_type.h:626: + s32 (*get_link_capabilities)(struct txgbe_hw *, u32 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16540: FILE: drivers/net/txgbe/base/txgbe_type.h:626: + s32 (*get_link_capabilities)(struct txgbe_hw *, u32 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool *' should also have an identifier name #16540: FILE: drivers/net/txgbe/base/txgbe_type.h:626: + s32 (*get_link_capabilities)(struct txgbe_hw *, u32 *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16542: FILE: drivers/net/txgbe/base/txgbe_type.h:628: + void (*set_rate_select_speed)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16542: FILE: drivers/net/txgbe/base/txgbe_type.h:628: + void (*set_rate_select_speed)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16545: FILE: drivers/net/txgbe/base/txgbe_type.h:631: + void (*setup_pba)(struct txgbe_hw *, int, u32, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #16545: FILE: drivers/net/txgbe/base/txgbe_type.h:631: + void (*setup_pba)(struct txgbe_hw *, int, u32, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16545: FILE: drivers/net/txgbe/base/txgbe_type.h:631: + void (*setup_pba)(struct txgbe_hw *, int, u32, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #16545: FILE: drivers/net/txgbe/base/txgbe_type.h:631: + void (*setup_pba)(struct txgbe_hw *, int, u32, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16548: FILE: drivers/net/txgbe/base/txgbe_type.h:634: + s32 (*led_on)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16548: FILE: drivers/net/txgbe/base/txgbe_type.h:634: + s32 (*led_on)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16549: FILE: drivers/net/txgbe/base/txgbe_type.h:635: + s32 (*led_off)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16549: FILE: drivers/net/txgbe/base/txgbe_type.h:635: + s32 (*led_off)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16550: FILE: drivers/net/txgbe/base/txgbe_type.h:636: + s32 (*blink_led_start)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16550: FILE: drivers/net/txgbe/base/txgbe_type.h:636: + s32 (*blink_led_start)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16551: FILE: drivers/net/txgbe/base/txgbe_type.h:637: + s32 (*blink_led_stop)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16551: FILE: drivers/net/txgbe/base/txgbe_type.h:637: + s32 (*blink_led_stop)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16552: FILE: drivers/net/txgbe/base/txgbe_type.h:638: + s32 (*init_led_link_act)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16555: FILE: drivers/net/txgbe/base/txgbe_type.h:641: + s32 (*set_rar)(struct txgbe_hw *, u32, u8 *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16555: FILE: drivers/net/txgbe/base/txgbe_type.h:641: + s32 (*set_rar)(struct txgbe_hw *, u32, u8 *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #16555: FILE: drivers/net/txgbe/base/txgbe_type.h:641: + s32 (*set_rar)(struct txgbe_hw *, u32, u8 *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16555: FILE: drivers/net/txgbe/base/txgbe_type.h:641: + s32 (*set_rar)(struct txgbe_hw *, u32, u8 *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16555: FILE: drivers/net/txgbe/base/txgbe_type.h:641: + s32 (*set_rar)(struct txgbe_hw *, u32, u8 *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16556: FILE: drivers/net/txgbe/base/txgbe_type.h:642: + s32 (*set_uc_addr)(struct txgbe_hw *, u32, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16556: FILE: drivers/net/txgbe/base/txgbe_type.h:642: + s32 (*set_uc_addr)(struct txgbe_hw *, u32, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #16556: FILE: drivers/net/txgbe/base/txgbe_type.h:642: + s32 (*set_uc_addr)(struct txgbe_hw *, u32, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16557: FILE: drivers/net/txgbe/base/txgbe_type.h:643: + s32 (*clear_rar)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16557: FILE: drivers/net/txgbe/base/txgbe_type.h:643: + s32 (*clear_rar)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16558: FILE: drivers/net/txgbe/base/txgbe_type.h:644: + s32 (*insert_mac_addr)(struct txgbe_hw *, u8 *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #16558: FILE: drivers/net/txgbe/base/txgbe_type.h:644: + s32 (*insert_mac_addr)(struct txgbe_hw *, u8 *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16558: FILE: drivers/net/txgbe/base/txgbe_type.h:644: + s32 (*insert_mac_addr)(struct txgbe_hw *, u8 *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16559: FILE: drivers/net/txgbe/base/txgbe_type.h:645: + s32 (*set_vmdq)(struct txgbe_hw *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16559: FILE: drivers/net/txgbe/base/txgbe_type.h:645: + s32 (*set_vmdq)(struct txgbe_hw *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16559: FILE: drivers/net/txgbe/base/txgbe_type.h:645: + s32 (*set_vmdq)(struct txgbe_hw *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16560: FILE: drivers/net/txgbe/base/txgbe_type.h:646: + s32 (*set_vmdq_san_mac)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16560: FILE: drivers/net/txgbe/base/txgbe_type.h:646: + s32 (*set_vmdq_san_mac)(struct txgbe_hw *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16561: FILE: drivers/net/txgbe/base/txgbe_type.h:647: + s32 (*clear_vmdq)(struct txgbe_hw *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16561: FILE: drivers/net/txgbe/base/txgbe_type.h:647: + s32 (*clear_vmdq)(struct txgbe_hw *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16561: FILE: drivers/net/txgbe/base/txgbe_type.h:647: + s32 (*clear_vmdq)(struct txgbe_hw *, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16562: FILE: drivers/net/txgbe/base/txgbe_type.h:648: + s32 (*init_rx_addrs)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16563: FILE: drivers/net/txgbe/base/txgbe_type.h:649: + s32 (*update_uc_addr_list)(struct txgbe_hw *, u8 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #16563: FILE: drivers/net/txgbe/base/txgbe_type.h:649: + s32 (*update_uc_addr_list)(struct txgbe_hw *, u8 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16563: FILE: drivers/net/txgbe/base/txgbe_type.h:649: + s32 (*update_uc_addr_list)(struct txgbe_hw *, u8 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'txgbe_mc_addr_itr' should also have an identifier name #16563: FILE: drivers/net/txgbe/base/txgbe_type.h:649: + s32 (*update_uc_addr_list)(struct txgbe_hw *, u8 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16565: FILE: drivers/net/txgbe/base/txgbe_type.h:651: + s32 (*update_mc_addr_list)(struct txgbe_hw *, u8 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #16565: FILE: drivers/net/txgbe/base/txgbe_type.h:651: + s32 (*update_mc_addr_list)(struct txgbe_hw *, u8 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16565: FILE: drivers/net/txgbe/base/txgbe_type.h:651: + s32 (*update_mc_addr_list)(struct txgbe_hw *, u8 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'txgbe_mc_addr_itr' should also have an identifier name #16565: FILE: drivers/net/txgbe/base/txgbe_type.h:651: + s32 (*update_mc_addr_list)(struct txgbe_hw *, u8 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16567: FILE: drivers/net/txgbe/base/txgbe_type.h:653: + s32 (*enable_mc)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16568: FILE: drivers/net/txgbe/base/txgbe_type.h:654: + s32 (*disable_mc)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16569: FILE: drivers/net/txgbe/base/txgbe_type.h:655: + s32 (*clear_vfta)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16570: FILE: drivers/net/txgbe/base/txgbe_type.h:656: + s32 (*set_vfta)(struct txgbe_hw *, u32, u32, bool, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16570: FILE: drivers/net/txgbe/base/txgbe_type.h:656: + s32 (*set_vfta)(struct txgbe_hw *, u32, u32, bool, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16570: FILE: drivers/net/txgbe/base/txgbe_type.h:656: + s32 (*set_vfta)(struct txgbe_hw *, u32, u32, bool, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16570: FILE: drivers/net/txgbe/base/txgbe_type.h:656: + s32 (*set_vfta)(struct txgbe_hw *, u32, u32, bool, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16570: FILE: drivers/net/txgbe/base/txgbe_type.h:656: + s32 (*set_vfta)(struct txgbe_hw *, u32, u32, bool, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16571: FILE: drivers/net/txgbe/base/txgbe_type.h:657: + s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16571: FILE: drivers/net/txgbe/base/txgbe_type.h:657: + s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16571: FILE: drivers/net/txgbe/base/txgbe_type.h:657: + s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16571: FILE: drivers/net/txgbe/base/txgbe_type.h:657: + s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16571: FILE: drivers/net/txgbe/base/txgbe_type.h:657: + s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16571: FILE: drivers/net/txgbe/base/txgbe_type.h:657: + s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16571: FILE: drivers/net/txgbe/base/txgbe_type.h:657: + s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16573: FILE: drivers/net/txgbe/base/txgbe_type.h:659: + s32 (*init_uta_tables)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16574: FILE: drivers/net/txgbe/base/txgbe_type.h:660: + void (*set_mac_anti_spoofing)(struct txgbe_hw *, bool, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16574: FILE: drivers/net/txgbe/base/txgbe_type.h:660: + void (*set_mac_anti_spoofing)(struct txgbe_hw *, bool, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #16574: FILE: drivers/net/txgbe/base/txgbe_type.h:660: + void (*set_mac_anti_spoofing)(struct txgbe_hw *, bool, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16575: FILE: drivers/net/txgbe/base/txgbe_type.h:661: + void (*set_vlan_anti_spoofing)(struct txgbe_hw *, bool, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16575: FILE: drivers/net/txgbe/base/txgbe_type.h:661: + void (*set_vlan_anti_spoofing)(struct txgbe_hw *, bool, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #16575: FILE: drivers/net/txgbe/base/txgbe_type.h:661: + void (*set_vlan_anti_spoofing)(struct txgbe_hw *, bool, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16576: FILE: drivers/net/txgbe/base/txgbe_type.h:662: + s32 (*update_xcast_mode)(struct txgbe_hw *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #16576: FILE: drivers/net/txgbe/base/txgbe_type.h:662: + s32 (*update_xcast_mode)(struct txgbe_hw *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16577: FILE: drivers/net/txgbe/base/txgbe_type.h:663: + s32 (*set_rlpml)(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16577: FILE: drivers/net/txgbe/base/txgbe_type.h:663: + s32 (*set_rlpml)(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16580: FILE: drivers/net/txgbe/base/txgbe_type.h:666: + s32 (*fc_enable)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16581: FILE: drivers/net/txgbe/base/txgbe_type.h:667: + s32 (*setup_fc)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16582: FILE: drivers/net/txgbe/base/txgbe_type.h:668: + void (*fc_autoneg)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16585: FILE: drivers/net/txgbe/base/txgbe_type.h:671: + s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16585: FILE: drivers/net/txgbe/base/txgbe_type.h:671: + s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16585: FILE: drivers/net/txgbe/base/txgbe_type.h:671: + s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16585: FILE: drivers/net/txgbe/base/txgbe_type.h:671: + s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16585: FILE: drivers/net/txgbe/base/txgbe_type.h:671: + s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16, WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16585: FILE: drivers/net/txgbe/base/txgbe_type.h:671: + s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16, WARNING:FUNCTION_ARGUMENTS: function definition argument 'const char *' should also have an identifier name #16585: FILE: drivers/net/txgbe/base/txgbe_type.h:671: + s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16587: FILE: drivers/net/txgbe/base/txgbe_type.h:673: + s32 (*get_thermal_sensor_data)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16592: FILE: drivers/net/txgbe/base/txgbe_type.h:678: + void (*set_source_address_pruning)(struct txgbe_hw *, bool, WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16592: FILE: drivers/net/txgbe/base/txgbe_type.h:678: + void (*set_source_address_pruning)(struct txgbe_hw *, bool, WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned int' should also have an identifier name #16592: FILE: drivers/net/txgbe/base/txgbe_type.h:678: + void (*set_source_address_pruning)(struct txgbe_hw *, bool, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16594: FILE: drivers/net/txgbe/base/txgbe_type.h:680: + void (*set_ethertype_anti_spoofing)(struct txgbe_hw *, bool, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16594: FILE: drivers/net/txgbe/base/txgbe_type.h:680: + void (*set_ethertype_anti_spoofing)(struct txgbe_hw *, bool, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #16594: FILE: drivers/net/txgbe/base/txgbe_type.h:680: + void (*set_ethertype_anti_spoofing)(struct txgbe_hw *, bool, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16599: FILE: drivers/net/txgbe/base/txgbe_type.h:685: + s32 (*read_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16599: FILE: drivers/net/txgbe/base/txgbe_type.h:685: + s32 (*read_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16599: FILE: drivers/net/txgbe/base/txgbe_type.h:685: + s32 (*read_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16599: FILE: drivers/net/txgbe/base/txgbe_type.h:685: + s32 (*read_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16600: FILE: drivers/net/txgbe/base/txgbe_type.h:686: + s32 (*write_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16600: FILE: drivers/net/txgbe/base/txgbe_type.h:686: + s32 (*write_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16600: FILE: drivers/net/txgbe/base/txgbe_type.h:686: + s32 (*write_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16600: FILE: drivers/net/txgbe/base/txgbe_type.h:686: + s32 (*write_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16639: FILE: drivers/net/txgbe/base/txgbe_type.h:725: + u32 (*get_media_type)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16640: FILE: drivers/net/txgbe/base/txgbe_type.h:726: + s32 (*identify)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16641: FILE: drivers/net/txgbe/base/txgbe_type.h:727: + s32 (*identify_sfp)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16642: FILE: drivers/net/txgbe/base/txgbe_type.h:728: + s32 (*init)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16643: FILE: drivers/net/txgbe/base/txgbe_type.h:729: + s32 (*reset)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16644: FILE: drivers/net/txgbe/base/txgbe_type.h:730: + s32 (*read_reg)(struct txgbe_hw *, u32, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16644: FILE: drivers/net/txgbe/base/txgbe_type.h:730: + s32 (*read_reg)(struct txgbe_hw *, u32, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16644: FILE: drivers/net/txgbe/base/txgbe_type.h:730: + s32 (*read_reg)(struct txgbe_hw *, u32, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #16644: FILE: drivers/net/txgbe/base/txgbe_type.h:730: + s32 (*read_reg)(struct txgbe_hw *, u32, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16645: FILE: drivers/net/txgbe/base/txgbe_type.h:731: + s32 (*write_reg)(struct txgbe_hw *, u32, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16645: FILE: drivers/net/txgbe/base/txgbe_type.h:731: + s32 (*write_reg)(struct txgbe_hw *, u32, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16645: FILE: drivers/net/txgbe/base/txgbe_type.h:731: + s32 (*write_reg)(struct txgbe_hw *, u32, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16645: FILE: drivers/net/txgbe/base/txgbe_type.h:731: + s32 (*write_reg)(struct txgbe_hw *, u32, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16646: FILE: drivers/net/txgbe/base/txgbe_type.h:732: + s32 (*read_reg_mdi)(struct txgbe_hw *, u32, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16646: FILE: drivers/net/txgbe/base/txgbe_type.h:732: + s32 (*read_reg_mdi)(struct txgbe_hw *, u32, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16646: FILE: drivers/net/txgbe/base/txgbe_type.h:732: + s32 (*read_reg_mdi)(struct txgbe_hw *, u32, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #16646: FILE: drivers/net/txgbe/base/txgbe_type.h:732: + s32 (*read_reg_mdi)(struct txgbe_hw *, u32, u32, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16647: FILE: drivers/net/txgbe/base/txgbe_type.h:733: + s32 (*write_reg_mdi)(struct txgbe_hw *, u32, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16647: FILE: drivers/net/txgbe/base/txgbe_type.h:733: + s32 (*write_reg_mdi)(struct txgbe_hw *, u32, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16647: FILE: drivers/net/txgbe/base/txgbe_type.h:733: + s32 (*write_reg_mdi)(struct txgbe_hw *, u32, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16647: FILE: drivers/net/txgbe/base/txgbe_type.h:733: + s32 (*write_reg_mdi)(struct txgbe_hw *, u32, u32, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16648: FILE: drivers/net/txgbe/base/txgbe_type.h:734: + s32 (*setup_link)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16649: FILE: drivers/net/txgbe/base/txgbe_type.h:735: + s32 (*setup_internal_link)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16650: FILE: drivers/net/txgbe/base/txgbe_type.h:736: + s32 (*setup_link_speed)(struct txgbe_hw *, u32, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #16650: FILE: drivers/net/txgbe/base/txgbe_type.h:736: + s32 (*setup_link_speed)(struct txgbe_hw *, u32, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name #16650: FILE: drivers/net/txgbe/base/txgbe_type.h:736: + s32 (*setup_link_speed)(struct txgbe_hw *, u32, bool); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16651: FILE: drivers/net/txgbe/base/txgbe_type.h:737: + s32 (*check_link)(struct txgbe_hw *, u32 *, bool *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16651: FILE: drivers/net/txgbe/base/txgbe_type.h:737: + s32 (*check_link)(struct txgbe_hw *, u32 *, bool *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool *' should also have an identifier name #16651: FILE: drivers/net/txgbe/base/txgbe_type.h:737: + s32 (*check_link)(struct txgbe_hw *, u32 *, bool *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16652: FILE: drivers/net/txgbe/base/txgbe_type.h:738: + s32 (*get_firmware_version)(struct txgbe_hw *, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16652: FILE: drivers/net/txgbe/base/txgbe_type.h:738: + s32 (*get_firmware_version)(struct txgbe_hw *, u32 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16653: FILE: drivers/net/txgbe/base/txgbe_type.h:739: + s32 (*read_i2c_byte)(struct txgbe_hw *, u8, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16653: FILE: drivers/net/txgbe/base/txgbe_type.h:739: + s32 (*read_i2c_byte)(struct txgbe_hw *, u8, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16653: FILE: drivers/net/txgbe/base/txgbe_type.h:739: + s32 (*read_i2c_byte)(struct txgbe_hw *, u8, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #16653: FILE: drivers/net/txgbe/base/txgbe_type.h:739: + s32 (*read_i2c_byte)(struct txgbe_hw *, u8, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16654: FILE: drivers/net/txgbe/base/txgbe_type.h:740: + s32 (*write_i2c_byte)(struct txgbe_hw *, u8, u8, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16654: FILE: drivers/net/txgbe/base/txgbe_type.h:740: + s32 (*write_i2c_byte)(struct txgbe_hw *, u8, u8, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16654: FILE: drivers/net/txgbe/base/txgbe_type.h:740: + s32 (*write_i2c_byte)(struct txgbe_hw *, u8, u8, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16654: FILE: drivers/net/txgbe/base/txgbe_type.h:740: + s32 (*write_i2c_byte)(struct txgbe_hw *, u8, u8, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16655: FILE: drivers/net/txgbe/base/txgbe_type.h:741: + s32 (*read_i2c_sff8472)(struct txgbe_hw *, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16655: FILE: drivers/net/txgbe/base/txgbe_type.h:741: + s32 (*read_i2c_sff8472)(struct txgbe_hw *, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #16655: FILE: drivers/net/txgbe/base/txgbe_type.h:741: + s32 (*read_i2c_sff8472)(struct txgbe_hw *, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16656: FILE: drivers/net/txgbe/base/txgbe_type.h:742: + s32 (*read_i2c_eeprom)(struct txgbe_hw *, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16656: FILE: drivers/net/txgbe/base/txgbe_type.h:742: + s32 (*read_i2c_eeprom)(struct txgbe_hw *, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #16656: FILE: drivers/net/txgbe/base/txgbe_type.h:742: + s32 (*read_i2c_eeprom)(struct txgbe_hw *, u8, u8 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16657: FILE: drivers/net/txgbe/base/txgbe_type.h:743: + s32 (*write_i2c_eeprom)(struct txgbe_hw *, u8, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16657: FILE: drivers/net/txgbe/base/txgbe_type.h:743: + s32 (*write_i2c_eeprom)(struct txgbe_hw *, u8, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name #16657: FILE: drivers/net/txgbe/base/txgbe_type.h:743: + s32 (*write_i2c_eeprom)(struct txgbe_hw *, u8, u8); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16658: FILE: drivers/net/txgbe/base/txgbe_type.h:744: + void (*i2c_bus_clear)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16659: FILE: drivers/net/txgbe/base/txgbe_type.h:745: + s32 (*check_overtemp)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16660: FILE: drivers/net/txgbe/base/txgbe_type.h:746: + s32 (*set_phy_power)(struct txgbe_hw *, bool on); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16661: FILE: drivers/net/txgbe/base/txgbe_type.h:747: + s32 (*enter_lplu)(struct txgbe_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16663: FILE: drivers/net/txgbe/base/txgbe_type.h:749: + s32 (*read_i2c_byte_unlocked)(struct txgbe_hw *, u8 offset, u8 addr, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16665: FILE: drivers/net/txgbe/base/txgbe_type.h:751: + s32 (*write_i2c_byte_unlocked)(struct txgbe_hw *, u8 offset, u8 addr, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16701: FILE: drivers/net/txgbe/base/txgbe_type.h:787: + s32 (*read)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16701: FILE: drivers/net/txgbe/base/txgbe_type.h:787: + s32 (*read)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16701: FILE: drivers/net/txgbe/base/txgbe_type.h:787: + s32 (*read)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16701: FILE: drivers/net/txgbe/base/txgbe_type.h:787: + s32 (*read)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16702: FILE: drivers/net/txgbe/base/txgbe_type.h:788: + s32 (*write)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16702: FILE: drivers/net/txgbe/base/txgbe_type.h:788: + s32 (*write)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16702: FILE: drivers/net/txgbe/base/txgbe_type.h:788: + s32 (*write)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16702: FILE: drivers/net/txgbe/base/txgbe_type.h:788: + s32 (*write)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16703: FILE: drivers/net/txgbe/base/txgbe_type.h:789: + s32 (*read_posted)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16703: FILE: drivers/net/txgbe/base/txgbe_type.h:789: + s32 (*read_posted)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16703: FILE: drivers/net/txgbe/base/txgbe_type.h:789: + s32 (*read_posted)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16703: FILE: drivers/net/txgbe/base/txgbe_type.h:789: + s32 (*read_posted)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16704: FILE: drivers/net/txgbe/base/txgbe_type.h:790: + s32 (*write_posted)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name #16704: FILE: drivers/net/txgbe/base/txgbe_type.h:790: + s32 (*write_posted)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16704: FILE: drivers/net/txgbe/base/txgbe_type.h:790: + s32 (*write_posted)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16704: FILE: drivers/net/txgbe/base/txgbe_type.h:790: + s32 (*write_posted)(struct txgbe_hw *, u32 *, u16, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16705: FILE: drivers/net/txgbe/base/txgbe_type.h:791: + s32 (*check_for_msg)(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16705: FILE: drivers/net/txgbe/base/txgbe_type.h:791: + s32 (*check_for_msg)(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16706: FILE: drivers/net/txgbe/base/txgbe_type.h:792: + s32 (*check_for_ack)(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16706: FILE: drivers/net/txgbe/base/txgbe_type.h:792: + s32 (*check_for_ack)(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name #16707: FILE: drivers/net/txgbe/base/txgbe_type.h:793: + s32 (*check_for_rst)(struct txgbe_hw *, u16); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #16707: FILE: drivers/net/txgbe/base/txgbe_type.h:793: + s32 (*check_for_rst)(struct txgbe_hw *, u16); WARNING:TYPO_SPELLING: 'reseting' may be misspelled - perhaps 'resetting'? #16905: FILE: drivers/net/txgbe/base/txgbe_vf.c:117: + * Resets the hardware by reseting the transmit and receive units, masks and WARNING:BRACES: braces {} are not necessary for single statement blocks #17010: FILE: drivers/net/txgbe/base/txgbe_vf.c:222: + for (i = 0; i < hw->mac.max_rx_queues; i++) { + wr32m(hw, TXGBE_RXCFG(i), TXGBE_RXCFG_ENA, 0); + } WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment #17168: FILE: drivers/net/txgbe/base/txgbe_vf.c:380: + /* Fall through */ CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #17470: FILE: drivers/net/txgbe/base/txgbe_vf.c:682: + msg[1] = msg[2] = msg[3] = msg[4] = 0; WARNING:FUNCTION_ARGUMENTS: function definition argument 'txgbe_mc_addr_itr' should also have an identifier name #17571: FILE: drivers/net/txgbe/base/txgbe_vf.h:58: +s32 txgbe_update_mc_addr_list_vf(struct txgbe_hw *hw, u8 *mc_addr_list, CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf >= pci_dev->max_vfs' #17872: FILE: drivers/net/txgbe/rte_pmd_txgbe.c:251: + if ((vf >= pci_dev->max_vfs) || (vf > 63)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf > 63' #17872: FILE: drivers/net/txgbe/rte_pmd_txgbe.c:251: + if ((vf >= pci_dev->max_vfs) || (vf > 63)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vlan > RTE_ETHER_MAX_VLAN_ID' #18099: FILE: drivers/net/txgbe/rte_pmd_txgbe.c:478: + if ((vlan > RTE_ETHER_MAX_VLAN_ID) || (vf_mask == 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf_mask == 0' #18099: FILE: drivers/net/txgbe/rte_pmd_txgbe.c:478: + if ((vlan > RTE_ETHER_MAX_VLAN_ID) || (vf_mask == 0)) WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #18898: FILE: drivers/net/txgbe/rte_pmd_txgbe.h:279: +/** +* Set RX L2 Filtering mode of a VF of an Ethernet device. WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #18924: FILE: drivers/net/txgbe/rte_pmd_txgbe.h:305: +/** +* Enable or disable a VF traffic receive of an Ethernet device. WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #18943: FILE: drivers/net/txgbe/rte_pmd_txgbe.h:324: +/** +* Enable or disable a VF traffic transmit of the Ethernet device. WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #18962: FILE: drivers/net/txgbe/rte_pmd_txgbe.h:343: +/** +* Enable/Disable hardware VF VLAN filtering by an Ethernet device of CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #19296: FILE: drivers/net/txgbe/rte_pmd_txgbe.h:677: +#define RTE_PMD_TXGBE_BYPASS_MODE_VALID(x) \ + ((x) > RTE_PMD_TXGBE_BYPASS_MODE_NONE && \ + (x) < RTE_PMD_TXGBE_BYPASS_MODE_NUM) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #19311: FILE: drivers/net/txgbe/rte_pmd_txgbe.h:692: +#define RTE_PMD_TXGBE_BYPASS_EVENT_VALID(x) \ + ((x) > RTE_PMD_TXGBE_BYPASS_EVENT_NONE && \ + (x) < RTE_PMD_TXGBE_BYPASS_MODE_NUM) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #19327: FILE: drivers/net/txgbe/rte_pmd_txgbe.h:708: +#define RTE_PMD_TXGBE_BYPASS_TMT_VALID(x) \ + ((x) == RTE_PMD_TXGBE_BYPASS_TMT_OFF || \ + ((x) > RTE_PMD_TXGBE_BYPASS_TMT_OFF && \ + (x) < RTE_PMD_TXGBE_BYPASS_TMT_NUM)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects? #19572: FILE: drivers/net/txgbe/txgbe_ethdev.c:169: +#define TXGBE_SET_HWSTRIP(h, q) do {\ + uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \ + uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \ + (h)->bitmap[idx] |= 1 << bit;\ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects? #19578: FILE: drivers/net/txgbe/txgbe_ethdev.c:175: +#define TXGBE_CLEAR_HWSTRIP(h, q) do {\ + uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \ + uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \ + (h)->bitmap[idx] &= ~(1 << bit);\ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects? #19584: FILE: drivers/net/txgbe/txgbe_ethdev.c:181: +#define TXGBE_GET_HWSTRIP(h, q, r) do {\ + uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \ + uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \ + (r) = (h)->bitmap[idx] >> bit & 1;\ + } while (0) WARNING:BRACES: braces {} are not necessary for single statement blocks #19916: FILE: drivers/net/txgbe/txgbe_ethdev.c:513: + if (hw->mac.acquire_swfw_sync(hw, mask) < 0) { + PMD_DRV_LOG(DEBUG, "SWFW common locks released"); + } CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #19959: FILE: drivers/net/txgbe/txgbe_ethdev.c:556: + txq = eth_dev->data->tx_queues[eth_dev->data->nb_tx_queues-1]; ^ WARNING:BRACES: braces {} are not necessary for single statement blocks #19984: FILE: drivers/net/txgbe/txgbe_ethdev.c:581: + if (mz == NULL) { + return -ENOMEM; + } CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == txgbe_media_type_copper' #20053: FILE: drivers/net/txgbe/txgbe_ethdev.c:650: + if (err && (hw->phy.media_type == txgbe_media_type_copper)) { CHECK:BRACES: braces {} should be used on all arms of this statement #20061: FILE: drivers/net/txgbe/txgbe_ethdev.c:658: + if (err == TXGBE_ERR_EEPROM_VERSION) { [...] + } else if (err == TXGBE_ERR_SFP_NOT_SUPPORTED) [...] CHECK:SPACING: No space is necessary after a cast #20134: FILE: drivers/net/txgbe/txgbe_ethdev.c:731: + (int)hw->mac.type, (int) hw->phy.type); WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16) #20209: FILE: drivers/net/txgbe/txgbe_ethdev.c:806: + if (fdir_info->hash_map) + rte_free(fdir_info->hash_map); CHECK:BRACES: braces {} should be used on all arms of this statement #20325: FILE: drivers/net/txgbe/txgbe_ethdev.c:922: + if (pci_dev->device.devargs) { [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #20330: FILE: drivers/net/txgbe/txgbe_ethdev.c:927: + } else WARNING:BRACES: braces {} are not necessary for any arm of this statement #20663: FILE: drivers/net/txgbe/txgbe_ethdev.c:1260: + if (rxq->offloads & DEV_RX_OFFLOAD_VLAN_STRIP) { [...] + } else { [...] WARNING:BRACES: braces {} are not necessary for single statement blocks #20699: FILE: drivers/net/txgbe/txgbe_ethdev.c:1296: + if (mask & ETH_VLAN_STRIP_MASK) { + txgbe_vlan_hw_strip_config(dev); + } WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_dev_start', this function's name, in a string #21273: FILE: drivers/net/txgbe/txgbe_ethdev.c:1870: + PMD_INIT_LOG(ERR, "failure in txgbe_dev_start(): %d", err); CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last_counter' - possible side-effects? #21497: FILE: drivers/net/txgbe/txgbe_ethdev.c:2094: +#define UPDATE_QP_COUNTER_32bit(reg, last_counter, counter) \ + { \ + uint32_t current_counter = rd32(hw, reg); \ + if (current_counter < last_counter) \ + current_counter += 0x100000000LL; \ + if (!hw->offset_loaded) \ + last_counter = current_counter; \ + counter = current_counter - last_counter; \ + counter &= 0xFFFFFFFFLL; \ + } CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last_counter' may be better as '(last_counter)' to avoid precedence issues #21497: FILE: drivers/net/txgbe/txgbe_ethdev.c:2094: +#define UPDATE_QP_COUNTER_32bit(reg, last_counter, counter) \ + { \ + uint32_t current_counter = rd32(hw, reg); \ + if (current_counter < last_counter) \ + current_counter += 0x100000000LL; \ + if (!hw->offset_loaded) \ + last_counter = current_counter; \ + counter = current_counter - last_counter; \ + counter &= 0xFFFFFFFFLL; \ + } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'counter' - possible side-effects? #21497: FILE: drivers/net/txgbe/txgbe_ethdev.c:2094: +#define UPDATE_QP_COUNTER_32bit(reg, last_counter, counter) \ + { \ + uint32_t current_counter = rd32(hw, reg); \ + if (current_counter < last_counter) \ + current_counter += 0x100000000LL; \ + if (!hw->offset_loaded) \ + last_counter = current_counter; \ + counter = current_counter - last_counter; \ + counter &= 0xFFFFFFFFLL; \ + } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last_counter' - possible side-effects? #21508: FILE: drivers/net/txgbe/txgbe_ethdev.c:2105: +#define UPDATE_QP_COUNTER_36bit(reg_lsb, reg_msb, last_counter, counter) \ + { \ + uint64_t current_counter_lsb = rd32(hw, reg_lsb); \ + uint64_t current_counter_msb = rd32(hw, reg_msb); \ + uint64_t current_counter = (current_counter_msb << 32) | \ + current_counter_lsb; \ + if (current_counter < last_counter) \ + current_counter += 0x1000000000LL; \ + if (!hw->offset_loaded) \ + last_counter = current_counter; \ + counter = current_counter - last_counter; \ + counter &= 0xFFFFFFFFFLL; \ + } CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last_counter' may be better as '(last_counter)' to avoid precedence issues #21508: FILE: drivers/net/txgbe/txgbe_ethdev.c:2105: +#define UPDATE_QP_COUNTER_36bit(reg_lsb, reg_msb, last_counter, counter) \ + { \ + uint64_t current_counter_lsb = rd32(hw, reg_lsb); \ + uint64_t current_counter_msb = rd32(hw, reg_msb); \ + uint64_t current_counter = (current_counter_msb << 32) | \ + current_counter_lsb; \ + if (current_counter < last_counter) \ + current_counter += 0x1000000000LL; \ + if (!hw->offset_loaded) \ + last_counter = current_counter; \ + counter = current_counter - last_counter; \ + counter &= 0xFFFFFFFFFLL; \ + } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'counter' - possible side-effects? #21508: FILE: drivers/net/txgbe/txgbe_ethdev.c:2105: +#define UPDATE_QP_COUNTER_36bit(reg_lsb, reg_msb, last_counter, counter) \ + { \ + uint64_t current_counter_lsb = rd32(hw, reg_lsb); \ + uint64_t current_counter_msb = rd32(hw, reg_msb); \ + uint64_t current_counter = (current_counter_msb << 32) | \ + current_counter_lsb; \ + if (current_counter < last_counter) \ + current_counter += 0x1000000000LL; \ + if (!hw->offset_loaded) \ + last_counter = current_counter; \ + counter = current_counter - last_counter; \ + counter &= 0xFFFFFFFFFLL; \ + } WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #21527: FILE: drivers/net/txgbe/txgbe_ethdev.c:2124: + unsigned i; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #21838: FILE: drivers/net/txgbe/txgbe_ethdev.c:2435: + unsigned i, count; WARNING:BRACES: braces {} are not necessary for single statement blocks #21841: FILE: drivers/net/txgbe/txgbe_ethdev.c:2438: + if (xstats_names == NULL) { + return count; + } WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #21867: FILE: drivers/net/txgbe/txgbe_ethdev.c:2464: + unsigned i; WARNING:BRACES: braces {} are not necessary for single statement blocks #21869: FILE: drivers/net/txgbe/txgbe_ethdev.c:2466: + if (ids == NULL) { + return txgbe_dev_xstats_get_names(dev, xstats_names, limit); + } WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #21886: FILE: drivers/net/txgbe/txgbe_ethdev.c:2483: + unsigned limit) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #21890: FILE: drivers/net/txgbe/txgbe_ethdev.c:2487: + unsigned i, count; WARNING:BRACES: braces {} are not necessary for single statement blocks #21898: FILE: drivers/net/txgbe/txgbe_ethdev.c:2495: + if (xstats == NULL) { + return count; + } WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #21921: FILE: drivers/net/txgbe/txgbe_ethdev.c:2518: + unsigned limit) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #21925: FILE: drivers/net/txgbe/txgbe_ethdev.c:2522: + unsigned i, count; WARNING:BRACES: braces {} are not necessary for single statement blocks #21933: FILE: drivers/net/txgbe/txgbe_ethdev.c:2530: + if (values == NULL) { + return count; + } WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #21958: FILE: drivers/net/txgbe/txgbe_ethdev.c:2555: + unsigned i; WARNING:BRACES: braces {} are not necessary for single statement blocks #21960: FILE: drivers/net/txgbe/txgbe_ethdev.c:2557: + if (ids == NULL) { + return txgbe_dev_xstats_get_(dev, values, limit); + } WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #22384: FILE: drivers/net/txgbe/txgbe_ethdev.c:2981: + (unsigned)link.link_speed, CHECK:BRACES: Unbalanced braces around else statement #22450: FILE: drivers/net/txgbe/txgbe_ethdev.c:3047: + else { WARNING:TYPO_SPELLING: 'regsitered' may be misspelled - perhaps 'registered'? #22474: FILE: drivers/net/txgbe/txgbe_ethdev.c:3071: + * The address of parameter (struct rte_eth_dev *) regsitered before. WARNING:TYPO_SPELLING: 'regsitered' may be misspelled - perhaps 'registered'? #22530: FILE: drivers/net/txgbe/txgbe_ethdev.c:3127: + * The address of parameter (struct rte_eth_dev *) regsitered before. CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fc_conf->high_water > max_high_water' #22636: FILE: drivers/net/txgbe/txgbe_ethdev.c:3233: + if ((fc_conf->high_water > max_high_water) || + (fc_conf->high_water < fc_conf->low_water)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fc_conf->high_water < fc_conf->low_water' #22636: FILE: drivers/net/txgbe/txgbe_ethdev.c:3233: + if ((fc_conf->high_water > max_high_water) || + (fc_conf->high_water < fc_conf->low_water)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == 0' #22653: FILE: drivers/net/txgbe/txgbe_ethdev.c:3250: + if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == TXGBE_ERR_FC_NOT_NEGOTIATED' #22653: FILE: drivers/net/txgbe/txgbe_ethdev.c:3250: + if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pfc_conf->fc.high_water > max_high_water' #22695: FILE: drivers/net/txgbe/txgbe_ethdev.c:3292: + if ((pfc_conf->fc.high_water > max_high_water) || + (pfc_conf->fc.high_water <= pfc_conf->fc.low_water)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pfc_conf->fc.high_water <= pfc_conf->fc.low_water' #22695: FILE: drivers/net/txgbe/txgbe_ethdev.c:3292: + if ((pfc_conf->fc.high_water > max_high_water) || + (pfc_conf->fc.high_water <= pfc_conf->fc.low_water)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == 0' #22711: FILE: drivers/net/txgbe/txgbe_ethdev.c:3308: + if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == TXGBE_ERR_FC_NOT_NEGOTIATED' #22711: FILE: drivers/net/txgbe/txgbe_ethdev.c:3308: + if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #22847: FILE: drivers/net/txgbe/txgbe_ethdev.c:3444: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen' #22847: FILE: drivers/net/txgbe/txgbe_ethdev.c:3444: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) WARNING:BRACES: braces {} are not necessary for any arm of this statement #22957: FILE: drivers/net/txgbe/txgbe_ethdev.c:3554: + if (uta_info->uta_in_use > 0) { [...] + } else { [...] WARNING:BRACES: braces {} are not necessary for any arm of this statement #22994: FILE: drivers/net/txgbe/txgbe_ethdev.c:3591: + if (on) { [...] + } else { [...] CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #23298: FILE: drivers/net/txgbe/txgbe_ethdev.c:3895: + vec = base = TXGBE_RX_VEC_START; WARNING:TYPO_SPELLING: 'ponter' may be misspelled - perhaps 'pointer'? #23509: FILE: drivers/net/txgbe/txgbe_ethdev.c:4106: + * filter: ponter to the filter that will be added. CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'regs->length == 0' #24291: FILE: drivers/net/txgbe/txgbe_ethdev.c:4888: + if ((regs->length == 0) || + (regs->length == (uint32_t)txgbe_get_reg_length(dev))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'regs->length == (uint32_t)txgbe_get_reg_length(dev)' #24291: FILE: drivers/net/txgbe/txgbe_ethdev.c:4888: + if ((regs->length == 0) || + (regs->length == (uint32_t)txgbe_get_reg_length(dev))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'first > hw->rom.word_size' #24325: FILE: drivers/net/txgbe/txgbe_ethdev.c:4922: + if ((first > hw->rom.word_size) || + ((first + length) > hw->rom.word_size)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'first > hw->rom.word_size' #24345: FILE: drivers/net/txgbe/txgbe_ethdev.c:4942: + if ((first > hw->rom.word_size) || + ((first + length) > hw->rom.word_size)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!restore' #24823: FILE: drivers/net/txgbe/txgbe_ethdev.c:5420: + if ((!restore) && (ret < 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ret < 0' #24823: FILE: drivers/net/txgbe/txgbe_ethdev.c:5420: + if ((!restore) && (ret < 0)) WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #25886: FILE: drivers/net/txgbe/txgbe_ethdev.h:213: + uint8_t priority; /* seven levels (001b-111b), 111b is highest, + used when more than one filter matches. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #25886: FILE: drivers/net/txgbe/txgbe_ethdev.h:213: + used when more than one filter matches. */ WARNING:BRACES: braces {} are not necessary for single statement blocks #26383: FILE: drivers/net/txgbe/txgbe_ethdev.h:710: + if (filter_info->ethertype_mask & (1 << i)) { + continue; + } WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #26463: FILE: drivers/net/txgbe/txgbe_ethdev.h:790: + unsigned offset; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #26566: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:74: + struct rte_eth_xstat *xstats, unsigned n); WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test #26647: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:155: + if (0 == txgbevf_negotiate_api_version(hw, sup_ver[i])) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err != 0' #26752: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:260: + if ((err != 0) && (err != TXGBE_ERR_INVALID_MAC_ADDR)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err != TXGBE_ERR_INVALID_MAC_ADDR' #26752: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:260: + if ((err != 0) && (err != TXGBE_ERR_INVALID_MAC_ADDR)) { WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #26871: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:379: + struct rte_eth_xstat_name *xstats_names, unsigned limit) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #26873: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:381: + unsigned i; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #26892: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:400: + unsigned i; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #26923: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:431: + unsigned n) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #26927: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:435: + unsigned i; WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #27244: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:752: + /* + * Clear what we set, but we still keep shadow_vfta to WARNING:TYPO_SPELLING: 'retore' may be misspelled - perhaps 'restore'? #27358: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:866: + /* Save what we set and retore it after device reset */ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #27623: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:1131: + if ((mtu < RTE_ETHER_MIN_MTU) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN' #27623: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:1131: + if ((mtu < RTE_ETHER_MIN_MTU) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'regs->length == 0' #27677: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:1185: + if ((regs->length == 0) || + (regs->length == (uint32_t)txgbevf_get_reg_length(dev))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'regs->length == (uint32_t)txgbevf_get_reg_length(dev)' #27677: FILE: drivers/net/txgbe/txgbe_ethdev_vf.c:1185: + if ((regs->length == 0) || + (regs->length == (uint32_t)txgbevf_get_reg_length(dev))) { CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ipv6m' - possible side-effects? #27932: FILE: drivers/net/txgbe/txgbe_fdir.c:38: +#define IPV6_ADDR_TO_MASK(ipaddr, ipv6m) do { \ + uint8_t ipv6_addr[16]; \ + uint8_t i; \ + rte_memcpy(ipv6_addr, (ipaddr), sizeof(ipv6_addr));\ + (ipv6m) = 0; \ + for (i = 0; i < sizeof(ipv6_addr); i++) { \ + if (ipv6_addr[i] == UINT8_MAX) \ + (ipv6m) |= 1 << i; \ + else if (ipv6_addr[i] != 0) { \ + PMD_DRV_LOG(ERR, " invalid IPv6 address mask."); \ + return -EINVAL; \ + } \ + } \ +} while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #27932: FILE: drivers/net/txgbe/txgbe_fdir.c:38: +#define IPV6_ADDR_TO_MASK(ipaddr, ipv6m) do { \ + uint8_t ipv6_addr[16]; \ + uint8_t i; \ + rte_memcpy(ipv6_addr, (ipaddr), sizeof(ipv6_addr));\ + (ipv6m) = 0; \ + for (i = 0; i < sizeof(ipv6_addr); i++) { \ + if (ipv6_addr[i] == UINT8_MAX) \ + (ipv6m) |= 1 << i; \ + else if (ipv6_addr[i] != 0) { \ + PMD_DRV_LOG(ERR, " invalid IPv6 address mask."); \ + return -EINVAL; \ + } \ + } \ +} while (0) CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #27964: FILE: drivers/net/txgbe/txgbe_fdir.c:70: +static int txgbe_fdir_filter_to_atr_input( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #28167: FILE: drivers/net/txgbe/txgbe_fdir.c:273: + fdirtcpm = reverse_fdir_bitmasks( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'flex_cfg->src_offset[0] <= TXGBE_MAX_FLX_SOURCE_OFF' #28281: FILE: drivers/net/txgbe/txgbe_fdir.c:387: + if (((flex_cfg->src_offset[0] & 0x1) == 0) && + (flex_cfg->src_offset[1] == flex_cfg->src_offset[0] + 1) && + (flex_cfg->src_offset[0] <= TXGBE_MAX_FLX_SOURCE_OFF)) { CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #28285: FILE: drivers/net/txgbe/txgbe_fdir.c:391: + flex |= TXGBE_FDIRFLEXCFG_OFST( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #28399: FILE: drivers/net/txgbe/txgbe_fdir.c:505: + input->flex_bytes = (uint16_t)( WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment #28448: FILE: drivers/net/txgbe/txgbe_fdir.c:554: + /* fall-through */ WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment #28464: FILE: drivers/net/txgbe/txgbe_fdir.c:570: + /* fall-through */ WARNING:BRACES: braces {} are not necessary for single statement blocks #28835: FILE: drivers/net/txgbe/txgbe_fdir.c:941: + if (ret < 0) { + return ret; + } CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #29126: FILE: drivers/net/txgbe/txgbe_fdir.c:1232: + +} CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #29345: FILE: drivers/net/txgbe/txgbe_flow.c:104: +const struct rte_flow_item *next_no_void_pattern( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #29359: FILE: drivers/net/txgbe/txgbe_flow.c:118: +const struct rte_flow_action *next_no_void_action( WARNING:TYPO_SPELLING: 'asumption' may be misspelled - perhaps 'assumption'? #29373: FILE: drivers/net/txgbe/txgbe_flow.c:132: + * Please aware there's an asumption for all the parsers. CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #29512: FILE: drivers/net/txgbe/txgbe_flow.c:271: + + } WARNING:TABSTOP: Statements should start on a tabstop #29531: FILE: drivers/net/txgbe/txgbe_flow.c:290: + return -rte_errno; CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #29552: FILE: drivers/net/txgbe/txgbe_flow.c:311: + sizeof(struct rte_flow_item_vlan)))) { + CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'item->type != RTE_FLOW_ITEM_TYPE_END' #29636: FILE: drivers/net/txgbe/txgbe_flow.c:395: + if ((item->type != RTE_FLOW_ITEM_TYPE_END) && + (!item->spec && !item->mask)) { CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #29659: FILE: drivers/net/txgbe/txgbe_flow.c:418: + + } WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #29841: FILE: drivers/net/txgbe/txgbe_flow.c:600: + if (attr->priority < TXGBE_MIN_N_TUPLE_PRIO || [...] + filter->priority = 1; CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'act->type != RTE_FLOW_ACTION_TYPE_MARK' #30679: FILE: drivers/net/txgbe/txgbe_flow.c:1438: + if ((act->type != RTE_FLOW_ACTION_TYPE_MARK) && + (act->type != RTE_FLOW_ACTION_TYPE_END)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'act->type != RTE_FLOW_ACTION_TYPE_END' #30679: FILE: drivers/net/txgbe/txgbe_flow.c:1438: + if ((act->type != RTE_FLOW_ACTION_TYPE_MARK) && + (act->type != RTE_FLOW_ACTION_TYPE_END)) { CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #30710: FILE: drivers/net/txgbe/txgbe_flow.c:1469: +const struct rte_flow_item *next_no_fuzzy_pattern( CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #30913: FILE: drivers/net/txgbe/txgbe_flow.c:1672: + if (item->mask) { + CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #31204: FILE: drivers/net/txgbe/txgbe_flow.c:1963: + + } CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #31264: FILE: drivers/net/txgbe/txgbe_flow.c:2023: + + } CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'item->type != RTE_FLOW_ITEM_TYPE_VLAN' #31690: FILE: drivers/net/txgbe/txgbe_flow.c:2449: + if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) && + (item->type != RTE_FLOW_ITEM_TYPE_IPV4)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'item->type != RTE_FLOW_ITEM_TYPE_IPV4' #31690: FILE: drivers/net/txgbe/txgbe_flow.c:2449: + if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) && + (item->type != RTE_FLOW_ITEM_TYPE_IPV4)) { CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #32036: FILE: drivers/net/txgbe/txgbe_flow.c:2795: + ethertype_filter_ptr = rte_zmalloc( WARNING:TYPO_SPELLING: 'checkes' may be misspelled - perhaps 'checks'? #32214: FILE: drivers/net/txgbe/txgbe_flow.c:2973: + * It only checkes the format. Don't guarantee the rule can be programmed into CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects? #32457: FILE: drivers/net/txgbe/txgbe_ipsec.c:18: +#define CMP_IP(a, b) (\ + (a).ipv6[0] == (b).ipv6[0] && \ + (a).ipv6[1] == (b).ipv6[1] && \ + (a).ipv6[2] == (b).ipv6[2] && \ + (a).ipv6[3] == (b).ipv6[3]) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects? #32457: FILE: drivers/net/txgbe/txgbe_ipsec.c:18: +#define CMP_IP(a, b) (\ + (a).ipv6[0] == (b).ipv6[0] && \ + (a).ipv6[1] == (b).ipv6[1] && \ + (a).ipv6[2] == (b).ipv6[2] && \ + (a).ipv6[3] == (b).ipv6[3]) CHECK:CAMELCASE: Avoid CamelCase: #32581: FILE: drivers/net/txgbe/txgbe_ipsec.c:142: + if (ic_session->dst_ip.type == IPv6) { CHECK:CAMELCASE: Avoid CamelCase: #32584: FILE: drivers/net/txgbe/txgbe_ipsec.c:145: + } else if (ic_session->dst_ip.type == IPv4) { CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line #33108: FILE: drivers/net/txgbe/txgbe_ipsec.c:669: + struct txgbe_crypto_session *ic_session + = get_sec_session_private_data(sess); WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop #33374: FILE: drivers/net/txgbe/txgbe_logs.h:85: +#define wjmsg_line(fmt, ...) \ + do { \ + RTE_LOG(CRIT, PMD, "%s(%d): " fmt, \ + __FUNCTION__, __LINE__, ## __VA_ARGS__); \ + } while (0) WARNING:LEADING_SPACE: please, no spaces at the start of a line #33375: FILE: drivers/net/txgbe/txgbe_logs.h:86: + do { \$ WARNING:USE_FUNC: __func__ should be used instead of gcc specific __FUNCTION__ #33377: FILE: drivers/net/txgbe/txgbe_logs.h:88: + __FUNCTION__, __LINE__, ## __VA_ARGS__); \ WARNING:LEADING_SPACE: please, no spaces at the start of a line #33378: FILE: drivers/net/txgbe/txgbe_logs.h:89: + } while (0)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #33380: FILE: drivers/net/txgbe/txgbe_logs.h:91: + do { \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #33383: FILE: drivers/net/txgbe/txgbe_logs.h:94: + } while (0)$ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mb' - possible side-effects? #33386: FILE: drivers/net/txgbe/txgbe_logs.h:97: +#define wjdump(mb) { \ + int j; char buf[128] = ""; \ + wjmsg("data_len=%d pkt_len=%d vlan_tci=%d " \ + "packet_type=0x%08x ol_flags=0x%016lx " \ + "hash.rss=0x%08x hash.fdir.hash=0x%04x hash.fdir.id=%d ", \ + mb->data_len, mb->pkt_len, mb->vlan_tci, \ + mb->packet_type, mb->ol_flags, \ + mb->hash.rss, mb->hash.fdir.hash, mb->hash.fdir.id); \ + for (j = 0; j < mb->data_len; j++) { \ + sprintf(buf + strlen(buf), "%02x ", \ + ((uint8_t *)(mb->buf_addr) + mb->data_off)[j]); \ + if (j % 8 == 7) {\ + wjmsg("%s ", buf); \ + buf[0] = '