From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw76035 [PATCH 40/40] examples/pipeline: add VXLAN encap example
Date: Wed, 9 Sep 2020 01:17:59 +0200 (CEST) [thread overview]
Message-ID: <20200908231759.C8A681BE0C@dpdk.org> (raw)
In-Reply-To: <20200826151445.51500-41-cristian.dumitrescu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76035
_coding style issues_
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#102: FILE: examples/pipeline/cli.c:735:
+int pipeline_setup_vxlan(struct rte_swx_pipeline *p);
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#133: FILE: examples/pipeline/example_vxlan.c:13:
+#define CHECK(condition) \
+do { \
+ if (!(condition)) { \
+ printf("Error in function %s at line %d
", \
+ __FUNCTION__, __LINE__); \
+ return -1; \
+ } \
+} while (0)
WARNING:USE_FUNC: __func__ should be used instead of gcc specific __FUNCTION__
#137: FILE: examples/pipeline/example_vxlan.c:17:
+ __FUNCTION__, __LINE__); \
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#189: FILE: examples/pipeline/example_vxlan.c:69:
+static const char *drop_instructions[] = {
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#249: FILE: examples/pipeline/example_vxlan.c:129:
+static const char *vxlan_encap_instructions[] = {
WARNING:TYPO_SPELLING: 'haders' may be misspelled - perhaps 'headers'?
#250: FILE: examples/pipeline/example_vxlan.c:130:
+ /* Copy from table entry to haders and metadata. */
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#279: FILE: examples/pipeline/example_vxlan.c:159:
+static const char *table_actions[] = {"drop", "vxlan_encap"};
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#297: FILE: examples/pipeline/example_vxlan.c:177:
+static const char *pipeline_instructions[] = {
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#311: FILE: examples/pipeline/example_vxlan.c:191:
+int
total: 0 errors, 9 warnings, 482 lines checked
prev parent reply other threads:[~2020-09-08 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200826151445.51500-41-cristian.dumitrescu@intel.com>
2020-08-26 17:27 ` [dpdk-test-report] |SUCCESS| pw76035 " 0-day Robot
2020-09-08 23:17 ` checkpatch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908231759.C8A681BE0C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=cristian.dumitrescu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).