From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CDF59A04B1
	for <public@inbox.dpdk.org>; Wed,  9 Sep 2020 01:18:00 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C7A241BEAC;
	Wed,  9 Sep 2020 01:18:00 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id C8A681BE0C; Wed,  9 Sep 2020 01:17:59 +0200 (CEST)
In-Reply-To: <20200826151445.51500-41-cristian.dumitrescu@intel.com>
References: <20200826151445.51500-41-cristian.dumitrescu@intel.com>
To: test-report@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Message-Id: <20200908231759.C8A681BE0C@dpdk.org>
Date: Wed,  9 Sep 2020 01:17:59 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw76035 [PATCH 40/40]
	examples/pipeline: add VXLAN encap example
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76035

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#102: FILE: examples/pipeline/cli.c:735:
+int pipeline_setup_vxlan(struct rte_swx_pipeline *p);

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#133: FILE: examples/pipeline/example_vxlan.c:13:
+#define CHECK(condition)                                                       \
+do {                                                                           \
+	if (!(condition)) {                                                    \
+		printf("Error in function %s at line %d
",                    \
+			__FUNCTION__, __LINE__);                               \
+		return -1;                                                     \
+	}                                                                      \
+} while (0)

WARNING:USE_FUNC: __func__ should be used instead of gcc specific __FUNCTION__
#137: FILE: examples/pipeline/example_vxlan.c:17:
+			__FUNCTION__, __LINE__);                               \

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#189: FILE: examples/pipeline/example_vxlan.c:69:
+static const char *drop_instructions[] = {

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#249: FILE: examples/pipeline/example_vxlan.c:129:
+static const char *vxlan_encap_instructions[] = {

WARNING:TYPO_SPELLING: 'haders' may be misspelled - perhaps 'headers'?
#250: FILE: examples/pipeline/example_vxlan.c:130:
+	/* Copy from table entry to haders and metadata. */

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#279: FILE: examples/pipeline/example_vxlan.c:159:
+static const char *table_actions[] = {"drop", "vxlan_encap"};

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#297: FILE: examples/pipeline/example_vxlan.c:177:
+static const char *pipeline_instructions[] = {

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#311: FILE: examples/pipeline/example_vxlan.c:191:
+int

total: 0 errors, 9 warnings, 482 lines checked