* [dpdk-test-report] |WARNING| pw76205 [PATCH v1 02/42] net/txgbe: add ethdev probe and remove
[not found] <20200901115113.1529675-2-jiawenwu@trustnetic.com>
@ 2020-09-08 23:26 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-09-08 23:26 UTC (permalink / raw)
To: test-report; +Cc: Jiawen Wu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76205
_coding style issues_
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#257: FILE: drivers/net/txgbe/txgbe_ethdev.c:49:
+{
+
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#266: FILE: drivers/net/txgbe/txgbe_ethdev.c:58:
+{
+
CHECK:BRACES: braces {} should be used on all arms of this statement
#281: FILE: drivers/net/txgbe/txgbe_ethdev.c:73:
+ if (pci_dev->device.devargs) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#286: FILE: drivers/net/txgbe/txgbe_ethdev.c:78:
+ } else
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#509: FILE: drivers/net/txgbe/txgbe_logs.h:85:
+#define wjmsg_line(fmt, ...) \
+ do { \
+ RTE_LOG(CRIT, PMD, "%s(%d): " fmt, \
+ __FUNCTION__, __LINE__, ## __VA_ARGS__); \
+ } while (0)
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#510: FILE: drivers/net/txgbe/txgbe_logs.h:86:
+ do { \$
WARNING:USE_FUNC: __func__ should be used instead of gcc specific __FUNCTION__
#512: FILE: drivers/net/txgbe/txgbe_logs.h:88:
+ __FUNCTION__, __LINE__, ## __VA_ARGS__); \
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#513: FILE: drivers/net/txgbe/txgbe_logs.h:89:
+ } while (0)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#515: FILE: drivers/net/txgbe/txgbe_logs.h:91:
+ do { \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#518: FILE: drivers/net/txgbe/txgbe_logs.h:94:
+ } while (0)$
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mb' - possible side-effects?
#521: FILE: drivers/net/txgbe/txgbe_logs.h:97:
+#define wjdump(mb) { \
+ int j; char buf[128] = ""; \
+ wjmsg("data_len=%d pkt_len=%d vlan_tci=%d " \
+ "packet_type=0x%08x ol_flags=0x%016lx " \
+ "hash.rss=0x%08x hash.fdir.hash=0x%04x hash.fdir.id=%d
", \
+ mb->data_len, mb->pkt_len, mb->vlan_tci, \
+ mb->packet_type, mb->ol_flags, \
+ mb->hash.rss, mb->hash.fdir.hash, mb->hash.fdir.id); \
+ for (j = 0; j < mb->data_len; j++) { \
+ sprintf(buf + strlen(buf), "%02x ", \
+ ((uint8_t *)(mb->buf_addr) + mb->data_off)[j]); \
+ if (j % 8 == 7) {\
+ wjmsg("%s
", buf); \
+ buf[0] = '
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-08 23:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200901115113.1529675-2-jiawenwu@trustnetic.com>
2020-09-08 23:26 ` [dpdk-test-report] |WARNING| pw76205 [PATCH v1 02/42] net/txgbe: add ethdev probe and remove checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).