From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 42371A04B1
	for <public@inbox.dpdk.org>; Wed,  9 Sep 2020 01:26:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 3B13E1BEB1;
	Wed,  9 Sep 2020 01:26:13 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 3CF1F1BE85; Wed,  9 Sep 2020 01:26:12 +0200 (CEST)
In-Reply-To: <20200901115113.1529675-2-jiawenwu@trustnetic.com>
References: <20200901115113.1529675-2-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20200908232612.3CF1F1BE85@dpdk.org>
Date: Wed,  9 Sep 2020 01:26:12 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw76205 [PATCH v1 02/42] net/txgbe:
	add ethdev probe and remove
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76205

_coding style issues_


CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#257: FILE: drivers/net/txgbe/txgbe_ethdev.c:49:
+{
+

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#266: FILE: drivers/net/txgbe/txgbe_ethdev.c:58:
+{
+

CHECK:BRACES: braces {} should be used on all arms of this statement
#281: FILE: drivers/net/txgbe/txgbe_ethdev.c:73:
+	if (pci_dev->device.devargs) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#286: FILE: drivers/net/txgbe/txgbe_ethdev.c:78:
+	} else

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#509: FILE: drivers/net/txgbe/txgbe_logs.h:85:
+#define wjmsg_line(fmt, ...) \
+    do { \
+	RTE_LOG(CRIT, PMD, "%s(%d): " fmt, \
+	       __FUNCTION__, __LINE__, ## __VA_ARGS__); \
+    } while (0)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#510: FILE: drivers/net/txgbe/txgbe_logs.h:86:
+    do { \$

WARNING:USE_FUNC: __func__ should be used instead of gcc specific __FUNCTION__
#512: FILE: drivers/net/txgbe/txgbe_logs.h:88:
+	       __FUNCTION__, __LINE__, ## __VA_ARGS__); \

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#513: FILE: drivers/net/txgbe/txgbe_logs.h:89:
+    } while (0)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#515: FILE: drivers/net/txgbe/txgbe_logs.h:91:
+    do { \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#518: FILE: drivers/net/txgbe/txgbe_logs.h:94:
+    } while (0)$

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mb' - possible side-effects?
#521: FILE: drivers/net/txgbe/txgbe_logs.h:97:
+#define wjdump(mb) { \
+	int j; char buf[128] = ""; \
+	wjmsg("data_len=%d pkt_len=%d vlan_tci=%d " \
+		"packet_type=0x%08x ol_flags=0x%016lx " \
+		"hash.rss=0x%08x hash.fdir.hash=0x%04x hash.fdir.id=%d
", \
+		mb->data_len, mb->pkt_len, mb->vlan_tci, \
+		mb->packet_type, mb->ol_flags, \
+		mb->hash.rss, mb->hash.fdir.hash, mb->hash.fdir.id); \
+	for (j = 0; j < mb->data_len; j++) { \
+		sprintf(buf + strlen(buf), "%02x ", \
+			((uint8_t *)(mb->buf_addr) + mb->data_off)[j]); \
+		if (j % 8 == 7) {\
+			wjmsg("%s
", buf); \
+			buf[0] = '