* [dpdk-test-report] |WARNING| pw76211 [PATCH v1 08/42] net/txgbe: add HW reset operation
[not found] <20200901115113.1529675-8-jiawenwu@trustnetic.com>
@ 2020-09-08 23:26 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-09-08 23:26 UTC (permalink / raw)
To: test-report; +Cc: Jiawen Wu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76211
_coding style issues_
WARNING:BRACES: braces {} are not necessary for single statement blocks
#190: FILE: drivers/net/txgbe/base/txgbe_hw.c:174:
+ for (i = 0; i < poll; i++) {
+ usec_delay(100);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#265: FILE: drivers/net/txgbe/base/txgbe_hw.c:327:
+ if (i == 10) {
+ err = TXGBE_ERR_FLASH_LOADING_FAILED;
+ }
CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#315: FILE: drivers/net/txgbe/base/txgbe_hw.c:377:
+ if (hw->phy.reset_disable == false)
CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#365: FILE: drivers/net/txgbe/base/txgbe_hw.c:427:
+ if (hw->mac.orig_link_settings_stored == false) {
total: 0 errors, 2 warnings, 2 checks, 382 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-08 23:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200901115113.1529675-8-jiawenwu@trustnetic.com>
2020-09-08 23:26 ` [dpdk-test-report] |WARNING| pw76211 [PATCH v1 08/42] net/txgbe: add HW reset operation checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).