From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw76227 [PATCH v1 25/42] net/txgbe: fill receive functions
Date: Wed, 9 Sep 2020 01:28:13 +0200 (CEST) [thread overview]
Message-ID: <20200908232813.76B771BEAC@dpdk.org> (raw)
In-Reply-To: <20200901115113.1529675-25-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76227
_coding style issues_
WARNING:IF_1: Consider removing the #if 1 and its #endif
#183: FILE: drivers/net/txgbe/txgbe_rxtx.c:64:
+#if 1
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#342: FILE: drivers/net/txgbe/txgbe_rxtx.c:1111:
+ pkt_flags |= txgbe_rxd_pkt_info_to_pkt_flags(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#345: FILE: drivers/net/txgbe/txgbe_rxtx.c:1114:
+ mb->packet_type = txgbe_rxd_pkt_info_to_pkt_type(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#349: FILE: drivers/net/txgbe/txgbe_rxtx.c:1118:
+ mb->hash.rss = rte_le_to_cpu_32(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#352: FILE: drivers/net/txgbe/txgbe_rxtx.c:1121:
+ mb->hash.fdir.hash = rte_le_to_cpu_16(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#355: FILE: drivers/net/txgbe/txgbe_rxtx.c:1124:
+ mb->hash.fdir.id = rte_le_to_cpu_16(
WARNING:BRACES: braces {} are not necessary for single statement blocks
#361: FILE: drivers/net/txgbe/txgbe_rxtx.c:1130:
+ for (j = 0; j < LOOK_AHEAD; ++j) {
+ rxq->rx_stage[i + j] = rxep[j].mbuf;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#371: FILE: drivers/net/txgbe/txgbe_rxtx.c:1140:
+ for (i = 0; i < nb_rx; ++i) {
+ rxq->sw_ring[rxq->rx_tail + i].mbuf = NULL;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#400: FILE: drivers/net/txgbe/txgbe_rxtx.c:1169:
+ if (reset_mbuf) {
+ mb->port = rxq->port_id;
+ }
CHECK:SPACING: No space is necessary after a cast
#470: FILE: drivers/net/txgbe/txgbe_rxtx.c:1239:
+ "queue_id=%u", (unsigned) rxq->port_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#470: FILE: drivers/net/txgbe/txgbe_rxtx.c:1239:
+ "queue_id=%u", (unsigned) rxq->port_id,
CHECK:SPACING: No space is necessary after a cast
#471: FILE: drivers/net/txgbe/txgbe_rxtx.c:1240:
+ (unsigned) rxq->queue_id);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#471: FILE: drivers/net/txgbe/txgbe_rxtx.c:1240:
+ (unsigned) rxq->queue_id);
CHECK:SPACING: No space is necessary after a cast
#610: FILE: drivers/net/txgbe/txgbe_rxtx.c:1371:
+ (unsigned) rxq->port_id, (unsigned) rxq->queue_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#610: FILE: drivers/net/txgbe/txgbe_rxtx.c:1371:
+ (unsigned) rxq->port_id, (unsigned) rxq->queue_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#610: FILE: drivers/net/txgbe/txgbe_rxtx.c:1371:
+ (unsigned) rxq->port_id, (unsigned) rxq->queue_id,
CHECK:SPACING: No space is necessary after a cast
#611: FILE: drivers/net/txgbe/txgbe_rxtx.c:1372:
+ (unsigned) rx_id, (unsigned) staterr,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#611: FILE: drivers/net/txgbe/txgbe_rxtx.c:1372:
+ (unsigned) rx_id, (unsigned) staterr,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#611: FILE: drivers/net/txgbe/txgbe_rxtx.c:1372:
+ (unsigned) rx_id, (unsigned) staterr,
CHECK:SPACING: No space is necessary after a cast
#612: FILE: drivers/net/txgbe/txgbe_rxtx.c:1373:
+ (unsigned) rte_le_to_cpu_16(rxd.qw1.hi.len));
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#612: FILE: drivers/net/txgbe/txgbe_rxtx.c:1373:
+ (unsigned) rte_le_to_cpu_16(rxd.qw1.hi.len));
CHECK:SPACING: No space is necessary after a cast
#617: FILE: drivers/net/txgbe/txgbe_rxtx.c:1378:
+ "queue_id=%u", (unsigned) rxq->port_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#617: FILE: drivers/net/txgbe/txgbe_rxtx.c:1378:
+ "queue_id=%u", (unsigned) rxq->port_id,
CHECK:SPACING: No space is necessary after a cast
#618: FILE: drivers/net/txgbe/txgbe_rxtx.c:1379:
+ (unsigned) rxq->queue_id);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#618: FILE: drivers/net/txgbe/txgbe_rxtx.c:1379:
+ (unsigned) rxq->queue_id);
CHECK:SPACING: No space is necessary after a cast
#661: FILE: drivers/net/txgbe/txgbe_rxtx.c:1422:
+ pkt_len = (uint16_t) (rte_le_to_cpu_16(rxd.qw1.hi.len) -
CHECK:BRACES: braces {} should be used on all arms of this statement
#683: FILE: drivers/net/txgbe/txgbe_rxtx.c:1444:
+ if (likely(pkt_flags & PKT_RX_RSS_HASH))
[...]
+ else if (pkt_flags & PKT_RX_FDIR) {
[...]
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#686: FILE: drivers/net/txgbe/txgbe_rxtx.c:1447:
+ rxm->hash.fdir.hash = rte_le_to_cpu_16(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#689: FILE: drivers/net/txgbe/txgbe_rxtx.c:1450:
+ rxm->hash.fdir.id = rte_le_to_cpu_16(
WARNING:TYPO_SPELLING: 'situtation' may be misspelled - perhaps 'situation'?
#706: FILE: drivers/net/txgbe/txgbe_rxtx.c:1467:
+ * RDH register, which creates a "full" ring situtation from the
CHECK:SPACING: No space is necessary after a cast
#709: FILE: drivers/net/txgbe/txgbe_rxtx.c:1470:
+ nb_hold = (uint16_t) (nb_hold + rxq->nb_rx_hold);
CHECK:SPACING: No space is necessary after a cast
#713: FILE: drivers/net/txgbe/txgbe_rxtx.c:1474:
+ (unsigned) rxq->port_id, (unsigned) rxq->queue_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#713: FILE: drivers/net/txgbe/txgbe_rxtx.c:1474:
+ (unsigned) rxq->port_id, (unsigned) rxq->queue_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#713: FILE: drivers/net/txgbe/txgbe_rxtx.c:1474:
+ (unsigned) rxq->port_id, (unsigned) rxq->queue_id,
CHECK:SPACING: No space is necessary after a cast
#714: FILE: drivers/net/txgbe/txgbe_rxtx.c:1475:
+ (unsigned) rx_id, (unsigned) nb_hold,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#714: FILE: drivers/net/txgbe/txgbe_rxtx.c:1475:
+ (unsigned) rx_id, (unsigned) nb_hold,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#714: FILE: drivers/net/txgbe/txgbe_rxtx.c:1475:
+ (unsigned) rx_id, (unsigned) nb_hold,
CHECK:SPACING: No space is necessary after a cast
#715: FILE: drivers/net/txgbe/txgbe_rxtx.c:1476:
+ (unsigned) nb_rx);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#715: FILE: drivers/net/txgbe/txgbe_rxtx.c:1476:
+ (unsigned) nb_rx);
CHECK:SPACING: No space is necessary after a cast
#716: FILE: drivers/net/txgbe/txgbe_rxtx.c:1477:
+ rx_id = (uint16_t) ((rx_id == 0) ?
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#740: FILE: drivers/net/txgbe/txgbe_rxtx.c:1501:
+txgbe_fill_cluster_head_buf(
CHECK:BRACES: braces {} should be used on all arms of this statement
#763: FILE: drivers/net/txgbe/txgbe_rxtx.c:1524:
+ if (likely(pkt_flags & PKT_RX_RSS_HASH))
[...]
+ else if (pkt_flags & PKT_RX_FDIR) {
[...]
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'rte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed'
#881: FILE: drivers/net/txgbe/txgbe_rxtx.c:1637:
+ rte_eth_devices[rxq->port_id].data->
+ rx_mbuf_alloc_failed++;
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'rte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed'
#898: FILE: drivers/net/txgbe/txgbe_rxtx.c:1654:
+ rte_eth_devices[rxq->port_id].data->
+ rx_mbuf_alloc_failed++;
CHECK:BRACES: braces {} should be used on all arms of this statement
#926: FILE: drivers/net/txgbe/txgbe_rxtx.c:1682:
+ if (!bulk_alloc) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#938: FILE: drivers/net/txgbe/txgbe_rxtx.c:1694:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#1009: FILE: drivers/net/txgbe/txgbe_rxtx.c:1765:
+ if (unlikely(rxm->data_len <= rxq->crc_len)) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1019: FILE: drivers/net/txgbe/txgbe_rxtx.c:1775:
+ } else
WARNING:TYPO_SPELLING: 'situtation' may be misspelled - perhaps 'situation'?
#1044: FILE: drivers/net/txgbe/txgbe_rxtx.c:1800:
+ * RDH register, which creates a "full" ring situtation from the
total: 0 errors, 22 warnings, 27 checks, 1084 lines checked
Warning in drivers/net/txgbe/txgbe_rxtx.c:
Using rte_smp_[r/w]mb
parent reply other threads:[~2020-09-08 23:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200901115113.1529675-25-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908232813.76B771BEAC@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).