From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 578E3A04B1 for ; Wed, 9 Sep 2020 01:28:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4AA4B1BEB1; Wed, 9 Sep 2020 01:28:20 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id E4E651BEAC; Wed, 9 Sep 2020 01:28:18 +0200 (CEST) In-Reply-To: <20200901115113.1529675-24-jiawenwu@trustnetic.com> References: <20200901115113.1529675-24-jiawenwu@trustnetic.com> To: test-report@dpdk.org Cc: Jiawen Wu Message-Id: <20200908232818.E4E651BEAC@dpdk.org> Date: Wed, 9 Sep 2020 01:28:18 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw76228 [PATCH v1 24/42] net/txgbe: fill transmit function with hardware offload X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/76228 _coding style issues_ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #76: FILE: drivers/net/txgbe/txgbe_rxtx.c:29: +static const u64 TXGBE_TX_OFFLOAD_MASK = ( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->ctx_cache[txq->ctx_curr].flags == flags' #215: FILE: drivers/net/txgbe/txgbe_rxtx.c:390: + if (likely((txq->ctx_cache[txq->ctx_curr].flags == flags) && + (txq->ctx_cache[txq->ctx_curr].tx_offload.data[0] == + (txq->ctx_cache[txq->ctx_curr].tx_offload_mask.data[0] + & tx_offload.data[0])) && + (txq->ctx_cache[txq->ctx_curr].tx_offload.data[1] == + (txq->ctx_cache[txq->ctx_curr].tx_offload_mask.data[1] + & tx_offload.data[1])))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->ctx_cache[txq->ctx_curr].flags == flags' #226: FILE: drivers/net/txgbe/txgbe_rxtx.c:401: + if (likely((txq->ctx_cache[txq->ctx_curr].flags == flags) && + (txq->ctx_cache[txq->ctx_curr].tx_offload.data[0] == + (txq->ctx_cache[txq->ctx_curr].tx_offload_mask.data[0] + & tx_offload.data[0])) && + (txq->ctx_cache[txq->ctx_curr].tx_offload.data[1] == + (txq->ctx_cache[txq->ctx_curr].tx_offload_mask.data[1] + & tx_offload.data[1])))) WARNING:BRACES: braces {} are not necessary for single statement blocks #263: FILE: drivers/net/txgbe/txgbe_rxtx.c:438: + if (ol_flags & PKT_TX_VLAN_PKT) { + tmp |= TXGBE_TXD_CC; + } WARNING:TYPO_SPELLING: 'suport' may be misspelled - perhaps 'support'? #292: FILE: drivers/net/txgbe/txgbe_rxtx.c:467: + /* Only suport flags in TXGBE_TX_OFFLOAD_MASK */ WARNING:BRACES: braces {} are not necessary for single statement blocks #297: FILE: drivers/net/txgbe/txgbe_rxtx.c:472: + if (oflags & PKT_TX_VLAN) { + ptype |= RTE_PTYPE_L2_ETHER_VLAN; + } WARNING:BRACES: braces {} are not necessary for any arm of this statement #302: FILE: drivers/net/txgbe/txgbe_rxtx.c:477: + if (oflags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IP_CKSUM)) { [...] + } else if (oflags & (PKT_TX_OUTER_IPV6)) { [...] WARNING:BRACES: braces {} are not necessary for any arm of this statement #308: FILE: drivers/net/txgbe/txgbe_rxtx.c:483: + if (oflags & (PKT_TX_IPV4 | PKT_TX_IP_CKSUM)) { [...] + } else if (oflags & (PKT_TX_IPV6)) { [...] WARNING:BRACES: braces {} are not necessary for single statement blocks #327: FILE: drivers/net/txgbe/txgbe_rxtx.c:502: + if (oflags & PKT_TX_TCP_SEG) { + ptype |= (tun ? RTE_PTYPE_INNER_L4_TCP : RTE_PTYPE_L4_TCP); + } CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #528: FILE: drivers/net/txgbe/txgbe_rxtx.c:699: + tx_offload.ptid = tx_desc_ol_flags_to_ptid( CHECK:SPACING: No space is necessary after a cast #561: FILE: drivers/net/txgbe/txgbe_rxtx.c:732: + tx_last = (uint16_t) (tx_id + nb_used - 1); CHECK:SPACING: No space is necessary after a cast #565: FILE: drivers/net/txgbe/txgbe_rxtx.c:736: + tx_last = (uint16_t) (tx_last - txq->nb_tx_desc); CHECK:SPACING: No space is necessary after a cast #569: FILE: drivers/net/txgbe/txgbe_rxtx.c:740: + (unsigned) txq->port_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #569: FILE: drivers/net/txgbe/txgbe_rxtx.c:740: + (unsigned) txq->port_id, CHECK:SPACING: No space is necessary after a cast #570: FILE: drivers/net/txgbe/txgbe_rxtx.c:741: + (unsigned) txq->queue_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #570: FILE: drivers/net/txgbe/txgbe_rxtx.c:741: + (unsigned) txq->queue_id, CHECK:SPACING: No space is necessary after a cast #571: FILE: drivers/net/txgbe/txgbe_rxtx.c:742: + (unsigned) pkt_len, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #571: FILE: drivers/net/txgbe/txgbe_rxtx.c:742: + (unsigned) pkt_len, CHECK:SPACING: No space is necessary after a cast #572: FILE: drivers/net/txgbe/txgbe_rxtx.c:743: + (unsigned) tx_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #572: FILE: drivers/net/txgbe/txgbe_rxtx.c:743: + (unsigned) tx_id, CHECK:SPACING: No space is necessary after a cast #573: FILE: drivers/net/txgbe/txgbe_rxtx.c:744: + (unsigned) tx_last); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #573: FILE: drivers/net/txgbe/txgbe_rxtx.c:744: + (unsigned) tx_last); WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #619: FILE: drivers/net/txgbe/txgbe_rxtx.c:790: + if (nb_tx == 0) CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #657: FILE: drivers/net/txgbe/txgbe_rxtx.c:828: + if (tx_ol_req) { + WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #660: FILE: drivers/net/txgbe/txgbe_rxtx.c:831: + * not the packet len but the tcp payload len */ CHECK:SPACING: No space is necessary after a cast #747: FILE: drivers/net/txgbe/txgbe_rxtx.c:918: + (unsigned) txq->port_id, (unsigned) txq->queue_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #747: FILE: drivers/net/txgbe/txgbe_rxtx.c:918: + (unsigned) txq->port_id, (unsigned) txq->queue_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #747: FILE: drivers/net/txgbe/txgbe_rxtx.c:918: + (unsigned) txq->port_id, (unsigned) txq->queue_id, CHECK:SPACING: No space is necessary after a cast #748: FILE: drivers/net/txgbe/txgbe_rxtx.c:919: + (unsigned) tx_id, (unsigned) nb_tx); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #748: FILE: drivers/net/txgbe/txgbe_rxtx.c:919: + (unsigned) tx_id, (unsigned) nb_tx); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #748: FILE: drivers/net/txgbe/txgbe_rxtx.c:919: + (unsigned) tx_id, (unsigned) nb_tx); total: 0 errors, 17 warnings, 14 checks, 746 lines checked