automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw76236 [PATCH v1 33/42] net/txgbe: add EEPROM info get operation
Date: Wed,  9 Sep 2020 01:28:45 +0200 (CEST)	[thread overview]
Message-ID: <20200908232845.4B69C1BEAC@dpdk.org> (raw)
In-Reply-To: <20200901115113.1529675-33-jiawenwu@trustnetic.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76236

_coding style issues_


WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#129: FILE: drivers/net/txgbe/base/txgbe_hw.c:752:
+			return 0;
+		} else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'alt_san_mac_blk_offset == 0'
#202: FILE: drivers/net/txgbe/base/txgbe_hw.c:1171:
+	if ((alt_san_mac_blk_offset == 0) ||
+	    (alt_san_mac_blk_offset == 0xFFFF))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'alt_san_mac_blk_offset == 0xFFFF'
#202: FILE: drivers/net/txgbe/base/txgbe_hw.c:1171:
+	if ((alt_san_mac_blk_offset == 0) ||
+	    (alt_san_mac_blk_offset == 0xFFFF))

WARNING:BRACES: braces {} are not necessary for single statement blocks
#215: FILE: drivers/net/txgbe/base/txgbe_hw.c:1184:
+	if (hw->rom.read16(hw, offset, wwnn_prefix)) {
+		DEBUGOUT("eeprom read at offset %d failed", offset);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#370: FILE: drivers/net/txgbe/txgbe_ethdev.c:333:
+	if (hw->mac.acquire_swfw_sync(hw, mask) < 0) {
+		PMD_DRV_LOG(DEBUG, "SWFW common locks released");
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'first > hw->rom.word_size'
#422: FILE: drivers/net/txgbe/txgbe_ethdev.c:2200:
+	if ((first > hw->rom.word_size) ||
+	    ((first + length) > hw->rom.word_size))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'first > hw->rom.word_size'
#442: FILE: drivers/net/txgbe/txgbe_ethdev.c:2220:
+	if ((first > hw->rom.word_size) ||
+	    ((first + length) > hw->rom.word_size))

total: 0 errors, 3 warnings, 4 checks, 427 lines checked

           reply	other threads:[~2020-09-08 23:28 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20200901115113.1529675-33-jiawenwu@trustnetic.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200908232845.4B69C1BEAC@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).