From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E45E4A04B1 for ; Wed, 9 Sep 2020 01:46:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D4F8A1B9B7; Wed, 9 Sep 2020 01:46:56 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 010CB1BEB1; Wed, 9 Sep 2020 01:46:55 +0200 (CEST) In-Reply-To: <20200907091711.5980-3-junyux.jiang@intel.com> References: <20200907091711.5980-3-junyux.jiang@intel.com> To: test-report@dpdk.org Cc: Junyu Jiang Message-Id: <20200908234656.010CB1BEB1@dpdk.org> Date: Wed, 9 Sep 2020 01:46:56 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw76663 [PATCH v2 2/5] net/ice: add flow director enabled switch value X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/76663 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ad' - possible side-effects? #146: FILE: drivers/net/ice/ice_rxtx.h:249: +#define FDIR_PROC_ENABLE_PER_QUEUE(ad, on) do { \ + int i; \ + for (i = 0; i < (ad)->eth_dev->data->nb_rx_queues; i++) { \ + struct ice_rx_queue *rxq = (ad)->eth_dev->data->rx_queues[i]; \ + if (!rxq) \ + continue; \ + rxq->fdir_enabled = on; \ + } \ + PMD_DRV_LOG(DEBUG, "FDIR processing on RX set to %d", on); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'on' - possible side-effects? #146: FILE: drivers/net/ice/ice_rxtx.h:249: +#define FDIR_PROC_ENABLE_PER_QUEUE(ad, on) do { \ + int i; \ + for (i = 0; i < (ad)->eth_dev->data->nb_rx_queues; i++) { \ + struct ice_rx_queue *rxq = (ad)->eth_dev->data->rx_queues[i]; \ + if (!rxq) \ + continue; \ + rxq->fdir_enabled = on; \ + } \ + PMD_DRV_LOG(DEBUG, "FDIR processing on RX set to %d", on); \ +} while (0) total: 0 errors, 0 warnings, 2 checks, 81 lines checked