From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1820A04B5 for ; Fri, 11 Sep 2020 14:10:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9EEC1C0B9; Fri, 11 Sep 2020 14:10:31 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id E7FCC1C0B9; Fri, 11 Sep 2020 14:10:30 +0200 (CEST) In-Reply-To: <20200911120906.45995-2-joyce.kong@arm.com> References: <20200911120906.45995-2-joyce.kong@arm.com> To: test-report@dpdk.org Cc: Joyce Kong Message-Id: <20200911121030.E7FCC1C0B9@dpdk.org> Date: Fri, 11 Sep 2020 14:10:30 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw77384 [RFC 1/3] net/virtio: move AVX based Rx and Tx code to separate file X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/77384 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <_Pragma> #178: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #178: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #178: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #178: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ + for (iter = val; iter < size; iter++) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #183: FILE: drivers/net/virtio/virtio_rxtx_packed.h:57: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #183: FILE: drivers/net/virtio/virtio_rxtx_packed.h:57: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #183: FILE: drivers/net/virtio/virtio_rxtx_packed.h:57: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #188: FILE: drivers/net/virtio/virtio_rxtx_packed.h:62: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #188: FILE: drivers/net/virtio/virtio_rxtx_packed.h:62: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #188: FILE: drivers/net/virtio/virtio_rxtx_packed.h:62: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #193: FILE: drivers/net/virtio/virtio_rxtx_packed.h:67: +#define virtio_for_each_try_unroll(iter, val, num) \ + for (iter = val; iter < num; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'num' may be better as '(num)' to avoid precedence issues #193: FILE: drivers/net/virtio/virtio_rxtx_packed.h:67: +#define virtio_for_each_try_unroll(iter, val, num) \ + for (iter = val; iter < num; iter++) WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Joyce Kong ' total: 3 errors, 1 warnings, 9 checks, 618 lines checked Warning in drivers/net/virtio/virtio_rxtx_packed.c: Using rte_panic/rte_exit