From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw78259 [PATCH 11/60] common/sfc_efx/base: factor out helper to get board config
Date: Tue, 22 Sep 2020 10:52:40 +0200 (CEST) [thread overview]
Message-ID: <20200922085240.1DA8C1DA76@dpdk.org> (raw)
In-Reply-To: <1600764594-14752-12-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78259
_coding style issues_
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#175: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1875:
+ if ((rc = efx_mcdi_get_vector_cfg(enp, &base, &nvec, NULL)) != 0) {
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#192: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1892:
+ if ((rc = ef10_get_privilege_mask(enp, &mask)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#196: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1896:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#221: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1921:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#271: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1971:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#282: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1982:
+ if ((rc = efx_mcdi_nic_board_cfg(enp)) != 0)
total: 6 errors, 0 warnings, 255 lines checked
parent reply other threads:[~2020-09-22 8:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1600764594-14752-12-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922085240.1DA8C1DA76@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).