From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1D33A04E1 for ; Tue, 22 Sep 2020 10:54:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C881E1DB0E; Tue, 22 Sep 2020 10:54:49 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 943BA1DAFF; Tue, 22 Sep 2020 10:54:46 +0200 (CEST) In-Reply-To: <1600764594-14752-15-git-send-email-arybchenko@solarflare.com> References: <1600764594-14752-15-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20200922085446.943BA1DAFF@dpdk.org> Date: Tue, 22 Sep 2020 10:54:46 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw78269 [PATCH 14/60] common/sfc_efx/base: add Riverhead support to NIC module X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/78269 _coding style issues_ WARNING:SPACING: space prohibited between function name and open parenthesis '(' #469: FILE: drivers/common/sfc_efx/base/rhead_impl.h:24: +#define RHEAD_EVQ_DESC_SIZE (sizeof (efx_qword_t)) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #470: FILE: drivers/common/sfc_efx/base/rhead_impl.h:25: +#define RHEAD_RXQ_DESC_SIZE (sizeof (efx_qword_t)) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #471: FILE: drivers/common/sfc_efx/base/rhead_impl.h:26: +#define RHEAD_TXQ_DESC_SIZE (sizeof (efx_oword_t)) WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #489: FILE: drivers/common/sfc_efx/base/rhead_impl.h:44: + __inout efx_nic_t *enp, WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #503: FILE: drivers/common/sfc_efx/base/rhead_impl.h:58: + __out uint32_t *offsetp, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #578: FILE: drivers/common/sfc_efx/base/rhead_nic.c:22: + if ((rc = efx_mcdi_nic_board_cfg(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #664: FILE: drivers/common/sfc_efx/base/rhead_nic.c:108: + if ((rc = efx_mcdi_get_rxdp_config(enp, &end_padding)) != 0) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #685: FILE: drivers/common/sfc_efx/base/rhead_nic.c:129: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #694: FILE: drivers/common/sfc_efx/base/rhead_nic.c:138: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #709: FILE: drivers/common/sfc_efx/base/rhead_nic.c:153: + if ((rc = efx_mcdi_read_assertion(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #713: FILE: drivers/common/sfc_efx/base/rhead_nic.c:157: + if ((rc = efx_mcdi_exit_assertion_handler(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #717: FILE: drivers/common/sfc_efx/base/rhead_nic.c:161: + if ((rc = efx_mcdi_drv_attach(enp, B_TRUE)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #721: FILE: drivers/common/sfc_efx/base/rhead_nic.c:165: + if ((rc = enop->eno_board_cfg(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #743: FILE: drivers/common/sfc_efx/base/rhead_nic.c:187: + if ((rc = efx_mcdi_mac_stats_clear(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #748: FILE: drivers/common/sfc_efx/base/rhead_nic.c:192: + if ((rc = efx_mcdi_get_loopback_modes(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #771: FILE: drivers/common/sfc_efx/base/rhead_nic.c:215: + return (rc); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #776: FILE: drivers/common/sfc_efx/base/rhead_nic.c:220: + __inout efx_nic_t *enp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #810: FILE: drivers/common/sfc_efx/base/rhead_nic.c:254: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #815: FILE: drivers/common/sfc_efx/base/rhead_nic.c:259: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #825: FILE: drivers/common/sfc_efx/base/rhead_nic.c:269: + if ((rc = efx_mcdi_read_assertion(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #827: FILE: drivers/common/sfc_efx/base/rhead_nic.c:271: + if ((rc = efx_mcdi_exit_assertion_handler(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #830: FILE: drivers/common/sfc_efx/base/rhead_nic.c:274: + if ((rc = efx_mcdi_entity_reset(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #836: FILE: drivers/common/sfc_efx/base/rhead_nic.c:280: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #845: FILE: drivers/common/sfc_efx/base/rhead_nic.c:289: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #862: FILE: drivers/common/sfc_efx/base/rhead_nic.c:306: + if ((rc = efx_mcdi_log_ctrl(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #869: FILE: drivers/common/sfc_efx/base/rhead_nic.c:313: + if ((rc = efx_mcdi_free_vis(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #877: FILE: drivers/common/sfc_efx/base/rhead_nic.c:321: + if ((rc = efx_mcdi_alloc_vis(enp, min_vi_count, max_vi_count, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #912: FILE: drivers/common/sfc_efx/base/rhead_nic.c:356: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #926: FILE: drivers/common/sfc_efx/base/rhead_nic.c:370: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #940: FILE: drivers/common/sfc_efx/base/rhead_nic.c:384: + return (0); WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #947: FILE: drivers/common/sfc_efx/base/rhead_nic.c:391: + __out uint32_t *offsetp, WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #962: FILE: drivers/common/sfc_efx/base/rhead_nic.c:406: + *offsetp = enp->en_arch.ef10.ena_uc_mem_map_offset; WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #968: FILE: drivers/common/sfc_efx/base/rhead_nic.c:412: + *offsetp = enp->en_arch.ef10.ena_wc_mem_map_offset; ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #982: FILE: drivers/common/sfc_efx/base/rhead_nic.c:426: + return (rc); WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'? #994: FILE: drivers/common/sfc_efx/base/rhead_nic.c:438: + EFX_BAR_READD(enp, ER_GZ_MC_SFT_STATUS, &dword, B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #998: FILE: drivers/common/sfc_efx/base/rhead_nic.c:442: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1003: FILE: drivers/common/sfc_efx/base/rhead_nic.c:447: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1051: FILE: drivers/common/sfc_efx/base/rhead_nic.c:495: + return (rc); total: 28 errors, 10 warnings, 887 lines checked