From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw78283 [PATCH 32/60] common/sfc_efx/base: implement Rx control path for Riverhead
Date: Tue, 22 Sep 2020 10:57:03 +0200 (CEST) [thread overview]
Message-ID: <20200922085703.D26BE1DBB1@dpdk.org> (raw)
In-Reply-To: <1600764594-14752-33-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78283
_coding style issues_
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#381: FILE: drivers/common/sfc_efx/base/rhead_impl.h:323:
+ __inout unsigned int *pushedp);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#447: FILE: drivers/common/sfc_efx/base/rhead_rx.c:23:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#451: FILE: drivers/common/sfc_efx/base/rhead_rx.c:27:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#488: FILE: drivers/common/sfc_efx/base/rhead_rx.c:64:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#492: FILE: drivers/common/sfc_efx/base/rhead_rx.c:68:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#506: FILE: drivers/common/sfc_efx/base/rhead_rx.c:82:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#510: FILE: drivers/common/sfc_efx/base/rhead_rx.c:86:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#527: FILE: drivers/common/sfc_efx/base/rhead_rx.c:103:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#531: FILE: drivers/common/sfc_efx/base/rhead_rx.c:107:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#547: FILE: drivers/common/sfc_efx/base/rhead_rx.c:123:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#551: FILE: drivers/common/sfc_efx/base/rhead_rx.c:127:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#567: FILE: drivers/common/sfc_efx/base/rhead_rx.c:143:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#571: FILE: drivers/common/sfc_efx/base/rhead_rx.c:147:
+ return (rc);
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#584: FILE: drivers/common/sfc_efx/base/rhead_rx.c:160:
+ return (ENOTSUP);
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#599: FILE: drivers/common/sfc_efx/base/rhead_rx.c:175:
+ return (ENOTSUP);
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#622: FILE: drivers/common/sfc_efx/base/rhead_rx.c:198:
+ __inout unsigned int *pushedp)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#638: FILE: drivers/common/sfc_efx/base/rhead_rx.c:214:
+ if ((rc = efx_mcdi_fini_rxq(enp, erp->er_index)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#641: FILE: drivers/common/sfc_efx/base/rhead_rx.c:217:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#653: FILE: drivers/common/sfc_efx/base/rhead_rx.c:229:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#712: FILE: drivers/common/sfc_efx/base/rhead_rx.c:288:
+ if ((rc = efx_mcdi_init_rxq(enp, ndescs, eep, label, index,
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#720: FILE: drivers/common/sfc_efx/base/rhead_rx.c:296:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#729: FILE: drivers/common/sfc_efx/base/rhead_rx.c:305:
+ return (rc);
total: 18 errors, 4 warnings, 589 lines checked
parent reply other threads:[~2020-09-22 8:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1600764594-14752-33-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922085703.D26BE1DBB1@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).