From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDD94A04E1 for ; Tue, 22 Sep 2020 11:01:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AECD91DCDF; Tue, 22 Sep 2020 11:01:14 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 6E7EA1DCDF; Tue, 22 Sep 2020 11:01:13 +0200 (CEST) In-Reply-To: <1600764594-14752-45-git-send-email-arybchenko@solarflare.com> References: <1600764594-14752-45-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20200922090113.6E7EA1DCDF@dpdk.org> Date: Tue, 22 Sep 2020 11:01:13 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw78301 [PATCH 44/60] common/sfc_efx/base: add function control window lookup API X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/78301 _coding style issues_ WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #212: FILE: drivers/common/sfc_efx/base/efx_impl.h:1576: + __inout size_t *offsetp); WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #212: FILE: drivers/common/sfc_efx/base/efx_impl.h:1576: + __inout size_t *offsetp); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #225: FILE: drivers/common/sfc_efx/base/efx_impl.h:1589: + __inout size_t *offsetp); WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #225: FILE: drivers/common/sfc_efx/base/efx_impl.h:1589: + __inout size_t *offsetp); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #237: FILE: drivers/common/sfc_efx/base/efx_impl.h:1601: + __inout size_t *pci_cap_offsetp, WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #237: FILE: drivers/common/sfc_efx/base/efx_impl.h:1601: + __inout size_t *pci_cap_offsetp, WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #239: FILE: drivers/common/sfc_efx/base/efx_impl.h:1603: + __out efsys_dma_addr_t *xilinx_tbl_offsetp); WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #254: FILE: drivers/common/sfc_efx/base/efx_impl.h:1618: + __out efsys_dma_addr_t *offsetp); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #291: FILE: drivers/common/sfc_efx/base/efx_nic.c:128: + return (rc); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #333: FILE: drivers/common/sfc_efx/base/efx_pci.c:15: + __inout size_t *offsetp) WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #333: FILE: drivers/common/sfc_efx/base/efx_pci.c:15: + __inout size_t *offsetp) WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #339: FILE: drivers/common/sfc_efx/base/efx_pci.c:21: + if (offsetp == NULL) { WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #344: FILE: drivers/common/sfc_efx/base/efx_pci.c:26: + if (*offsetp == 0) { WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #345: FILE: drivers/common/sfc_efx/base/efx_pci.c:27: + *offsetp = ESE_GZ_PCI_BASE_CONFIG_SPACE_SIZE; WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'? #347: FILE: drivers/common/sfc_efx/base/efx_pci.c:29: + EFSYS_PCI_CONFIG_READD(espcp, *offsetp + WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #347: FILE: drivers/common/sfc_efx/base/efx_pci.c:29: + EFSYS_PCI_CONFIG_READD(espcp, *offsetp + WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #359: FILE: drivers/common/sfc_efx/base/efx_pci.c:41: + *offsetp = next; ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #373: FILE: drivers/common/sfc_efx/base/efx_pci.c:55: + return (rc); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #380: FILE: drivers/common/sfc_efx/base/efx_pci.c:62: + __inout size_t *offsetp) WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #380: FILE: drivers/common/sfc_efx/base/efx_pci.c:62: + __inout size_t *offsetp) WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #386: FILE: drivers/common/sfc_efx/base/efx_pci.c:68: + if (offsetp == NULL) { WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #391: FILE: drivers/common/sfc_efx/base/efx_pci.c:73: + position = *offsetp; WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #398: FILE: drivers/common/sfc_efx/base/efx_pci.c:80: + break; + else WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'? #402: FILE: drivers/common/sfc_efx/base/efx_pci.c:84: + EFSYS_PCI_CONFIG_READD(espcp, position + WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #412: FILE: drivers/common/sfc_efx/base/efx_pci.c:94: + *offsetp = position; ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #431: FILE: drivers/common/sfc_efx/base/efx_pci.c:113: + return (rc); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #437: FILE: drivers/common/sfc_efx/base/efx_pci.c:119: + __inout size_t *pci_cap_offsetp, WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #437: FILE: drivers/common/sfc_efx/base/efx_pci.c:119: + __inout size_t *pci_cap_offsetp, WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #439: FILE: drivers/common/sfc_efx/base/efx_pci.c:121: + __out efsys_dma_addr_t *xilinx_tbl_offsetp) WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #444: FILE: drivers/common/sfc_efx/base/efx_pci.c:126: + if (pci_cap_offsetp == NULL) { WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #449: FILE: drivers/common/sfc_efx/base/efx_pci.c:131: + cap_offset = *pci_cap_offsetp; WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #460: FILE: drivers/common/sfc_efx/base/efx_pci.c:142: + break; + else WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #474: FILE: drivers/common/sfc_efx/base/efx_pci.c:156: + *xilinx_tbl_offsetp = tbl_offset; WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #475: FILE: drivers/common/sfc_efx/base/efx_pci.c:157: + *pci_cap_offsetp = cap_offset; WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #477: FILE: drivers/common/sfc_efx/base/efx_pci.c:159: + break; + } else { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #498: FILE: drivers/common/sfc_efx/base/efx_pci.c:180: + return (rc); WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #506: FILE: drivers/common/sfc_efx/base/efx_pci.c:188: + __out efsys_dma_addr_t *offsetp) WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'? #520: FILE: drivers/common/sfc_efx/base/efx_pci.c:202: + EFSYS_PCI_CONFIG_READD(espcp, cap_offset + WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'? #534: FILE: drivers/common/sfc_efx/base/efx_pci.c:216: + EFSYS_PCI_CONFIG_READD(espcp, vsec_offset + WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'? #561: FILE: drivers/common/sfc_efx/base/efx_pci.c:243: + EFSYS_PCI_CONFIG_READD(espcp, vsec_offset + WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'? #573: FILE: drivers/common/sfc_efx/base/efx_pci.c:255: + EFSYS_PCI_CONFIG_READD(espcp, vsec_offset + WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #597: FILE: drivers/common/sfc_efx/base/efx_pci.c:279: + *offsetp = offset; ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #600: FILE: drivers/common/sfc_efx/base/efx_pci.c:282: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #617: FILE: drivers/common/sfc_efx/base/efx_pci.c:299: + return (rc); WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #716: FILE: drivers/common/sfc_efx/base/rhead_pci.c:46: + break; + } else { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #728: FILE: drivers/common/sfc_efx/base/rhead_pci.c:58: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #735: FILE: drivers/common/sfc_efx/base/rhead_pci.c:65: + return (rc); total: 8 errors, 39 warnings, 587 lines checked