* [dpdk-test-report] |WARNING| pw78342 [PATCH v2 11/60] common/sfc_efx/base: factor out helper to get board config
[not found] <1600767288-12109-12-git-send-email-arybchenko@solarflare.com>
@ 2020-09-22 9:38 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-09-22 9:38 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78342
_coding style issues_
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#176: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1875:
+ if ((rc = efx_mcdi_get_vector_cfg(enp, &base, &nvec, NULL)) != 0) {
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#193: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1892:
+ if ((rc = ef10_get_privilege_mask(enp, &mask)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#197: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1896:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#222: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1921:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#272: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1971:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#283: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1982:
+ if ((rc = efx_mcdi_nic_board_cfg(enp)) != 0)
total: 6 errors, 0 warnings, 255 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-22 9:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1600767288-12109-12-git-send-email-arybchenko@solarflare.com>
2020-09-22 9:38 ` [dpdk-test-report] |WARNING| pw78342 [PATCH v2 11/60] common/sfc_efx/base: factor out helper to get board config checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).