From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EAD39A04E2
	for <public@inbox.dpdk.org>; Tue, 22 Sep 2020 11:38:36 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 9330E1DD16;
	Tue, 22 Sep 2020 11:38:35 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id AC0011DD72; Tue, 22 Sep 2020 11:38:28 +0200 (CEST)
In-Reply-To: <1600767288-12109-12-git-send-email-arybchenko@solarflare.com>
References: <1600767288-12109-12-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20200922093828.AC0011DD72@dpdk.org>
Date: Tue, 22 Sep 2020 11:38:28 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw78342 [PATCH v2 11/60]
	common/sfc_efx/base: factor out helper to get board config
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78342

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#176: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1875:
+	if ((rc = efx_mcdi_get_vector_cfg(enp, &base, &nvec, NULL)) != 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#193: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1892:
+	if ((rc = ef10_get_privilege_mask(enp, &mask)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#197: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1896:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#222: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1921:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#272: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1971:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#283: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1982:
+	if ((rc = efx_mcdi_nic_board_cfg(enp)) != 0)

total: 6 errors, 0 warnings, 255 lines checked