From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DDF1A04E1 for ; Tue, 22 Sep 2020 11:38:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9D2A1DD3C; Tue, 22 Sep 2020 11:38:35 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id B49D21DCFE; Tue, 22 Sep 2020 11:38:33 +0200 (CEST) In-Reply-To: <1600767288-12109-15-git-send-email-arybchenko@solarflare.com> References: <1600767288-12109-15-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20200922093833.B49D21DCFE@dpdk.org> Date: Tue, 22 Sep 2020 11:38:33 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw78343 [PATCH v2 14/60] common/sfc_efx/base: add Riverhead support to NIC module X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/78343 _coding style issues_ WARNING:SPACING: space prohibited between function name and open parenthesis '(' #472: FILE: drivers/common/sfc_efx/base/rhead_impl.h:24: +#define RHEAD_EVQ_DESC_SIZE (sizeof (efx_qword_t)) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #473: FILE: drivers/common/sfc_efx/base/rhead_impl.h:25: +#define RHEAD_RXQ_DESC_SIZE (sizeof (efx_qword_t)) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #474: FILE: drivers/common/sfc_efx/base/rhead_impl.h:26: +#define RHEAD_TXQ_DESC_SIZE (sizeof (efx_oword_t)) WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #492: FILE: drivers/common/sfc_efx/base/rhead_impl.h:44: + __inout efx_nic_t *enp, WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #506: FILE: drivers/common/sfc_efx/base/rhead_impl.h:58: + __out uint32_t *offsetp, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #581: FILE: drivers/common/sfc_efx/base/rhead_nic.c:22: + if ((rc = efx_mcdi_nic_board_cfg(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #667: FILE: drivers/common/sfc_efx/base/rhead_nic.c:108: + if ((rc = efx_mcdi_get_rxdp_config(enp, &end_padding)) != 0) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #688: FILE: drivers/common/sfc_efx/base/rhead_nic.c:129: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #697: FILE: drivers/common/sfc_efx/base/rhead_nic.c:138: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #712: FILE: drivers/common/sfc_efx/base/rhead_nic.c:153: + if ((rc = efx_mcdi_read_assertion(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #716: FILE: drivers/common/sfc_efx/base/rhead_nic.c:157: + if ((rc = efx_mcdi_exit_assertion_handler(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #720: FILE: drivers/common/sfc_efx/base/rhead_nic.c:161: + if ((rc = efx_mcdi_drv_attach(enp, B_TRUE)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #724: FILE: drivers/common/sfc_efx/base/rhead_nic.c:165: + if ((rc = enop->eno_board_cfg(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #746: FILE: drivers/common/sfc_efx/base/rhead_nic.c:187: + if ((rc = efx_mcdi_mac_stats_clear(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #751: FILE: drivers/common/sfc_efx/base/rhead_nic.c:192: + if ((rc = efx_mcdi_get_loopback_modes(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #774: FILE: drivers/common/sfc_efx/base/rhead_nic.c:215: + return (rc); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #779: FILE: drivers/common/sfc_efx/base/rhead_nic.c:220: + __inout efx_nic_t *enp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #813: FILE: drivers/common/sfc_efx/base/rhead_nic.c:254: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #818: FILE: drivers/common/sfc_efx/base/rhead_nic.c:259: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #828: FILE: drivers/common/sfc_efx/base/rhead_nic.c:269: + if ((rc = efx_mcdi_read_assertion(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #830: FILE: drivers/common/sfc_efx/base/rhead_nic.c:271: + if ((rc = efx_mcdi_exit_assertion_handler(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #833: FILE: drivers/common/sfc_efx/base/rhead_nic.c:274: + if ((rc = efx_mcdi_entity_reset(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #839: FILE: drivers/common/sfc_efx/base/rhead_nic.c:280: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #848: FILE: drivers/common/sfc_efx/base/rhead_nic.c:289: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #865: FILE: drivers/common/sfc_efx/base/rhead_nic.c:306: + if ((rc = efx_mcdi_log_ctrl(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #872: FILE: drivers/common/sfc_efx/base/rhead_nic.c:313: + if ((rc = efx_mcdi_free_vis(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #880: FILE: drivers/common/sfc_efx/base/rhead_nic.c:321: + if ((rc = efx_mcdi_alloc_vis(enp, min_vi_count, max_vi_count, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #915: FILE: drivers/common/sfc_efx/base/rhead_nic.c:356: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #929: FILE: drivers/common/sfc_efx/base/rhead_nic.c:370: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #943: FILE: drivers/common/sfc_efx/base/rhead_nic.c:384: + return (0); WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #950: FILE: drivers/common/sfc_efx/base/rhead_nic.c:391: + __out uint32_t *offsetp, WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #965: FILE: drivers/common/sfc_efx/base/rhead_nic.c:406: + *offsetp = enp->en_arch.ef10.ena_uc_mem_map_offset; WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'? #971: FILE: drivers/common/sfc_efx/base/rhead_nic.c:412: + *offsetp = enp->en_arch.ef10.ena_wc_mem_map_offset; ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #985: FILE: drivers/common/sfc_efx/base/rhead_nic.c:426: + return (rc); WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'? #997: FILE: drivers/common/sfc_efx/base/rhead_nic.c:438: + EFX_BAR_READD(enp, ER_GZ_MC_SFT_STATUS, &dword, B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1001: FILE: drivers/common/sfc_efx/base/rhead_nic.c:442: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1006: FILE: drivers/common/sfc_efx/base/rhead_nic.c:447: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1054: FILE: drivers/common/sfc_efx/base/rhead_nic.c:495: + return (rc); total: 28 errors, 10 warnings, 887 lines checked