From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 410FBA04E1 for ; Tue, 22 Sep 2020 11:42:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24D6C1DD10; Tue, 22 Sep 2020 11:42:46 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 46D2A1DD15; Tue, 22 Sep 2020 11:42:40 +0200 (CEST) In-Reply-To: <1600767288-12109-34-git-send-email-arybchenko@solarflare.com> References: <1600767288-12109-34-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20200922094240.46D2A1DD15@dpdk.org> Date: Tue, 22 Sep 2020 11:42:40 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw78362 [PATCH v2 33/60] common/sfc_efx/base: implement Tx control path for Riverhead X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/78362 _coding style issues_ WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #260: FILE: drivers/common/sfc_efx/base/rhead_impl.h:396: + __inout unsigned int *addedp); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #292: FILE: drivers/common/sfc_efx/base/rhead_impl.h:428: + __inout unsigned int *addedp); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #300: FILE: drivers/common/sfc_efx/base/rhead_impl.h:436: + __inout_ecount(TX_NQSTATS) efsys_stat_t *stat); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #364: FILE: drivers/common/sfc_efx/base/rhead_tx.c:51: + if ((rc = efx_mcdi_init_txq(enp, ndescs, eep->ee_index, label, index, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #374: FILE: drivers/common/sfc_efx/base/rhead_tx.c:61: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #379: FILE: drivers/common/sfc_efx/base/rhead_tx.c:66: + return (rc); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #396: FILE: drivers/common/sfc_efx/base/rhead_tx.c:83: + __inout unsigned int *addedp) WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #406: FILE: drivers/common/sfc_efx/base/rhead_tx.c:93: + return (ENOTSUP); WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #431: FILE: drivers/common/sfc_efx/base/rhead_tx.c:118: + return (ENOTSUP); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #441: FILE: drivers/common/sfc_efx/base/rhead_tx.c:128: + if ((rc = efx_mcdi_fini_txq(enp, etp->et_index)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #444: FILE: drivers/common/sfc_efx/base/rhead_tx.c:131: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #456: FILE: drivers/common/sfc_efx/base/rhead_tx.c:143: + return (rc); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #473: FILE: drivers/common/sfc_efx/base/rhead_tx.c:160: + __inout unsigned int *addedp) WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #483: FILE: drivers/common/sfc_efx/base/rhead_tx.c:170: + return (ENOTSUP); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #491: FILE: drivers/common/sfc_efx/base/rhead_tx.c:178: + __inout_ecount(TX_NQSTATS) efsys_stat_t *stat) total: 6 errors, 9 warnings, 368 lines checked