From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4D820A04E1
	for <public@inbox.dpdk.org>; Tue, 22 Sep 2020 11:45:15 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 435551DDD6;
	Tue, 22 Sep 2020 11:45:15 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 612C11DE42; Tue, 22 Sep 2020 11:45:08 +0200 (CEST)
In-Reply-To: <1600767288-12109-47-git-send-email-arybchenko@solarflare.com>
References: <1600767288-12109-47-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20200922094508.612C11DE42@dpdk.org>
Date: Tue, 22 Sep 2020 11:45:08 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw78377 [PATCH v2 46/60]
	common/sfc_efx/base: add Xilinx capabilities table lookup
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78377

_coding style issues_


WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#126: FILE: drivers/common/sfc_efx/base/efx_impl.h:1633:
+	__inout				efsys_dma_addr_t *entry_offsetp);

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#126: FILE: drivers/common/sfc_efx/base/efx_impl.h:1633:
+	__inout				efsys_dma_addr_t *entry_offsetp);

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#144: FILE: drivers/common/sfc_efx/base/efx_pci.c:307:
+	__inout				efsys_dma_addr_t *entry_offsetp)

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#144: FILE: drivers/common/sfc_efx/base/efx_pci.c:307:
+	__inout				efsys_dma_addr_t *entry_offsetp)

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#146: FILE: drivers/common/sfc_efx/base/efx_pci.c:309:
+	efsys_dma_addr_t offset = *entry_offsetp;

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#153: FILE: drivers/common/sfc_efx/base/efx_pci.c:316:
+	if (entry_offsetp == NULL) {

WARNING:TYPO_SPELLING: 'requries' may be misspelled - perhaps 'requires'?
#165: FILE: drivers/common/sfc_efx/base/efx_pci.c:328:
+		 * Xilinx Capabilities Table requries 32bit aligned reads.

WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'?
#168: FILE: drivers/common/sfc_efx/base/efx_pci.c:331:
+		EFSYS_BAR_READD(esbp, offset +

WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'?
#171: FILE: drivers/common/sfc_efx/base/efx_pci.c:334:
+		EFSYS_BAR_READD(esbp, offset +

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#179: FILE: drivers/common/sfc_efx/base/efx_pci.c:342:
+			*entry_offsetp = offset;

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#192: FILE: drivers/common/sfc_efx/base/efx_pci.c:355:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#197: FILE: drivers/common/sfc_efx/base/efx_pci.c:360:
+	return (rc);

WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'?
#242: FILE: drivers/common/sfc_efx/base/rhead_nic.c:536:
+	EFSYS_BAR_READD(esbp, offset +

WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'?
#245: FILE: drivers/common/sfc_efx/base/rhead_nic.c:539:
+	EFSYS_BAR_READD(esbp, offset +

WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'?
#258: FILE: drivers/common/sfc_efx/base/rhead_nic.c:552:
+	EFSYS_BAR_READD(esbp, offset +

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#269: FILE: drivers/common/sfc_efx/base/rhead_nic.c:563:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#274: FILE: drivers/common/sfc_efx/base/rhead_nic.c:568:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#311: FILE: drivers/common/sfc_efx/base/rhead_pci.c:37:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#318: FILE: drivers/common/sfc_efx/base/rhead_pci.c:44:
+	return (rc);

total: 6 errors, 13 warnings, 222 lines checked