From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Li RongQing <lirongqing@baidu.com>
Subject: [dpdk-test-report] |WARNING| pw78394 [PATCH 1/2] net/bonding: fix a possible unbalance packet receiving
Date: Tue, 22 Sep 2020 12:29:48 +0200 (CEST) [thread overview]
Message-ID: <20200922102948.75C551DBEB@dpdk.org> (raw)
In-Reply-To: <1600770572-22716-1-git-send-email-lirongqing@baidu.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78394
_coding style issues_
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#43:
Current Rx round robin policy for the slaves has two issue:
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#45:
1. active_slave in bond_dev_private is shared by multiple PMDS
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#46:
which maybe cause some slave Rx hungry, for example, there
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#47:
is two PMD and two slave port, both PMDs start to receive, and
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#48:
see that active_slave is 0, and receive from slave 0, after
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#48:
see that active_slave is 0, and receive from slave 0, after
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#49:
complete, they increase active_slave by one, totally active_slave
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#49:
complete, they increase active_slave by one, totally active_slave
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#51:
from slave 0 again, at last, slave 1 maybe drop packets during
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#51:
from slave 0 again, at last, slave 1 maybe drop packets during
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#54:
2. active_slave is shared and written by multiple PMD in RX path
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#58:
so move active_slave from bond_dev_private to bond_rx_queue
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#77: FILE: drivers/net/bonding/eth_bond_private.h:53:
+ /**< Next active_slave to poll */
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#78: FILE: drivers/net/bonding/eth_bond_private.h:54:
+ uint16_t active_slave;
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#116: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:72:
+ active_slave = bd_rx_q->active_slave;
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#116: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:72:
+ active_slave = bd_rx_q->active_slave;
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#126: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:89:
+ if (++bd_rx_q->active_slave >= slave_count)
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#126: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:89:
+ if (++bd_rx_q->active_slave >= slave_count)
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#127: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:90:
+ bd_rx_q->active_slave = 0;
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#136: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:306:
+ idx = bd_rx_q->active_slave;
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#139: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:308:
+ bd_rx_q->active_slave = 0;
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#149: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:370:
+ if (++bd_rx_q->active_slave >= slave_count)
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#149: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:370:
+ if (++bd_rx_q->active_slave >= slave_count)
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#150: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:371:
+ bd_rx_q->active_slave = 0;
total: 0 errors, 24 warnings, 0 checks, 66 lines checked
parent reply other threads:[~2020-09-22 10:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1600770572-22716-1-git-send-email-lirongqing@baidu.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922102948.75C551DBEB@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=lirongqing@baidu.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).