automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw78708 [PATCH v3 19/60] common/sfc_efx/base: move EvQ init/fini wrappers to generic
Date: Thu, 24 Sep 2020 14:19:29 +0200 (CEST)	[thread overview]
Message-ID: <20200924121929.1E1161DEAC@dpdk.org> (raw)
In-Reply-To: <1600949555-28043-20-git-send-email-arybchenko@solarflare.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78708

_coding style issues_


WARNING:TYPO_SPELLING: 'THRU' may be misspelled - perhaps 'THROUGH'?
#539: FILE: drivers/common/sfc_efx/base/efx_mcdi.c:2516:
+	    INIT_EVQ_IN_FLAG_CUT_THRU, ev_cut_through,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#552: FILE: drivers/common/sfc_efx/base/efx_mcdi.c:2529:
+		if ((rc = efx_ev_usecs_to_ticks(enp, us, &ticks)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#604: FILE: drivers/common/sfc_efx/base/efx_mcdi.c:2581:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#677: FILE: drivers/common/sfc_efx/base/efx_mcdi.c:2654:
+		if ((rc = efx_ev_usecs_to_ticks(enp, us, &ticks)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#719: FILE: drivers/common/sfc_efx/base/efx_mcdi.c:2696:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#732: FILE: drivers/common/sfc_efx/base/efx_mcdi.c:2709:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#770: FILE: drivers/common/sfc_efx/base/efx_mcdi.c:2747:
+	return (rc);

total: 6 errors, 1 warnings, 659 lines checked

           reply	other threads:[~2020-09-24 12:19 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1600949555-28043-20-git-send-email-arybchenko@solarflare.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924121929.1E1161DEAC@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arybchenko@solarflare.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).