automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw78718 [PATCH v3 42/60] common/sfc_efx/base: choose smallest Rx prefix on Riverhead
Date: Thu, 24 Sep 2020 14:21:36 +0200 (CEST)	[thread overview]
Message-ID: <20200924122136.4CD8E1DFEC@dpdk.org> (raw)
In-Reply-To: <1600949555-28043-43-git-send-email-arybchenko@solarflare.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78718

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#220: FILE: drivers/common/sfc_efx/base/rhead_rx.c:317:
+	EFX_STATIC_ASSERT(sizeof (idsp[0]) ==

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#224: FILE: drivers/common/sfc_efx/base/rhead_rx.c:321:
+	    *nids * sizeof (idsp[0]));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#226: FILE: drivers/common/sfc_efx/base/rhead_rx.c:323:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#235: FILE: drivers/common/sfc_efx/base/rhead_rx.c:332:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#262: FILE: drivers/common/sfc_efx/base/rhead_rx.c:359:
+	return (efx_mcdi_to_rx_prefix_field[mcdi_idx]);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#298: FILE: drivers/common/sfc_efx/base/rhead_rx.c:395:
+	return (efx_rx_prefix_field_to_mcdi[field]);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#314: FILE: drivers/common/sfc_efx/base/rhead_rx.c:411:
+				return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#321: FILE: drivers/common/sfc_efx/base/rhead_rx.c:418:
+	return (0);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#380: FILE: drivers/common/sfc_efx/base/rhead_rx.c:477:
+	memset(erplp, 0, sizeof (*erplp));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#421: FILE: drivers/common/sfc_efx/base/rhead_rx.c:518:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#441: FILE: drivers/common/sfc_efx/base/rhead_rx.c:538:
+	memset(erplp, 0, sizeof (*erplp));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#480: FILE: drivers/common/sfc_efx/base/rhead_rx.c:577:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#506: FILE: drivers/common/sfc_efx/base/rhead_rx.c:634:
+	if ((rc = rhead_rx_choose_prefix_id(enp,

total: 8 errors, 5 warnings, 406 lines checked

           reply	other threads:[~2020-09-24 12:21 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1600949555-28043-43-git-send-email-arybchenko@solarflare.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924122136.4CD8E1DFEC@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arybchenko@solarflare.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).