From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADE2CA04B1 for ; Thu, 24 Sep 2020 14:22:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD5ED1DFEC; Thu, 24 Sep 2020 14:22:01 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id A06C71DFE2; Thu, 24 Sep 2020 14:21:52 +0200 (CEST) In-Reply-To: <1600949555-28043-51-git-send-email-arybchenko@solarflare.com> References: <1600949555-28043-51-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20200924122152.A06C71DFE2@dpdk.org> Date: Thu, 24 Sep 2020 14:21:52 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw78724 [PATCH v3 50/60] common/sfc_efx/base: support UDP tunnel operations for EF100 X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/78724 _coding style issues_ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #171: FILE: drivers/common/sfc_efx/base/efx_mcdi.h:392: +#define MCDI_IN_SET_WORD_NATIVE(_emr, _ofst, _value) \ + MCDI_IN2((_emr), efx_word_t, _ofst)->ew_u16[0] = (_value) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #174: FILE: drivers/common/sfc_efx/base/efx_mcdi.h:395: +#define MCDI_IN_SET_DWORD_NATIVE(_emr, _ofst, _value) \ + MCDI_IN2((_emr), efx_dword_t, _ofst)->ed_u32[0] = (_value) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #379: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:72: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #416: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:109: + EFX_STATIC_ASSERT(sizeof (spec->evers_loc_host) == ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #449: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:142: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #460: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:153: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #503: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:196: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #511: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:204: + memset(spec, 0, sizeof (*spec)); WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'? #524: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:217: + __inout efx_tunnel_udp_entry_t *etuep) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #529: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:222: + return (efx_mcdi_vnic_encap_rule_add(enp, &spec, &etuep->etue_handle)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #537: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:230: + return (efx_mcdi_vnic_encap_rule_remove(enp, etuep->etue_handle)); WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'? #544: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:237: + efx_tunnel_cfg_t *etcp = &enp->en_tunnel_cfg; WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'? #559: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:252: + memcpy(&etc, etcp, sizeof (etc)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #559: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:252: + memcpy(&etc, etcp, sizeof (etc)); WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'? #597: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:290: + for (i = 0, j = 0; i < etcp->etc_udp_entries_num; i++) { WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'? #598: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:291: + efx_tunnel_udp_entry_t *cur_entry = &etcp->etc_udp_entries[i]; ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #610: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:303: + return (0); total: 9 errors, 8 warnings, 495 lines checked