From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F302AA04B5 for ; Wed, 30 Sep 2020 17:02:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DDF651D668; Wed, 30 Sep 2020 17:02:12 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id E4B201DB23; Wed, 30 Sep 2020 17:02:11 +0200 (CEST) In-Reply-To: <68ecd941-9c56-4de7-fae2-2ad15bdfd81a@alibaba-inc.com> References: <68ecd941-9c56-4de7-fae2-2ad15bdfd81a@alibaba-inc.com> To: test-report@dpdk.org Cc: " =?utf-8?b?6LCi5Y2O5LyfKOatpOaXtuatpOWIu++8iQ==?= " Message-Id: <20200930150211.E4B201DB23@dpdk.org> Date: Wed, 30 Sep 2020 17:02:11 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw79367 [PATCH v2] pci: support both PIO and MMIO BAR for legacy virtio on x86 X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/79367 _coding style issues_ Must be a reply to the first patch (--in-reply-to). ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit 0123456789ab ("commit description")' #67: >From c13f981e287254cd0877cc7b98ee2dd7b80c3b69 Mon Sep 17 00:00:00 2001 WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #70: Subject: [PATCH v2] pci:  support both PIO and MMIO BAR for legacy virtio on ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?) #234: FILE: drivers/bus/pci/linux/pci.c:686: rte_pci_device *device, WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #311: FILE: drivers/bus/pci/linux/pci.c:699:          if (pci_vfio_is_enabled()) +            ret = pci_uio_ioport_map(dev, bar, p); WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #362: FILE: drivers/bus/pci/linux/pci.c:763:          if (pci_vfio_is_enabled()) +            ret = pci_uio_ioport_unmap(p); ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #388: FILE: drivers/bus/pci/linux/pci_uio.c:376: +    FILE *f = NULL; ^ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #408: FILE: drivers/bus/pci/linux/pci_uio.c:391: +    if (f == NULL) { +        RTE_LOG(ERR, EAL, "Cannot open sysfs resource: %s ", WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #417: FILE: drivers/bus/pci/linux/pci_uio.c:397: +    for (i = 0; i < bar + 1; i++) { +        if (fgets(buf, sizeof(buf), f) == NULL) { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #418: FILE: drivers/bus/pci/linux/pci_uio.c:398: +        if (fgets(buf, sizeof(buf), f) == NULL) { +            RTE_LOG(ERR, EAL, "Cannot read sysfs resource "); WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #423: FILE: drivers/bus/pci/linux/pci_uio.c:403: +    if (pci_parse_one_sysfs_resource(buf, sizeof(buf), &phys_addr, [...] +        goto error; WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #434: FILE: drivers/bus/pci/linux/pci_uio.c:407: +    if (flags & IORESOURCE_IO) { +        iobar = 1; ERROR:TRAILING_WHITESPACE: trailing whitespace #437: FILE: drivers/bus/pci/linux/pci_uio.c:410: +        RTE_LOG(INFO, EAL, "%s(): PIO BAR %08lx detected ", __func__, $ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #439: FILE: drivers/bus/pci/linux/pci_uio.c:411: +    } else if (flags & IORESOURCE_MEM) { +        iobar = 0; ERROR:TRAILING_WHITESPACE: trailing whitespace #442: FILE: drivers/bus/pci/linux/pci_uio.c:414: +        RTE_LOG(INFO, EAL, "%s(): MMIO BAR %08lx detected ", __func__, $ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #444: FILE: drivers/bus/pci/linux/pci_uio.c:415: +    } else { +        RTE_LOG(ERR, EAL, "%s(): unknown BAR type ", __func__); WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #449: FILE: drivers/bus/pci/linux/pci_uio.c:420: +    if (iobar && rte_eal_iopl_init() != 0) { +        RTE_LOG(ERR, EAL, "%s(): insufficient ioport permissions for ERROR:TRAILING_WHITESPACE: trailing whitespace #450: FILE: drivers/bus/pci/linux/pci_uio.c:421: +        RTE_LOG(ERR, EAL, "%s(): insufficient ioport permissions for $ ERROR:SPACING: spaces required around that '=' (ctx:VxV) #480: FILE: drivers/bus/pci/linux/pci_uio.c:443: +    RTE_LOG(DEBUG, EAL, "PCI IO port found start=0x%lx ", base); ^ total: 7 errors, 11 warnings, 363 lines checked