* [dpdk-test-report] |WARNING| pw80544 [PATCH 23/36] net/sfc: support TSO for EF100 native datapath
[not found] <1602596753-32282-24-git-send-email-arybchenko@solarflare.com>
@ 2020-10-13 13:59 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-10-13 13:59 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/80544
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'header_len > txq->tso_max_header_len'
#213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123:
+ if (unlikely((header_len > txq->tso_max_header_len) |
+ (nb_payload_descs > txq->tso_max_nb_payload_descs) |
+ (payload_len > txq->tso_max_payload_len) |
+ (payload_len > mss_conformant_max_payload_len) |
+ (m->pkt_len == header_len)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_payload_descs > txq->tso_max_nb_payload_descs'
#213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123:
+ if (unlikely((header_len > txq->tso_max_header_len) |
+ (nb_payload_descs > txq->tso_max_nb_payload_descs) |
+ (payload_len > txq->tso_max_payload_len) |
+ (payload_len > mss_conformant_max_payload_len) |
+ (m->pkt_len == header_len)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'payload_len > txq->tso_max_payload_len'
#213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123:
+ if (unlikely((header_len > txq->tso_max_header_len) |
+ (nb_payload_descs > txq->tso_max_nb_payload_descs) |
+ (payload_len > txq->tso_max_payload_len) |
+ (payload_len > mss_conformant_max_payload_len) |
+ (m->pkt_len == header_len)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'payload_len > mss_conformant_max_payload_len'
#213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123:
+ if (unlikely((header_len > txq->tso_max_header_len) |
+ (nb_payload_descs > txq->tso_max_nb_payload_descs) |
+ (payload_len > txq->tso_max_payload_len) |
+ (payload_len > mss_conformant_max_payload_len) |
+ (m->pkt_len == header_len)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->pkt_len == header_len'
#213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123:
+ if (unlikely((header_len > txq->tso_max_header_len) |
+ (nb_payload_descs > txq->tso_max_nb_payload_descs) |
+ (payload_len > txq->tso_max_payload_len) |
+ (payload_len > mss_conformant_max_payload_len) |
+ (m->pkt_len == header_len)))
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#218: FILE: drivers/net/sfc/sfc_ef100_tx.c:128:
+ return EINVAL;
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#386: FILE: drivers/net/sfc/sfc_ef100_tx.c:516:
+ sfc_ef100_tx_qdesc_seg_create(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#396: FILE: drivers/net/sfc/sfc_ef100_tx.c:526:
+ sfc_ef100_tx_qdesc_seg_create(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#403: FILE: drivers/net/sfc/sfc_ef100_tx.c:533:
+ sfc_ef100_tx_qdesc_seg_create(
total: 0 errors, 1 warnings, 8 checks, 407 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-13 13:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1602596753-32282-24-git-send-email-arybchenko@solarflare.com>
2020-10-13 13:59 ` [dpdk-test-report] |WARNING| pw80544 [PATCH 23/36] net/sfc: support TSO for EF100 native datapath checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).