From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E83ECA04B7 for ; Tue, 13 Oct 2020 15:59:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC5811DC4E; Tue, 13 Oct 2020 15:59:44 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 7F0471DC47; Tue, 13 Oct 2020 15:59:43 +0200 (CEST) In-Reply-To: <1602596753-32282-24-git-send-email-arybchenko@solarflare.com> References: <1602596753-32282-24-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20201013135943.7F0471DC47@dpdk.org> Date: Tue, 13 Oct 2020 15:59:43 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw80544 [PATCH 23/36] net/sfc: support TSO for EF100 native datapath X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/80544 _coding style issues_ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'header_len > txq->tso_max_header_len' #213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123: + if (unlikely((header_len > txq->tso_max_header_len) | + (nb_payload_descs > txq->tso_max_nb_payload_descs) | + (payload_len > txq->tso_max_payload_len) | + (payload_len > mss_conformant_max_payload_len) | + (m->pkt_len == header_len))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_payload_descs > txq->tso_max_nb_payload_descs' #213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123: + if (unlikely((header_len > txq->tso_max_header_len) | + (nb_payload_descs > txq->tso_max_nb_payload_descs) | + (payload_len > txq->tso_max_payload_len) | + (payload_len > mss_conformant_max_payload_len) | + (m->pkt_len == header_len))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'payload_len > txq->tso_max_payload_len' #213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123: + if (unlikely((header_len > txq->tso_max_header_len) | + (nb_payload_descs > txq->tso_max_nb_payload_descs) | + (payload_len > txq->tso_max_payload_len) | + (payload_len > mss_conformant_max_payload_len) | + (m->pkt_len == header_len))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'payload_len > mss_conformant_max_payload_len' #213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123: + if (unlikely((header_len > txq->tso_max_header_len) | + (nb_payload_descs > txq->tso_max_nb_payload_descs) | + (payload_len > txq->tso_max_payload_len) | + (payload_len > mss_conformant_max_payload_len) | + (m->pkt_len == header_len))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->pkt_len == header_len' #213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123: + if (unlikely((header_len > txq->tso_max_header_len) | + (nb_payload_descs > txq->tso_max_nb_payload_descs) | + (payload_len > txq->tso_max_payload_len) | + (payload_len > mss_conformant_max_payload_len) | + (m->pkt_len == header_len))) WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL) #218: FILE: drivers/net/sfc/sfc_ef100_tx.c:128: + return EINVAL; CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #386: FILE: drivers/net/sfc/sfc_ef100_tx.c:516: + sfc_ef100_tx_qdesc_seg_create( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #396: FILE: drivers/net/sfc/sfc_ef100_tx.c:526: + sfc_ef100_tx_qdesc_seg_create( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #403: FILE: drivers/net/sfc/sfc_ef100_tx.c:533: + sfc_ef100_tx_qdesc_seg_create( total: 0 errors, 1 warnings, 8 checks, 407 lines checked