automatic DPDK test reports
 help / color / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Dharmik Thakkar <dharmik.thakkar@arm.com>
Subject: [dpdk-test-report] |WARNING| pw81161 [PATCH v3 3/3] test/hash: add tests for integrated RCU QSBR
Date: Fri, 16 Oct 2020 19:40:31 +0200 (CEST)
Message-ID: <20201016174031.0BE71C906@dpdk.org> (raw)
In-Reply-To: <20201016173858.1134-4-dharmik.thakkar@arm.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/81161

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#82: FILE: app/test/test_hash.c:63:
+#define RETURN_IF_ERROR_RCU_QSBR(cond, str, ...) do {			\
+	if (cond) {							\
+		printf("ERROR line %d: " str "
", __LINE__, ##__VA_ARGS__); \
+		if (rcu_cfg.mode == RTE_HASH_QSBR_MODE_SYNC) {		\
+			writer_done = 1;				\
+			/* Wait until reader exited. */			\
+			rte_eal_mp_wait_lcore();			\
+		}							\
+		if (g_handle) rte_hash_free(g_handle);			\
+		if (g_qsv) rte_free(g_qsv);				\
+		return -1;						\
+	}								\
+} while(0)

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#90: FILE: app/test/test_hash.c:71:
+		if (g_handle) rte_hash_free(g_handle);			\

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#91: FILE: app/test/test_hash.c:72:
+		if (g_qsv) rte_free(g_qsv);				\

ERROR:SPACING: space required before the open parenthesis '('
#94: FILE: app/test/test_hash.c:75:
+} while(0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#211: FILE: app/test/test_hash.c:1926:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#381: FILE: app/test/test_hash.c:2096:
+	unsigned i;

WARNING:TYPO_SPELLING: 'nNumber' may be misspelled - perhaps 'number'?
#637: FILE: app/test/test_hash_readwrite_lf_perf.c:1331:
+		printf("
Number of writers: %u
", rwc_core_cnt[n]);

total: 3 errors, 4 warnings, 639 lines checked

       reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201016173858.1134-4-dharmik.thakkar@arm.com>
2020-10-16 17:40 ` checkpatch [this message]
2020-10-16 18:55 ` [dpdk-test-report] || pw81161 " 0-day Robot

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201016174031.0BE71C906@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=dharmik.thakkar@arm.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

automatic DPDK test reports

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/test-report/0 test-report/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 test-report test-report/ http://inbox.dpdk.org/test-report \
		test-report@dpdk.org
	public-inbox-index test-report


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.test-report


AGPL code for this site: git clone https://public-inbox.org/ public-inbox