From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw81459 [PATCH 20/62] common/sfc_efx/base: support adding DELIVER action to a set
Date: Tue, 20 Oct 2020 10:55:45 +0200 (CEST) [thread overview]
Message-ID: <20201020085545.98EEFBBF6@dpdk.org> (raw)
In-Reply-To: <1603183709-23420-21-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/81459
_coding style issues_
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#176: FILE: drivers/common/sfc_efx/base/efx_mae.c:652:
+ if (arg_size != sizeof (spec->emass_deliver_mport)) {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#188: FILE: drivers/common/sfc_efx/base/efx_mae.c:664:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#194: FILE: drivers/common/sfc_efx/base/efx_mae.c:670:
+ return (rc);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_mae_actions_t *' should also have an identifier name
#199: FILE: drivers/common/sfc_efx/base/efx_mae.c:675:
+ efx_rc_t (*emad_add)(efx_mae_actions_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name
#199: FILE: drivers/common/sfc_efx/base/efx_mae.c:675:
+ efx_rc_t (*emad_add)(efx_mae_actions_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const uint8_t *' should also have an identifier name
#199: FILE: drivers/common/sfc_efx/base/efx_mae.c:675:
+ efx_rc_t (*emad_add)(efx_mae_actions_t *,
ERROR:INITIALISED_STATIC: do not initialise statics to 0
#212: FILE: drivers/common/sfc_efx/base/efx_mae.c:688:
+static const uint32_t efx_mae_action_repeat_map = 0;
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#231: FILE: drivers/common/sfc_efx/base/efx_mae.c:707:
+ (sizeof (efx_mae_action_ordered_map) * 8));
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#233: FILE: drivers/common/sfc_efx/base/efx_mae.c:709:
+ (sizeof (efx_mae_action_repeat_map) * 8));
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#273: FILE: drivers/common/sfc_efx/base/efx_mae.c:749:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#283: FILE: drivers/common/sfc_efx/base/efx_mae.c:759:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#302: FILE: drivers/common/sfc_efx/base/efx_mae.c:778:
+ EFX_MAE_ACTION_DELIVER, sizeof (mportp->sel), arg));
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#306: FILE: drivers/common/sfc_efx/base/efx_mae.c:782:
+ return (rc);
total: 6 errors, 7 warnings, 199 lines checked
parent reply other threads:[~2020-10-20 8:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1603183709-23420-21-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020085545.98EEFBBF6@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).