* [dpdk-test-report] |WARNING| pw81459 [PATCH 20/62] common/sfc_efx/base: support adding DELIVER action to a set
[not found] <1603183709-23420-21-git-send-email-arybchenko@solarflare.com>
@ 2020-10-20 8:55 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-10-20 8:55 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/81459
_coding style issues_
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#176: FILE: drivers/common/sfc_efx/base/efx_mae.c:652:
+ if (arg_size != sizeof (spec->emass_deliver_mport)) {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#188: FILE: drivers/common/sfc_efx/base/efx_mae.c:664:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#194: FILE: drivers/common/sfc_efx/base/efx_mae.c:670:
+ return (rc);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_mae_actions_t *' should also have an identifier name
#199: FILE: drivers/common/sfc_efx/base/efx_mae.c:675:
+ efx_rc_t (*emad_add)(efx_mae_actions_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name
#199: FILE: drivers/common/sfc_efx/base/efx_mae.c:675:
+ efx_rc_t (*emad_add)(efx_mae_actions_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const uint8_t *' should also have an identifier name
#199: FILE: drivers/common/sfc_efx/base/efx_mae.c:675:
+ efx_rc_t (*emad_add)(efx_mae_actions_t *,
ERROR:INITIALISED_STATIC: do not initialise statics to 0
#212: FILE: drivers/common/sfc_efx/base/efx_mae.c:688:
+static const uint32_t efx_mae_action_repeat_map = 0;
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#231: FILE: drivers/common/sfc_efx/base/efx_mae.c:707:
+ (sizeof (efx_mae_action_ordered_map) * 8));
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#233: FILE: drivers/common/sfc_efx/base/efx_mae.c:709:
+ (sizeof (efx_mae_action_repeat_map) * 8));
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#273: FILE: drivers/common/sfc_efx/base/efx_mae.c:749:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#283: FILE: drivers/common/sfc_efx/base/efx_mae.c:759:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#302: FILE: drivers/common/sfc_efx/base/efx_mae.c:778:
+ EFX_MAE_ACTION_DELIVER, sizeof (mportp->sel), arg));
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#306: FILE: drivers/common/sfc_efx/base/efx_mae.c:782:
+ return (rc);
total: 6 errors, 7 warnings, 199 lines checked
^ permalink raw reply [flat|nested] only message in thread