From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DE0F8A04DD
	for <public@inbox.dpdk.org>; Tue, 20 Oct 2020 18:16:15 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D106DA8ED;
	Tue, 20 Oct 2020 18:16:14 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id B70C0A8EE; Tue, 20 Oct 2020 18:16:13 +0200 (CEST)
In-Reply-To: <20201020161301.7458-5-dharmik.thakkar@arm.com>
References: <20201020161301.7458-5-dharmik.thakkar@arm.com>
To: test-report@dpdk.org
Cc: Dharmik Thakkar <dharmik.thakkar@arm.com>
Message-Id: <20201020161613.B70C0A8EE@dpdk.org>
Date: Tue, 20 Oct 2020 18:16:13 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw81606 [PATCH v5 4/4] test/hash: add
	tests for integrated RCU QSBR
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/81606

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#82: FILE: app/test/test_hash.c:63:
+#define RETURN_IF_ERROR_RCU_QSBR(cond, str, ...) do {			\
+	if (cond) {							\
+		printf("ERROR line %d: " str "
", __LINE__, ##__VA_ARGS__); \
+		if (rcu_cfg.mode == RTE_HASH_QSBR_MODE_SYNC) {		\
+			writer_done = 1;				\
+			/* Wait until reader exited. */			\
+			rte_eal_mp_wait_lcore();			\
+		}							\
+		if (g_handle) rte_hash_free(g_handle);			\
+		if (g_qsv) rte_free(g_qsv);				\
+		return -1;						\
+	}								\
+} while(0)

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#90: FILE: app/test/test_hash.c:71:
+		if (g_handle) rte_hash_free(g_handle);			\

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#91: FILE: app/test/test_hash.c:72:
+		if (g_qsv) rte_free(g_qsv);				\

ERROR:SPACING: space required before the open parenthesis '('
#94: FILE: app/test/test_hash.c:75:
+} while(0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#211: FILE: app/test/test_hash.c:1926:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#381: FILE: app/test/test_hash.c:2096:
+	unsigned i;

WARNING:TYPO_SPELLING: 'nNumber' may be misspelled - perhaps 'number'?
#629: FILE: app/test/test_hash_readwrite_lf_perf.c:1330:
+		printf("
Number of writers: %u
", rwc_core_cnt[n]);

total: 3 errors, 4 warnings, 632 lines checked