* [dpdk-test-report] |WARNING| pw81717 [PATCH v6 4/4] test/hash: add tests for integrated RCU QSBR
[not found] <20201021225006.10438-5-dharmik.thakkar@arm.com>
@ 2020-10-21 22:53 ` checkpatch
2020-10-22 0:27 ` [dpdk-test-report] |SUCCESS| pw81717 " 0-day Robot
1 sibling, 0 replies; 2+ messages in thread
From: checkpatch @ 2020-10-21 22:53 UTC (permalink / raw)
To: test-report; +Cc: Dharmik Thakkar
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/81717
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#82: FILE: app/test/test_hash.c:63:
+#define RETURN_IF_ERROR_RCU_QSBR(cond, str, ...) do { \
+ if (cond) { \
+ printf("ERROR line %d: " str "
", __LINE__, ##__VA_ARGS__); \
+ if (rcu_cfg.mode == RTE_HASH_QSBR_MODE_SYNC) { \
+ writer_done = 1; \
+ /* Wait until reader exited. */ \
+ rte_eal_mp_wait_lcore(); \
+ } \
+ if (g_handle) rte_hash_free(g_handle); \
+ if (g_qsv) rte_free(g_qsv); \
+ return -1; \
+ } \
+} while(0)
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#90: FILE: app/test/test_hash.c:71:
+ if (g_handle) rte_hash_free(g_handle); \
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#91: FILE: app/test/test_hash.c:72:
+ if (g_qsv) rte_free(g_qsv); \
ERROR:SPACING: space required before the open parenthesis '('
#94: FILE: app/test/test_hash.c:75:
+} while(0)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#211: FILE: app/test/test_hash.c:1926:
+ unsigned i;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#381: FILE: app/test/test_hash.c:2096:
+ unsigned i;
WARNING:TYPO_SPELLING: 'nNumber' may be misspelled - perhaps 'number'?
#629: FILE: app/test/test_hash_readwrite_lf_perf.c:1330:
+ printf("
Number of writers: %u
", rwc_core_cnt[n]);
total: 3 errors, 4 warnings, 632 lines checked
^ permalink raw reply [flat|nested] 2+ messages in thread