automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-test-report] |WARNING| pw82119 [PATCH v7 3/5] eal: replace pci-whitelist/pci-blacklist options
Date: Sun, 25 Oct 2020 21:59:57 +0100 (CET)	[thread overview]
Message-ID: <20201025205957.5E5D12BCE@dpdk.org> (raw)
In-Reply-To: <20201025205727.28570-4-stephen@networkplumber.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/82119

_coding style issues_


WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#65: 
Subject: [dpdk-dev] [PATCH v7 3/5] eal: replace pci-whitelist/pci-blacklist

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#65: 
Subject: [dpdk-dev] [PATCH v7 3/5] eal: replace pci-whitelist/pci-blacklist

WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#81: 
Replace -w / --pci-whitelist with -a / --allow options

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#82: 
and --pci-blacklist with --block.

WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#114: FILE: lib/librte_eal/common/eal_common_options.c:67:
+	"w:" /* whitelist (deprecated) */

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#115: FILE: lib/librte_eal/common/eal_common_options.c:68:
+	"B:" /* blacklist (deprecated) */

WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#136: FILE: lib/librte_eal/common/eal_common_options.c:112:
+	{OPT_PCI_BLACKLIST,     1, NULL, OPT_PCI_BLACKLIST_NUM    },

WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#136: FILE: lib/librte_eal/common/eal_common_options.c:112:
+	{OPT_PCI_BLACKLIST,     1, NULL, OPT_PCI_BLACKLIST_NUM    },

WARNING:TYPO_SPELLING: 'WHITELIST' may be misspelled - perhaps 'ALLOWLIST'?
#137: FILE: lib/librte_eal/common/eal_common_options.c:113:
+	{OPT_PCI_WHITELIST,     1, NULL, OPT_PCI_WHITELIST_NUM    },

WARNING:TYPO_SPELLING: 'WHITELIST' may be misspelled - perhaps 'ALLOWLIST'?
#137: FILE: lib/librte_eal/common/eal_common_options.c:113:
+	{OPT_PCI_WHITELIST,     1, NULL, OPT_PCI_WHITELIST_NUM    },

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#153: FILE: lib/librte_eal/common/eal_common_options.c:1463:
+			"Option --pci-blacklist is deprecated, use -b, --block instead
");

WARNING:BRACES: braces {} are not necessary for single statement blocks
#163: FILE: lib/librte_eal/common/eal_common_options.c:1469:
+		if (eal_option_device_add(RTE_DEVTYPE_BLOCKED, optarg) < 0) {
 			return -1;
 		}

WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#172: FILE: lib/librte_eal/common/eal_common_options.c:1477:
+			"Option -w, --pci-whitelist is deprecated, use -a, --allow option instead
");

WARNING:BRACES: braces {} are not necessary for single statement blocks
#181: FILE: lib/librte_eal/common/eal_common_options.c:1483:
+		if (eal_option_device_add(RTE_DEVTYPE_ALLOWED, optarg) < 0) {
 			return -1;
 		}

WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#242: FILE: lib/librte_eal/common/eal_options.h:23:
+	OPT_PCI_BLACKLIST_NUM  = 'B',

total: 0 errors, 15 warnings, 136 lines checked

           reply	other threads:[~2020-10-25 21:00 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20201025205727.28570-4-stephen@networkplumber.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201025205957.5E5D12BCE@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).