From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw83974 [PATCH v2 34/37] net/txgbe: add security session create operation
Date: Wed, 11 Nov 2020 08:00:37 +0100 (CET) [thread overview]
Message-ID: <20201111070037.7A32F31FC@dpdk.org> (raw)
In-Reply-To: <20201111064936.768604-35-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/83974
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#99: FILE: drivers/net/txgbe/txgbe_ipsec.c:16:
+#define CMP_IP(a, b) (\
+ (a).ipv6[0] == (b).ipv6[0] && \
+ (a).ipv6[1] == (b).ipv6[1] && \
+ (a).ipv6[2] == (b).ipv6[2] && \
+ (a).ipv6[3] == (b).ipv6[3])
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#99: FILE: drivers/net/txgbe/txgbe_ipsec.c:16:
+#define CMP_IP(a, b) (\
+ (a).ipv6[0] == (b).ipv6[0] && \
+ (a).ipv6[1] == (b).ipv6[1] && \
+ (a).ipv6[2] == (b).ipv6[2] && \
+ (a).ipv6[3] == (b).ipv6[3])
CHECK:CAMELCASE: Avoid CamelCase: <IPv6>
#173: FILE: drivers/net/txgbe/txgbe_ipsec.c:90:
+ if (ic_session->dst_ip.type == IPv6) {
CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#176: FILE: drivers/net/txgbe/txgbe_ipsec.c:93:
+ } else if (ic_session->dst_ip.type == IPv4) {
WARNING:REPEATED_WORD: Possible repeated word: 'crypto'
#401: FILE: drivers/net/txgbe/txgbe_ipsec.h:42:
+/** inline crypto crypto private session structure */
total: 0 errors, 1 warnings, 4 checks, 355 lines checked
parent reply other threads:[~2020-11-11 7:00 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201111064936.768604-35-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111070037.7A32F31FC@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).